chore: Upgrade fuselage packages - #39169
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughReplaced uses of MenuV2 with Menu in three UI components (imports, JSX, and one prop type) and updated Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #39169 +/- ##
===========================================
+ Coverage 70.85% 70.87% +0.01%
===========================================
Files 3208 3208
Lines 113431 113431
Branches 20542 20545 +3
===========================================
+ Hits 80376 80395 +19
+ Misses 31004 30991 -13
+ Partials 2051 2045 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/web-ui-registration/src/LoginForm.tsx`:
- Line 72: Remove the leftover debug console.log by deleting the
console.log(errors) statement in the LoginForm component (function/component
LoginForm in LoginForm.tsx); if you need to keep diagnostic output during
development, replace it with a conditional dev-only logger (e.g., wrap in if
(process.env.NODE_ENV !== 'production') or use the existing app logger) so no
form errors are logged in production.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (14)
apps/meteor/package.jsonapps/uikit-playground/package.jsonee/packages/ui-theming/package.jsonpackages/fuselage-ui-kit/package.jsonpackages/gazzodown/package.jsonpackages/storybook-config/package.jsonpackages/ui-avatar/package.jsonpackages/ui-client/package.jsonpackages/ui-composer/package.jsonpackages/ui-contexts/package.jsonpackages/ui-video-conf/package.jsonpackages/ui-voip/package.jsonpackages/web-ui-registration/package.jsonpackages/web-ui-registration/src/LoginForm.tsx
🚧 Files skipped from review as they are similar to previous changes (11)
- apps/meteor/package.json
- packages/ui-voip/package.json
- packages/web-ui-registration/package.json
- packages/ui-client/package.json
- apps/uikit-playground/package.json
- packages/storybook-config/package.json
- packages/fuselage-ui-kit/package.json
- packages/gazzodown/package.json
- packages/ui-composer/package.json
- packages/ui-avatar/package.json
- packages/ui-video-conf/package.json
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: 📦 Build Packages
- GitHub Check: cubic · AI code reviewer
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
packages/web-ui-registration/src/LoginForm.tsx
🧠 Learnings (6)
📓 Common learnings
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: Rocket.Chat repo context: When a workspace manifest on develop already pins a dependency version (e.g., packages/web-ui-registration → "rocket.chat/ui-contexts": "27.0.1"), a lockfile change in a feature PR that upgrades only that dependency’s resolution is considered a manifest-driven sync and can be kept, preferably as a small "chore: sync yarn.lock with manifests" commit.
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: In Rocket.Chat PRs, keep feature PRs free of unrelated lockfile-only dependency bumps; prefer reverting lockfile drift or isolating such bumps into a separate "chore" commit/PR, and always use yarn install --immutable with the Yarn version pinned in package.json via Corepack.
📚 Learning: 2026-02-24T19:05:56.710Z
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: Rocket.Chat repo context: When a workspace manifest on develop already pins a dependency version (e.g., packages/web-ui-registration → "rocket.chat/ui-contexts": "27.0.1"), a lockfile change in a feature PR that upgrades only that dependency’s resolution is considered a manifest-driven sync and can be kept, preferably as a small "chore: sync yarn.lock with manifests" commit.
Applied to files:
packages/ui-contexts/package.jsonee/packages/ui-theming/package.json
📚 Learning: 2026-02-24T19:05:56.710Z
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: In Rocket.Chat PRs, keep feature PRs free of unrelated lockfile-only dependency bumps; prefer reverting lockfile drift or isolating such bumps into a separate "chore" commit/PR, and always use yarn install --immutable with the Yarn version pinned in package.json via Corepack.
Applied to files:
packages/ui-contexts/package.jsonee/packages/ui-theming/package.json
📚 Learning: 2026-02-24T19:09:09.561Z
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38974
File: apps/meteor/app/api/server/v1/im.ts:220-221
Timestamp: 2026-02-24T19:09:09.561Z
Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs for apps/meteor/app/api/server/v1 endpoints, maintainers prefer to avoid any logic changes; style-only cleanups (like removing inline comments) may be deferred to follow-ups to keep scope tight.
Applied to files:
packages/ui-contexts/package.json
📚 Learning: 2025-11-19T12:32:29.696Z
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.
Applied to files:
packages/ui-contexts/package.json
📚 Learning: 2026-02-25T20:10:16.987Z
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38913
File: packages/ddp-client/src/legacy/types/SDKLegacy.ts:34-34
Timestamp: 2026-02-25T20:10:16.987Z
Learning: In the RocketChat/Rocket.Chat monorepo, packages/ddp-client and apps/meteor do not use TypeScript project references. Module augmentations in apps/meteor (e.g., declare module 'rocket.chat/rest-typings') are not visible when compiling packages/ddp-client in isolation, which is why legacy SDK methods that depend on OperationResult types for OpenAPI-migrated endpoints must remain commented out.
Applied to files:
packages/ui-contexts/package.jsonee/packages/ui-theming/package.json
🔇 Additional comments (2)
ee/packages/ui-theming/package.json (1)
19-20: Dependency bump for@rocket.chat/fuselageand@rocket.chat/fuselage-hooksis consistent and safe.The versions
^0.72.1and^0.40.0are pinned across the monorepo with a manifest-driven sync (isolated chore commit), and peer dependencies are declared with wildcards, so no version conflicts exist.packages/ui-contexts/package.json (1)
25-26: Fuselage 0.72.1 breaking change confirmed; fuselage-hooks version requires clarification.
@rocket.chat/fuselage@0.72.1 includes the MenuV2 → Menu breaking change (imports renamed, legacy Menu removed). However, @rocket.chat/fuselage-hooks@0.40.0 does not appear to exist on npm—available versions are around 0.37.x–0.38.x. Verify the intended version for fuselage-hooks and confirm compatibility with the fuselage bump.
b0a5fda to
658f7fb
Compare
658f7fb to
48c580c
Compare
48c580c to
0392d7d
Compare
juliajforesti
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
3 participants
Proposed changes (including videos or screenshots)
Release changes:
@rocket.chat/fuselage@0.73.0
@rocket.chat/fuselage@0.72.1
@rocket.chat/fuselage@0.72.0
@rocket.chat/fuselage-hooks@0.40.0
MenuV2imports toMenuIssue(s)
Steps to test or reproduce
Further comments
WA-75
CORE-1750
Summary by CodeRabbit
Refactor
Chores