fix: allow users to clear bio field in profile #38277

dodaa08 · 2026-01-20T18:55:51Z

Proposed changes (including videos or screenshots)

When users cleared their bio field, it was stored as an empty string ("") in the database instead of being removed, so the UI still showed the old bio.

Screencast.From.2026-01-21.00-15-37.mp4

Updated saveUserProfile to:

Trim the bio value before processing
When the trimmed bio is empty, set unset.bio = true so notifyOnUserChange includes it in the unset payload
Call Users.setBio() with the empty string, which removes the field from the database
The client receives the unset notification and removes bio from the local user store immediately
Result: Clearing the bio removes it from the database and the UI updates without a refresh.

Screencast.From.2026-01-20.23-33-36.mp4

Environment

RC version : 8.0.1-develop
Browser : Brave
OS : fedora

Issue(s)

Fixes #33783

Steps to test or reproduce

Add a non-empty bio, save, and confirm it shows in the profile and user info.
Now clear the bio field completely and save again.
Navigate away and back to the profile page (or reopen the profile modal).

Expected:

The bio field is empty in the form.
The user document no longer has a bio value, and other profile fields are unchanged.

Further comments

Hoping the approach works well for the fix, let me know if it does.

Summary by CodeRabbit

Bug Fixes
- Bio input validation now trims whitespace before checking length limits, ensuring more accurate limit enforcement.
- Whitespace-only bio entries are now properly handled during profile updates.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

When users cleared their bio field, it remained in the database as an empty string instead of being removed. This fix ensures that empty bio values are properly unset from the database, allowing users to successfully clear their bio

dionisio-bot · 2026-01-20T18:55:55Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label
This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2026-01-20T18:55:56Z

⚠️ No Changeset found

Latest commit: 992c4d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-01-20T18:56:31Z

Walkthrough

The pull request modifies bio handling in the user profile save method to trim input before validation. It introduces branching logic: if trimmed bio is empty, the bio field is unset; otherwise, trimmed bio is stored. Error handling now checks trimmed bio length rather than original input length.

Changes

Cohort / File(s)	Summary
Bio Validation and Storage Logic `apps/meteor/server/methods/saveUserProfile.ts`	Modified bio handling to trim input early and branch on whether trimmed bio is empty, affecting both validation thresholds and persistence strategy (unset flag vs. storing value)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

fix: Cannot save some user profile fields as empty #37430 — Directly modifies the same file to improve bio handling validation and persistence for empty/trimmed values.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

ricardogarim
dougfabris

Poem

🐰 A bio trimmed with care so true,
Empty fields now bid adieu!
No phantom text shall linger here,
Just whitespace vanished, crystal clear. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: allow users to clear bio field in profile' directly describes the main change—enabling users to clear their bio field—which is the primary objective of this changeset.
Linked Issues check	✅ Passed	The code changes implement all requirements from issue `#33783`: trimming bio input, setting unset.bio flag when empty, and calling Users.setBio() to remove the field from the database, enabling bio clearing functionality.
Out of Scope Changes check	✅ Passed	All changes in saveUserProfile.ts are scoped to fixing bio field clearing; no out-of-scope modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cubic-dev-ai

No issues found across 1 file

codecov · 2026-01-20T19:02:06Z

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.77%. Comparing base (78ea84f) to head (992c4d9).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #38277      +/-   ##
===========================================
+ Coverage    70.75%   70.77%   +0.02%     
===========================================
  Files         3142     3142              
  Lines       108927   108930       +3     
  Branches     19632    19610      -22     
===========================================
+ Hits         77072    77100      +28     
+ Misses       29850    29833      -17     
+ Partials      2005     1997       -8

Flag	Coverage Δ
e2e	`60.33% <ø> (-0.05%)`	⬇️
e2e-api	`49.15% <80.00%> (+1.04%)`	⬆️
unit	`71.87% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dougfabris · 2026-01-22T20:55:11Z

Hi there, thanks for the contribution! 🚀 💯

Closing this PR because it's stale now and it was already fixed here #37430

Questions? Help needed? Feature Requests?

Join our Open Server in the #support channel and feel free to raise a question
Join our Community Forum and search/create a post there

fix: allow users to clear bio field in profile

ad8b137

When users cleared their bio field, it remained in the database as an empty string instead of being removed. This fix ensures that empty bio values are properly unset from the database, allowing users to successfully clear their bio

dodaa08 requested a review from a team as a code owner January 20, 2026 18:55

cubic-dev-ai bot reviewed Jan 20, 2026

View reviewed changes

Merge branch 'develop' into fix/ClearUserBio

992c4d9

dougfabris closed this Jan 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: allow users to clear bio field in profile #38277

fix: allow users to clear bio field in profile #38277

Uh oh!

dodaa08 commented Jan 20, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Jan 20, 2026

Uh oh!

changeset-bot bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

codecov bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

dougfabris commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: allow users to clear bio field in profile #38277

fix: allow users to clear bio field in profile #38277

Uh oh!

Conversation

dodaa08 commented Jan 20, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Jan 20, 2026

Uh oh!

changeset-bot bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dougfabris commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dodaa08 commented Jan 20, 2026 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jan 20, 2026 •

edited

Loading

coderabbitai bot commented Jan 20, 2026 •

edited

Loading

codecov bot commented Jan 20, 2026 •

edited

Loading