feat: Add "Direct Message" button to Media Call widget #38169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: afcbedd The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
WalkthroughAdds a DM quick-link from the call widget: introduces a new Changes
Sequence DiagramsequenceDiagram
participant Room as Room Component
participant Tracker as useMediaCallOpenRoomTracker
participant Context as MediaCallContext
participant Provider as MediaCallProvider
participant Widget as OngoingCall Widget
participant User as User
participant Router as Router
Room->>Tracker: invoke with room._id
Tracker->>Context: read setOpenRoomId
Tracker->>Context: setOpenRoomId(room._id)
Tracker-->>Context: on unmount setOpenRoomId(undefined)
Widget->>Context: useMediaCallContext()
Context-->>Widget: { onClickDirectMessage, ... }
User->>Widget: click Direct Message button
Widget->>Context: call onClickDirectMessage()
Context->>Router: navigate to direct message route (rid)
Router-->>Room: updates current room
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gabriellsh
changed the base branch from
develop
to
chore/refactorDirectMessageAction
Contributor
📦 Docker Image Size Report➡️ Changes
📊 Historical Trend---
config:
theme: "dark"
xyChart:
width: 900
height: 400
---
xychart
title "Image Size Evolution by Service (Last 30 Days + This PR)"
x-axis ["11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "01/19 22:07 (PR)"]
y-axis "Size (GB)" 0 --> 0.5
line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
line "omnichannel-transcript-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
line "queue-worker-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
line "rocketchat" [0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.00]
Statistics (last 30 days):
ℹ️ About this reportThis report compares Docker image sizes from this build against the
Updated: Mon, 19 Jan 2026 22:07:10 GMT |
gabriellsh
force-pushed
the
feat/widgetGoToRoom
branch
from
c24ee18 to
813677a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #38169 +/- ##
===========================================
- Coverage 70.71% 70.67% -0.05%
===========================================
Files 3141 3142 +1
Lines 108799 108820 +21
Branches 19587 19644 +57
===========================================
- Hits 76942 76912 -30
- Misses 29857 29911 +54
+ Partials 2000 1997 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.changeset/eighty-weeks-rush.md:
- Line 7: Update the changelog sentence that currently reads "Introduces in the
call widget a quick link that redirects to the participants direct message" to
use the correct possessive form by changing "participants direct message" to
"participant's direct message", ensuring the message now reads "Introduces in
the call widget a quick link that redirects to the participant's direct
message".
In `@packages/ui-client/src/hooks/useGoToDirectMessage.ts`:
- Around line 20-27: The hook creates an unnecessary in-memory subscription by
passing an empty string; instead pass the actual username (possibly undefined)
and make useUserSubscriptionByName guard against falsy input so it returns
undefined early without creating watchers. Update useGoToDirectMessage to call
useUserSubscriptionByName(targetUser.username) (not ''), and change the
useUserSubscriptionByName implementation/signature to accept string | undefined
and immediately return undefined when username is falsy, ensuring no
subscription/predicate is created and types are updated accordingly.
🧹 Nitpick comments (3)
packages/ui-voip/src/views/MediaCallWidget/OngoingCall.stories.tsx (1)
66-72: LGTM! Story demonstrates the DM button feature.The story correctly wraps
OngoingCallwithMockedMediaCallProviderpassingonClickDirectMessageto enable the DM button rendering.Consider using
action('onClickDirectMessage')from@storybook/addon-actionsinstead of() => undefinedto log interactions in the Storybook Actions panel, which aids visual testing.packages/ui-voip/src/context/MediaCallProvider.tsx (1)
13-13: Remove commented-out import.Per coding guidelines, avoid code comments in implementation files. This commented import should be removed.
Suggested fix
- // useRouteParameter,apps/meteor/client/views/mediaCallHistory/useMediaCallInternalHistoryActions.ts (1)
50-50: Consider passingundefinedinstead of empty string.While this works correctly (empty string is falsy, so the
alreadyOpencheck behaves as expected), passingundefinedis semantically clearer when no room is open.Suggested fix
- const goToDirectMessage = useGoToDirectMessage({ username: contact.username }, openRoomId ?? ''); + const goToDirectMessage = useGoToDirectMessage({ username: contact.username }, openRoomId);
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
dougfabris
requested changes
Jan 19, 2026
Co-authored-by: Douglas Fabris <devfabris@gmail.com>
dougfabris
approved these changes
Jan 19, 2026
gabriellsh
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Added a quick link to go back to the callers DM.
Issue(s)
VGA-85
Steps to test or reproduce
Further comments
Summary by CodeRabbit
New Features
Improvements
Tests
✏️ Tip: You can customize this high-level summary in your review settings.