merge uploads #38139

d-gubert · 2026-01-10T22:06:57Z

Proposed changes (including videos or screenshots)

A preview of the merging of two upload related PRs

#38068
#38071

This allows us to see CI runs, but the actual merge will happen on 38071 after 38068 is merged

Issue(s)

Steps to test or reproduce

Further comments

dionisio-bot · 2026-01-10T22:07:00Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label
This PR is missing the required milestone or project
This PR has an invalid title

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2026-01-10T22:07:00Z

🦋 Changeset detected

Latest commit: 91601f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages

Name	Type
@rocket.chat/apps-engine	Patch
@rocket.chat/meteor	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/api-client	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/http-router	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/abac	Patch
@rocket.chat/federation-matrix	Patch
@rocket.chat/license	Patch
@rocket.chat/media-calls	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/omni-core-ee	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/instance-status	Patch
@rocket.chat/omni-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-01-10T22:07:02Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch merge-uploads

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-01-10T22:36:58Z

📦 Docker Image Size Report

➡️ Changes

Service	Current	Baseline	Change
sum of all images	0B	0B	0B
account-service	0B	0B	0B
authorization-service	0B	0B	0B
ddp-streamer-service	0B	0B	0B
omnichannel-transcript-service	0B	0B	0B
presence-service	0B	0B	0B
queue-worker-service	0B	0B	0B
rocketchat	0B	0B	0B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "01/14 15:06 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "queue-worker-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "rocketchat" [0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.00]

Statistics (last 30 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.4GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 0B

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-38139
Baseline: develop
Timestamp: 2026-01-14 15:06:53 UTC
Historical data points: 30

Updated: Wed, 14 Jan 2026 15:06:54 GMT

codecov · 2026-01-10T22:38:30Z

Codecov Report

❌ Patch coverage is 40.98361% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.67%. Comparing base (7bd5853) to head (91601f7).
⚠️ Report is 45 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #38139      +/-   ##
===========================================
+ Coverage    70.61%   70.67%   +0.06%     
===========================================
  Files         3147     3147              
  Lines       108849   108858       +9     
  Branches     19591    19590       -1     
===========================================
+ Hits         76864    76938      +74     
+ Misses       29980    29922      -58     
+ Partials      2005     1998       -7

Flag	Coverage Δ
e2e	`60.24% <ø> (+0.03%)`	⬆️
e2e-api	`47.30% <55.55%> (-0.02%)`	⬇️
unit	`71.81% <33.33%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… request

…g as the limit

…38068)

d-gubert · 2026-01-20T22:13:01Z

Served your purpose. Now rest.

ggazzo added the Invalid PR Title label Jan 10, 2026

d-gubert force-pushed the merge-uploads branch 2 times, most recently from 990ebe7 to 2c36571 Compare January 12, 2026 12:39

d-gubert force-pushed the refactor/s3-large-uploads branch from 37cce45 to 8ddd8a2 Compare January 12, 2026 19:37

d-gubert force-pushed the merge-uploads branch from 2c36571 to 9cc360c Compare January 12, 2026 19:50

d-gubert force-pushed the refactor/s3-large-uploads branch from 8ddd8a2 to eb06322 Compare January 13, 2026 14:13

ricardogarim and others added 19 commits January 13, 2026 17:06

refactor: remove router-level body parsing on form-data requests

63338f0

refactor: remove unnecessary buffering for file size check

555290a

refactor: avoid re-buffering before file validation

ae491a4

refactor: remove unneeded bufferToStream from initialData

6e94ffc

refactor: add UploadService

c266d9e

refactor: adjust POST /rooms.media/:rid to use UploadService

164ba27

refactor: adjust rest of upload routes to use UploadService

cfbe5f6

refactor: use builtin finished api to await the pipe

8f55d52

refactor: streamline removeTempFile in ufsComplete

c4af8ce

refactor: stripExifFromFile stop calling fs.stat

1e8f712

refactor: always warn if cleanup fails

2c141d3

test: adjust router test to comply with new form-data behavior

14aa0cd

refactor: remove unnecessary stat call in ufs-store

99779e9

refactor: use pipeline promises

0a9f08c

refactor: get file size from fs.WriteStream

135d4b4

fix: reject on file truncated as previous implementation

c85eabc

refactor: reuse static cleanup function

9665412

refactor: remove rawRequest from route context in favor of existing…

f202c22

… request

refactor: array view validation before writeFile

2e21cea

d-gubert added 9 commits January 13, 2026 17:06

fix: move exif stripping to after image rotation

9b92e5a

chore: remove redundant call to unlink temp file

6495005

fix: prevent body consumption in logger middleware

8a81284

fix: increase maxSize by 1 byte so we don't block files exactly as bi…

0d11da3

…g as the limit

refactor: simplify request type checks in UploadService

400b8e8

refactor: expose internal http request to route handler

cf8c71c

refactor: revert endpoints that require buffer

40951ed

refactor: settings usage refactor

89e2bca

refactor: remove unnecessary if on finishHandler

dee52dc

d-gubert force-pushed the refactor/s3-large-uploads branch from b071d34 to 51ec79d Compare January 13, 2026 20:06

d-gubert added 2 commits January 13, 2026 18:04

refactor: rename UploadService to MultipartUploadHandler

fca5ce4

fix: properly handle errors during transform pipeline

396ebd5

d-gubert force-pushed the refactor/s3-large-uploads branch from 51ec79d to 396ebd5 Compare January 13, 2026 21:04

d-gubert added 2 commits January 14, 2026 11:48

fix(apps): reduce memory usage on apps-engine IPreFileUpload event (#…

0e9c028

…38068)

feat: adapt app upload event trigger to new upload changes

91601f7

d-gubert force-pushed the merge-uploads branch from 9cc360c to 91601f7 Compare January 14, 2026 14:49

d-gubert force-pushed the refactor/s3-large-uploads branch 3 times, most recently from 0b0841f to 92bada3 Compare January 16, 2026 13:39

Base automatically changed from refactor/s3-large-uploads to develop January 16, 2026 19:35

d-gubert closed this Jan 20, 2026

d-gubert deleted the merge-uploads branch January 20, 2026 22:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

merge uploads #38139

merge uploads #38139

Uh oh!

d-gubert commented Jan 10, 2026 •

edited

Loading

Uh oh!

dionisio-bot bot commented Jan 10, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Jan 10, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 10, 2026

Review skipped

Uh oh!

github-actions bot commented Jan 10, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 10, 2026 •

edited

Loading

Uh oh!

d-gubert commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

merge uploads #38139

merge uploads #38139

Uh oh!

Conversation

d-gubert commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jan 10, 2026

Review skipped

Uh oh!

github-actions bot commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

➡️ Changes

📊 Historical Trend

Uh oh!

codecov bot commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

d-gubert commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

d-gubert commented Jan 10, 2026 •

edited

Loading

dionisio-bot bot commented Jan 10, 2026 •

edited

Loading

changeset-bot bot commented Jan 10, 2026 •

edited

Loading

github-actions bot commented Jan 10, 2026 •

edited

Loading

codecov bot commented Jan 10, 2026 •

edited

Loading