-
Notifications
You must be signed in to change notification settings - Fork 13k
fix(navbar): ensure all primary actions are accessible on small screens #38132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix(navbar): ensure all primary actions are accessible on small screens #38132
Conversation
|
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
WalkthroughThe PR removes mobile-specific rendering logic from NavBarControlsSection, making Voip and Omnichannel component groups render unconditionally on all layouts when their respective conditions are met, rather than only on specific device sizes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/meteor/client/navbar/NavBarControls/NavBarControlsSection.tsx (1)
20-44: Consider refactoring to eliminate code duplication.The mobile and non-mobile branches duplicate the rendering of
NavBarVoipGroup,NavBarOmnichannelGroup, and the workspace/user preferences group. The only difference is the conditionalNavBarControlsWithDataon mobile.♻️ Proposed refactor to reduce duplication
- if (isMobile) { - return ( - <NavBarSection> - {callAction && <NavBarVoipGroup />} - {showOmnichannel && <NavBarOmnichannelGroup />} - {(showOmnichannel || callAction) && <NavBarControlsWithData />} - <NavBarGroup aria-label={t('Workspace_and_user_preferences')}> - <NavBarItemAdministrationMenu /> - {user ? <UserMenu user={user} /> : <NavBarItemLoginPage />} - </NavBarGroup> - </NavBarSection> - ); -} - - - return ( + return ( <NavBarSection> {callAction && <NavBarVoipGroup />} {showOmnichannel && <NavBarOmnichannelGroup />} + {isMobile && (showOmnichannel || callAction) && <NavBarControlsWithData />} <NavBarGroup aria-label={t('Workspace_and_user_preferences')}> <NavBarItemAdministrationMenu /> {user ? <UserMenu user={user} /> : <NavBarItemLoginPage />} </NavBarGroup> </NavBarSection> );
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/meteor/client/navbar/NavBarControls/NavBarControlsSection.tsx
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/client/navbar/NavBarControls/NavBarControlsSection.tsx
🔇 Additional comments (1)
apps/meteor/client/navbar/NavBarControls/NavBarControlsSection.tsx (1)
20-32: AI summary incorrectly describes the change.The AI summary states "Removed mobile-specific early return," but the code still contains an
if (isMobile)block. The actual change adds Voip and Omnichannel groups to the mobile view, not removes the conditional rendering.
What
Why
How
Steps to test
Summary by CodeRabbit
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.