-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Prevent words from breaking mid-character in user card's bio #38036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent words from breaking mid-character in user card's bio #38036
Conversation
- Prevents URLs/links in bio from breaking mid-word - Improves readability while maintaining 3-line clamp - Aligns with other text components (InfoPanelText, AuditModalText)
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: bd8fc06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughUpdated the UserCard component's CSS to change text wrapping from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38036 +/- ##
===========================================
- Coverage 70.70% 70.62% -0.08%
===========================================
Files 3146 3146
Lines 108826 108826
Branches 19557 19565 +8
===========================================
- Hits 76941 76863 -78
- Misses 29880 29952 +72
- Partials 2005 2011 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Changes
word-break: break-alltoword-break: break-wordinUserCard.tsxto prevent URLs and links in user bio from breaking mid-character. This makes links more readable and clickable while still respecting the 3-line clamp limit.Before: Links break mid-character
After: Links wrap naturally
This change aligns
UserCardwith other text components in the codebase (InfoPanelText,AuditModalText,MessageText) which already usebreak-wordfor better readability.Issue(s)
Closes #38035
Steps to test or reproduce
https://github.com/username)Summary by CodeRabbit
Style
Chores
✏️ Tip: You can customize this high-level summary in your review settings.