Skip to content

Conversation

@cubic-dev-ai
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot commented Dec 24, 2025

Summary

  • Fixed test at line 145 that was creating a non-federated room instead of a federated one
  • Added extraData: { federated: true } to ensure the test validates federation behavior correctly
  • Changed credentials to config for consistency with other tests in the file

Test plan

  • Verify the federation permissions test passes with the updated room configuration
  • Confirm the test now correctly validates federation behavior

@changeset-bot
Copy link

changeset-bot bot commented Dec 24, 2025

⚠️ No Changeset found

Latest commit: 3163aae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 24, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 24, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link
Contributor Author

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@ggazzo ggazzo merged commit 581db95 into regression/permissions-federated Dec 24, 2025
11 checks passed
@ggazzo ggazzo deleted the fix/federation-permissions-test-federated-room branch December 24, 2025 18:52
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.62%. Comparing base (73c7d25) to head (3163aae).
⚠️ Report is 1 commits behind head on regression/permissions-federated.

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##           regression/permissions-federated   #37971   +/-   ##
=================================================================
  Coverage                             70.61%   70.62%           
=================================================================
  Files                                  3146     3146           
  Lines                                108681   108681           
  Branches                              19492    19493    +1     
=================================================================
+ Hits                                  76748    76756    +8     
+ Misses                                29937    29928    -9     
- Partials                               1996     1997    +1     
Flag Coverage Δ
unit 71.73% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants