regression: Media call items showing without having `teams-voip` module #37960

gabriellsh · 2025-12-23T21:52:10Z

Proposed changes (including videos or screenshots)

Issue(s)

VGA-130

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Refactor
- Removed VoIP warning modal and the Teams VoIP configuration modal UI; simplified media call provider logic and unified licensing/permission handling.
Tests
- Deleted the Community Edition end-to-end voice call test suite.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

changeset-bot · 2025-12-23T21:52:14Z

⚠️ No Changeset found

Latest commit: 62e0906

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-23T21:52:37Z

Walkthrough

Removes the VoIP warning modal hook and its TeamsVoipConfigModal component, deletes related CE e2e tests, and simplifies MediaCallProvider control flow to a single combined license/permission condition for rendering.

Changes

Cohort / File(s)	Summary
Hook & Modal component removed `apps/meteor/client/hooks/useVoipWarningModal.tsx`, `apps/meteor/client/views/room/contextualBar/TeamsVoipConfigModal.tsx`	Deleted the `useVoipWarningModal` hook and `TeamsVoipConfigModal` component and their exported types/props, removing modal setup, handlers, and UI for the VoIP warning flow.
MediaCallProvider control flow `apps/meteor/client/providers/MediaCallProvider.tsx`	Removed usage of the deleted hook and unified rendering logic into a single combined condition that checks license module and call permissions; simplified branch handling for unauthorized/unlicensed states.
E2E tests removed `apps/meteor/tests/e2e/voice-calls-ce.spec.ts`	Deleted the Community Edition voice-calls e2e test suite that asserted upsell/VoIP modal behavior.

Sequence Diagram(s)

(Skipped — changes are removals/simplifications without a new multi-component sequential flow requiring visualization.)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

test: Display upsell modal for voice calls on community edition. #37230: Modifies the same e2e test and the TeamsVoipConfigModal component file — likely directly related.
chore!: remove old freeswitch integration #37657: Removes or alters VoIP/FreeSWITCH surface and related UI/typings — related to VoIP feature removals.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

ggazzo
tassoevan
MartinSchoeler

Poem

🐰 I nudged a modal off the hill,
VoIP signs folded, soft and still,
Paths now one, no forks to roam,
A tidy patch to call my home. ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing a regression where media call UI items appear without the teams-voip module.
Linked Issues check	✅ Passed	The PR addresses VGA-130 by removing voice-related UI components (TeamsVoipConfigModal, useVoipWarningModal hook, and related e2e tests) and restricting media call items display based on module licensing.
Out of Scope Changes check	✅ Passed	All changes are in scope: removing the upsell modal, associated hook, tests, and updating MediaCallProvider control flow to guard display by module presence.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/hideVoice

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8197542 and 87c556a.

📒 Files selected for processing (1)

apps/meteor/tests/e2e/voice-calls-ce.spec.ts

💤 Files with no reviewable changes (1)

apps/meteor/tests/e2e/voice-calls-ce.spec.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: 📦 Build Packages
GitHub Check: CodeQL-Build
GitHub Check: CodeQL-Build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cubic-dev-ai

No issues found across 3 files

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d7043fd and 8197542.

📒 Files selected for processing (3)

apps/meteor/client/hooks/useVoipWarningModal.tsx
apps/meteor/client/providers/MediaCallProvider.tsx
apps/meteor/client/views/room/contextualBar/TeamsVoipConfigModal.tsx

💤 Files with no reviewable changes (2)

apps/meteor/client/hooks/useVoipWarningModal.tsx
apps/meteor/client/views/room/contextualBar/TeamsVoipConfigModal.tsx

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

apps/meteor/client/providers/MediaCallProvider.tsx

🧠 Learnings (2)

📚 Learning: 2025-12-18T15:18:31.688Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37773
File: apps/meteor/client/views/mediaCallHistory/MediaCallHistoryInternal.tsx:24-34
Timestamp: 2025-12-18T15:18:31.688Z
Learning: In apps/meteor/client/views/mediaCallHistory/MediaCallHistoryInternal.tsx, for internal call history items, the item.contactId is guaranteed to always match either the caller.id or callee.id in the call data, so the contact resolution in getContact will never result in undefined.

Applied to files:

apps/meteor/client/providers/MediaCallProvider.tsx

📚 Learning: 2025-11-19T18:20:37.116Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37419
File: apps/meteor/server/services/media-call/service.ts:141-141
Timestamp: 2025-11-19T18:20:37.116Z
Learning: In apps/meteor/server/services/media-call/service.ts, the sendHistoryMessage method should use call.caller.id or call.createdBy?.id as the message author, not call.transferredBy?.id. Even for transferred calls, the message should appear in the DM between the two users who are calling each other, not sent by the person who transferred the call.

Applied to files:

apps/meteor/client/providers/MediaCallProvider.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: 📦 Build Packages
GitHub Check: CodeQL-Build
GitHub Check: CodeQL-Build

🔇 Additional comments (1)

apps/meteor/client/providers/MediaCallProvider.tsx (1)

8-29: LGTM! Clean simplification of the control flow.

The refactor unifies the previously separate unlicensed and unauthorized paths into a single conditional check. The logic correctly hides voice features when either the module is not licensed or the user lacks both internal and external call permissions.

apps/meteor/client/providers/MediaCallProvider.tsx

codecov · 2025-12-23T22:05:53Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.62%. Comparing base (0bb2a33) to head (62e0906).
⚠️ Report is 1 commits behind head on release-8.0.0.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-8.0.0   #37960      +/-   ##
=================================================
+ Coverage          70.60%   70.62%   +0.01%     
=================================================
  Files               3146     3144       -2     
  Lines             108690   108658      -32     
  Branches           19523    19510      -13     
=================================================
- Hits               76738    76735       -3     
+ Misses             29947    29933      -14     
+ Partials            2005     1990      -15

Flag	Coverage Δ
unit	`71.74% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-12-23T22:11:54Z

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change
sum of all images	1.1GiB	1.1GiB	+11MiB
rocketchat	355MiB	345MiB	+11MiB
omnichannel-transcript-service	132MiB	132MiB	-90B
queue-worker-service	132MiB	132MiB	-832B
ddp-streamer-service	126MiB	126MiB	+492B
account-service	113MiB	113MiB	+64B
authorization-service	111MiB	111MiB	-242B
presence-service	111MiB	111MiB	+1.2KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/26 16:42 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]

Statistics (last 30 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.2GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 1.1GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-37960
Baseline: develop
Timestamp: 2025-12-26 16:42:22 UTC
Historical data points: 30

Updated: Fri, 26 Dec 2025 16:42:22 GMT

dionisio-bot · 2025-12-24T14:19:23Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Remove voice call buttons if no module

8197542

gabriellsh added this to the 8.0.0 milestone Dec 23, 2025

gabriellsh requested a review from a team as a code owner December 23, 2025 21:52

cubic-dev-ai bot reviewed Dec 23, 2025

View reviewed changes

coderabbitai bot reviewed Dec 23, 2025

View reviewed changes

apps/meteor/client/providers/MediaCallProvider.tsx Show resolved Hide resolved

tassoevan previously approved these changes Dec 24, 2025

View reviewed changes

remove upsell modal tests

87c556a

gabriellsh dismissed tassoevan’s stale review via 87c556a December 24, 2025 14:19

Merge branch 'release-8.0.0' into chore/hideVoice

b4a76cd

tassoevan approved these changes Dec 26, 2025

View reviewed changes

gabriellsh added 2 commits December 26, 2025 13:20

Merge branch 'release-8.0.0' into chore/hideVoice

ac68706

Merge branch 'release-8.0.0' into chore/hideVoice

62e0906

gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Dec 26, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 26, 2025

kodiakhq bot merged commit 13021c3 into release-8.0.0 Dec 26, 2025
26 checks passed

kodiakhq bot deleted the chore/hideVoice branch December 26, 2025 19:11

coderabbitai bot mentioned this pull request Dec 29, 2025

regression: "Voice call" action enabled when a call is in progress #37967

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

regression: Media call items showing without having `teams-voip` module #37960

regression: Media call items showing without having `teams-voip` module #37960

Uh oh!

gabriellsh commented Dec 23, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Dec 23, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 23, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

codecov bot commented Dec 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 23, 2025 •

edited

Loading

Uh oh!

dionisio-bot bot commented Dec 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

regression: Media call items showing without having teams-voip module #37960

regression: Media call items showing without having teams-voip module #37960

Uh oh!

Conversation

gabriellsh commented Dec 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

📈 Changes

📊 Historical Trend

Uh oh!

dionisio-bot bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

regression: Media call items showing without having `teams-voip` module #37960

regression: Media call items showing without having `teams-voip` module #37960

gabriellsh commented Dec 23, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Dec 23, 2025 •

edited

Loading

coderabbitai bot commented Dec 23, 2025 •

edited

Loading

codecov bot commented Dec 23, 2025 •

edited

Loading

github-actions bot commented Dec 23, 2025 •

edited

Loading

dionisio-bot bot commented Dec 24, 2025 •

edited

Loading