regression: Call History button not working on smaller screens (mobile layout) by gabriellsh · Pull Request #37946 · RocketChat/Rocket.Chat

gabriellsh · 2025-12-23T15:05:24Z

Proposed changes (including videos or screenshots)

Issue(s)

VGA-128

Steps to test or reproduce

Further comments

Summary by CodeRabbit

New Features
- Call History menu item now navigates to the call history screen when clicked.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

changeset-bot · 2025-12-23T15:05:29Z

⚠️ No Changeset found

Latest commit: 53631d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-23T15:05:50Z

Walkthrough

The PR adds router-backed navigation to the Call History menu item in the navbar controls component. When clicked, the menu item now navigates to the /call-history route using a memoized callback function.

Changes

Cohort / File(s)	Summary
Call History Navigation `apps/meteor/client/navbar/NavBarControls/NavBarControlsWithData.tsx`	Added `useRouter` and `useCallback` imports; created memoized `openCallHistory` callback that navigates to `/call-history`; attached onClick handler to Call History menu item

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

fix: Missing call button with "Enhanced Navigation" enabled on small screens #37449: Modifies the same NavBarControls component to add call-action plumbing, which may need coordination with this router-backed navigation addition.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

tassoevan
ggazzo
pierre-lehnen-rc

Poem

🐰 A call history button springs to life,
With router hooks that end the strife,
A simple click, no more delay—
Navigation finds its way! 📞

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately describes the main change: fixing the Call History button functionality on mobile/smaller screens by adding router integration and onClick handler.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/callHistoryMobile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cubic-dev-ai

No issues found across 1 file

codecov · 2025-12-23T15:19:34Z

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.66%. Comparing base (aeaefd4) to head (53631d7).
⚠️ Report is 1 commits behind head on release-8.0.0.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-8.0.0   #37946      +/-   ##
=================================================
+ Coverage          70.60%   70.66%   +0.05%     
=================================================
  Files               3146     3143       -3     
  Lines             108682   108678       -4     
  Branches           19502    19526      +24     
=================================================
+ Hits               76733    76794      +61     
+ Misses             29954    29883      -71     
- Partials            1995     2001       +6

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-12-23T15:24:09Z

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change
sum of all images	1.1GiB	1.1GiB	+11MiB
rocketchat	355MiB	345MiB	+11MiB
omnichannel-transcript-service	132MiB	132MiB	-2.1KiB
queue-worker-service	132MiB	132MiB	-745B
ddp-streamer-service	126MiB	126MiB	-1.8KiB
account-service	113MiB	113MiB	-272B
authorization-service	111MiB	111MiB	-222B
presence-service	111MiB	111MiB	+34B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 13:48 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]

Statistics (last 28 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.2GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 1.1GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-37946
Baseline: develop
Timestamp: 2025-12-24 13:48:54 UTC
Historical data points: 28

Updated: Wed, 24 Dec 2025 13:48:54 GMT

ggazzo · 2025-12-24T13:25:52Z

/bark

ggazzo · 2025-12-24T13:56:59Z

/bark

dionisio-bot · 2025-12-24T13:57:03Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Fix call history action not working on smaller screens

8b857a0

gabriellsh requested a review from a team as a code owner December 23, 2025 15:05

gabriellsh added this to the 8.0.0 milestone Dec 23, 2025

gabriellsh changed the base branch from develop to release-8.0.0 December 23, 2025 15:05

cubic-dev-ai bot reviewed Dec 23, 2025

View reviewed changes

MartinSchoeler approved these changes Dec 23, 2025

View reviewed changes

Harmeet221 added the stat: QA assured Means it has been tested and approved by a company insider label Dec 24, 2025

scuciatto added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Dec 24, 2025

gabriellsh changed the title ~~regression: Call history button not working on smaller screens (mobile layout)~~ regression: Call History button not working on smaller screens (mobile layout) Dec 24, 2025

Merge branch 'release-8.0.0' into fix/callHistoryMobile

53631d7

ggazzo added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Dec 24, 2025

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 24, 2025

kodiakhq bot merged commit d2b0e30 into release-8.0.0 Dec 24, 2025
38 of 42 checks passed

kodiakhq bot deleted the fix/callHistoryMobile branch December 24, 2025 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

regression: Call History button not working on smaller screens (mobile layout)#37946

regression: Call History button not working on smaller screens (mobile layout)#37946
kodiakhq[bot] merged 2 commits intorelease-8.0.0from
fix/callHistoryMobile

gabriellsh commented Dec 23, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Dec 23, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 23, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

codecov bot commented Dec 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 23, 2025 •

edited

Loading

Uh oh!

ggazzo commented Dec 24, 2025

Uh oh!

ggazzo commented Dec 24, 2025

Uh oh!

dionisio-bot bot commented Dec 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

gabriellsh commented Dec 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

📈 Changes

📊 Historical Trend

Uh oh!

ggazzo commented Dec 24, 2025

Uh oh!

ggazzo commented Dec 24, 2025

Uh oh!

dionisio-bot bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gabriellsh commented Dec 23, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Dec 23, 2025 •

edited

Loading

coderabbitai bot commented Dec 23, 2025 •

edited

Loading

codecov bot commented Dec 23, 2025 •

edited

Loading

github-actions bot commented Dec 23, 2025 •

edited

Loading

dionisio-bot bot commented Dec 24, 2025 •

edited

Loading