Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Dec 11, 2025

Proposed changes (including videos or screenshots)

Issue(s)

FB-150

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Release Notes

  • Tests

    • Added comprehensive end-to-end test suite for federated direct messages to validate functionality between Rocket.Chat and Matrix servers.
    • Enhanced testing utilities to support direct message room creation scenarios.
  • Chores

    • Improved test configuration flexibility for quality assurance reporting via environment variable configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 11, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2025

⚠️ No Changeset found

Latest commit: d2514f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds end-to-end tests for federated direct messages between Rocket.Chat EE and Synapse, introduces a createDM helper method to SynapseClient, and makes QASE reporter project configurable via environment variable with fallback.

Changes

Cohort / File(s) Change Summary
Configuration
ee/packages/federation-matrix/jest.config.federation.ts
QASE reporter project field changed from static 'RC' to environment-driven `process.env.QASE_PROJECT
Test Helpers
ee/packages/federation-matrix/tests/helper/synapse-client.ts
Added new public method createDM(userIds: string[]): Promise<Room> to SynapseClient for initializing direct message rooms via Synapse Matrix client.
E2E Test Suite
ee/packages/federation-matrix/tests/end-to-end/dms.spec.ts
Added comprehensive end-to-end test suite for federated direct messages, covering DM creation, user invitations, membership events, room subscriptions, and permission validations across Rocket.Chat and Synapse instances.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

  • dms.spec.ts requires careful review of test flows and federated DM scenarios across multiple test cases; understanding Matrix room state transitions and subscription synchronization is essential.
  • synapse-client.ts method addition should be validated against existing client initialization patterns and Matrix room creation semantics.
  • jest.config.federation.ts is a trivial configuration change but should be verified for environment variable fallback behavior.

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • rodrigok
  • ricardogarim

Poem

🐰 A leap through federated chats we go,
DMs flowing swift from RC to Synapse's glow,
With helper methods and tests so bright,
We ensure the messages land just right! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch federation-dm-tests

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between acf14d6 and d2514f4.

📒 Files selected for processing (3)
  • ee/packages/federation-matrix/jest.config.federation.ts (1 hunks)
  • ee/packages/federation-matrix/tests/end-to-end/dms.spec.ts (1 hunks)
  • ee/packages/federation-matrix/tests/helper/synapse-client.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 358MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB +331B
queue-worker-service 132MiB 132MiB -319B
ddp-streamer-service 126MiB 126MiB -659B
account-service 113MiB 113MiB -570B
stream-hub-service 110MiB 110MiB -630B
presence-service 110MiB 110MiB -123B
authorization-service 110MiB 110MiB -179B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 16:51", "12/15 18:09 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 21 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37777
  • Baseline: develop
  • Timestamp: 2025-12-15 18:09:55 UTC
  • Historical data points: 21

Updated: Mon, 15 Dec 2025 18:09:56 GMT

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.72%. Comparing base (a00c000) to head (dca3186).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #37777   +/-   ##
========================================
  Coverage    67.71%   67.72%           
========================================
  Files         3458     3458           
  Lines       113953   113953           
  Branches     20926    20926           
========================================
+ Hits         77168    77173    +5     
+ Misses       34653    34648    -5     
  Partials      2132     2132           
Flag Coverage Δ
e2e 57.36% <ø> (+0.04%) ⬆️
e2e-api 42.28% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from federation-tests-improve-scripts to develop December 11, 2025 19:44
@ggazzo ggazzo force-pushed the federation-dm-tests branch 2 times, most recently from 96309d9 to dca3186 Compare December 15, 2025 15:22
@ggazzo ggazzo force-pushed the federation-dm-tests branch from 109ccef to d2514f4 Compare December 15, 2025 22:14
@ggazzo ggazzo added this to the 7.14.0 milestone Dec 15, 2025
@ggazzo ggazzo marked this pull request as ready for review December 15, 2025 22:16
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Dec 15, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 15, 2025
@ggazzo ggazzo merged commit c406a51 into develop Dec 15, 2025
14 of 16 checks passed
@ggazzo ggazzo deleted the federation-dm-tests branch December 15, 2025 22:17
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
@dougfabris dougfabris modified the milestones: 7.14.0, 8.0.0 Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants