Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Dec 10, 2025

Proposed changes (including videos or screenshots)

Issue(s)

VGA-76

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • New Features
    • Added an info button to voice call entries in chat history. Clicking the button opens a detailed contextual panel displaying comprehensive voice call information.

✏️ Tip: You can customize this high-level summary in your review settings.

@gabriellsh gabriellsh added this to the 7.14.0 milestone Dec 10, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 10, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2025

🦋 Changeset detected

Latest commit: 0f953d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 42 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/ui-voip Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/abac Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Walkthrough

The PR extends the voice call history payload system to include an interactive info button. The implementation adds a call ID parameter to getHistoryMessagePayload, introduces a new getHistoryAction function that returns an icon button element, and updates icon types to support framing. These changes enable in-chat voice call history entries to display a clickable info button.

Changes

Cohort / File(s) Summary
Changeset documentation
.changeset/strong-maps-act.md
Documents version bumps for @rocket.chat/meteor and @rocket.chat/ui-voip (both minor) with description of new UI enhancements.
Service layer
apps/meteor/server/services/media-call/service.ts
Updated call history payload creation to pass the call ID as a third argument to getHistoryMessagePayload().
Core implementation
packages/ui-voip/src/ui-kit/getHistoryMessagePayload.ts
Added new getHistoryAction() function; extended getHistoryMessagePayload() signature to accept optional callId parameter; updated callStateToIcon() return type to FrameableIconElement with framed: true; attaches action objects to info_card blocks when callId is provided.
Test suite
packages/ui-voip/src/ui-kit/getHistoryMessagePayload.spec.ts
Updated test cases to pass callId through function calls and validate action object presence; added tests for new getHistoryAction() function; updated icon payload expectations to include framed: true.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Public API signature changes: getHistoryMessagePayload() now accepts an optional third parameter; validate all callers pass the parameter correctly
  • New exported function: getHistoryAction() — verify return type and behavior align with UI kit expectations
  • Type system updates: Icon type changes from IconElement to FrameableIconElement — ensure no breaking changes downstream
  • Conditional payload logic: Review the conditional inclusion of action objects based on callId presence

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • tassoevan
  • pierre-lehnen-rc
  • KevLehman

Poem

🐰 A button emerges with framed design bright,
Call history glows with actionable light!
Click info to see details so fine,
Voice calls now shine with each line—
Context bars open with payload divine! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The changes successfully implement VGA-76 by adding an info button to message blocks for voice call history, with proper UI enhancements and test coverage.
Out of Scope Changes check ✅ Passed All changes are directly related to implementing the Call Info button feature for voice call history messages, with no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The pull request title accurately and specifically describes the main feature being added: a 'Call Info' button to voice calls history messages.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/voiceMessageHistoryLink

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 358MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB -658B
queue-worker-service 132MiB 132MiB +280B
ddp-streamer-service 126MiB 126MiB +94B
account-service 113MiB 113MiB -637B
authorization-service 111MiB 111MiB +820B
stream-hub-service 111MiB 111MiB +322B
presence-service 111MiB 111MiB +134B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 19:04", "12/19 19:43 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 25 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37771
  • Baseline: develop
  • Timestamp: 2025-12-19 19:43:11 UTC
  • Historical data points: 25

Updated: Fri, 19 Dec 2025 19:43:11 GMT

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.70%. Comparing base (0ccb969) to head (0f953d4).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37771      +/-   ##
===========================================
- Coverage    67.70%   67.70%   -0.01%     
===========================================
  Files         3475     3475              
  Lines       113861   113861              
  Branches     20942    20942              
===========================================
- Hits         77093    77085       -8     
- Misses       34586    34596      +10     
+ Partials      2182     2180       -2     
Flag Coverage Δ
e2e 57.16% <ø> (-0.03%) ⬇️
e2e-api 44.06% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabriellsh gabriellsh marked this pull request as ready for review December 19, 2025 14:06
@gabriellsh gabriellsh requested a review from a team as a code owner December 19, 2025 14:06
@tassoevan tassoevan changed the title feat: Add Call Info button to voice calls history message feat(ui-voip): Add Call Info button to voice calls history message Dec 19, 2025
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Dec 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 19, 2025
@ggazzo ggazzo merged commit 0b660a5 into develop Dec 19, 2025
50 checks passed
@ggazzo ggazzo deleted the feat/voiceMessageHistoryLink branch December 19, 2025 20:32
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
…ocketChat#37771)

Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
@dougfabris dougfabris modified the milestones: 7.14.0, 8.0.0 Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants