test: inject initial data after each test in E2EE Key Reset #37759

ggazzo · 2025-12-10T12:22:21Z

…e redundant call in E2EE Legacy Format

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Tests
- Enhanced end-to-end test reliability with improved test setup and cleanup procedures for encryption-related test scenarios.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…e redundant call in E2EE Legacy Format

dionisio-bot · 2025-12-10T12:22:24Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2025-12-10T12:22:25Z

⚠️ No Changeset found

Latest commit: 7e76d1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-10T12:22:27Z

Walkthrough

Two end-to-end encryption test files are modified: one adds initial data reset after each test, the other removes pre-test setup invocations to simplify test initialization.

Changes

Cohort / File(s)	Summary
E2EE Test Setup Changes `apps/meteor/tests/e2e/e2e-encryption/e2ee-key-reset.spec.ts`	Added `injectInitialData` import and invoked it in `test.afterEach` to reset initial data after each test execution.
E2EE Test Setup Simplification `apps/meteor/tests/e2e/e2e-encryption/e2ee-legacy-format.spec.ts`	Removed `injectInitialData` and `restoreState` imports and their pre-test invocations; test now directly creates encrypted channel without prior setup.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Straightforward test setup/teardown modifications across two files
Only import and function call additions/removals; no logic changes
Consistent patterns applied uniformly

Possibly related PRs

test: modularize e2e encryption tests and extract common utilities #36890: Adjusts test setup/teardown behavior in the same E2EE test files with related injectInitialData usage changes.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

cardoso
dougfabris

Poem

🐰 A test setup dance, so neat and clean,
One resets after, the cleanest seen,
The other steps forward without delay,
Encryption tests leap in a better way! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding injectInitialData() in test.afterEach for the E2EE Key Reset test file, which is the primary modification shown in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch test/ifx-flaky

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 265f3e2 and 7e76d1e.

📒 Files selected for processing (2)

apps/meteor/tests/e2e/e2e-encryption/e2ee-key-reset.spec.ts (2 hunks)
apps/meteor/tests/e2e/e2e-encryption/e2ee-legacy-format.spec.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

apps/meteor/tests/e2e/e2e-encryption/e2ee-key-reset.spec.ts
apps/meteor/tests/e2e/e2e-encryption/e2ee-legacy-format.spec.ts

**/*.spec.ts

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.spec.ts: Use descriptive test names that clearly communicate expected behavior in Playwright tests
Use .spec.ts extension for test files (e.g., login.spec.ts)

Files:

apps/meteor/tests/e2e/e2e-encryption/e2ee-key-reset.spec.ts
apps/meteor/tests/e2e/e2e-encryption/e2ee-legacy-format.spec.ts

apps/meteor/tests/e2e/**/*.spec.ts

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

apps/meteor/tests/e2e/**/*.spec.ts: All test files must be created in apps/meteor/tests/e2e/ directory
Avoid using page.locator() in Playwright tests - always prefer semantic locators such as page.getByRole(), page.getByLabel(), page.getByText(), or page.getByTitle()
Use test.beforeAll() and test.afterAll() for setup/teardown in Playwright tests
Use test.step() for complex test scenarios to improve organization in Playwright tests
Group related tests in the same file
Utilize Playwright fixtures (test, page, expect) for consistency in test files
Prefer web-first assertions (toBeVisible, toHaveText, etc.) in Playwright tests
Use expect matchers for assertions (toEqual, toContain, toBeTruthy, toHaveLength, etc.) instead of assert statements in Playwright tests
Use page.waitFor() with specific conditions instead of hardcoded timeouts in Playwright tests
Implement proper wait strategies for dynamic content in Playwright tests
Maintain test isolation between test cases in Playwright tests
Ensure clean state for each test execution in Playwright tests
Ensure tests run reliably in parallel without shared state conflicts

Files:

apps/meteor/tests/e2e/e2e-encryption/e2ee-key-reset.spec.ts
apps/meteor/tests/e2e/e2e-encryption/e2ee-legacy-format.spec.ts

apps/meteor/tests/e2e/**/*.{ts,spec.ts}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

apps/meteor/tests/e2e/**/*.{ts,spec.ts}: Store commonly used locators in variables/constants for reuse
Follow Page Object Model pattern consistently in Playwright tests

Files:

apps/meteor/tests/e2e/e2e-encryption/e2ee-key-reset.spec.ts
apps/meteor/tests/e2e/e2e-encryption/e2ee-legacy-format.spec.ts

🧠 Learnings (14)