Skip to content

Conversation

@lucas-a-pelegrino
Copy link
Contributor

@lucas-a-pelegrino lucas-a-pelegrino commented Dec 1, 2025

Proposed changes (including videos or screenshots)

This PR removes the deprecated meteor method; livechat:saveTag

Issue(s)

CORE-1411

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Removed the deprecated livechat:saveTag Meteor method from Livechat Enterprise. Users relying on this method should migrate to the current API.

✏️ Tip: You can customize this high-level summary in your review settings.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 1, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2025

🦋 Changeset detected

Latest commit: a7e6181

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 1, 2025

Walkthrough

This PR removes the deprecated Meteor method livechat:saveTag by deleting its implementation file, removing its import from the server index, and documenting the removal in a changeset. The method included permission checks, input validation, and delegation to an internal handler.

Changes

Cohort / File(s) Summary
Changeset Documentation
.changeset/breezy-timers-flow.md
New changeset documenting the patch version bump for @rocket.chat/meteor and removal of the deprecated livechat:saveTag Meteor method.
Livechat Enterprise Server Index
apps/meteor/ee/app/livechat-enterprise/server/index.ts
Removed the import of the ./methods/saveTag module from the server initialization.
Livechat Enterprise Method Implementation
apps/meteor/ee/app/livechat-enterprise/server/methods/saveTag.ts
Removed the entire file containing the deprecated livechat:saveTag method registration, including its public type augmentation for ServerMethods, deprecation logging, permission validation, input checks, and delegation to LivechatEnterprise.saveTag().

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify no remaining references to livechat:saveTag exist elsewhere in the codebase
  • Confirm the changeset documentation accurately reflects the deprecation removal and version bump

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • dougfabris
  • KevLehman
  • aleksandernsilva

Poem

🐰 A tag so old, deprecated with care,
Now bids farewell without a prayer,
The method sleeps, its work is done,
The REST path rises—bright and fun! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The linked issue CORE-1411 provides minimal detail beyond its title. The PR removes the deprecated livechat:saveTag method as indicated, but the issue's full objectives cannot be fully verified due to lack of detailed requirements. Verify that CORE-1411 explicitly required removal of this method and that no additional related tasks remain incomplete.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing the deprecated livechat:saveTag method, which aligns with all modifications shown in the changeset.
Out of Scope Changes check ✅ Passed All changes are directly related to removing the livechat:saveTag method: the changeset entry, import removal, and method implementation deletion align with the stated objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/v8/CORE-1411

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 70ac0c9 and 665828a.

📒 Files selected for processing (3)
  • .changeset/breezy-timers-flow.md (1 hunks)
  • apps/meteor/ee/app/livechat-enterprise/server/index.ts (0 hunks)
  • apps/meteor/ee/app/livechat-enterprise/server/methods/saveTag.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • apps/meteor/ee/app/livechat-enterprise/server/methods/saveTag.ts
  • apps/meteor/ee/app/livechat-enterprise/server/index.ts
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: MartinSchoeler
Repo: RocketChat/Rocket.Chat PR: 37408
File: apps/meteor/client/views/admin/ABAC/useRoomAttributeOptions.tsx:53-69
Timestamp: 2025-11-10T19:06:20.146Z
Learning: In the Rocket.Chat repository, do not provide suggestions or recommendations about code sections marked with TODO comments. The maintainers have already identified these as future work and external reviewers lack the full context about implementation plans and timing.
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🔇 Additional comments (2)
.changeset/breezy-timers-flow.md (2)

5-5: Changeset description is clear and appropriate.

The removal of the deprecated method is well-documented in the changeset.


1-3: Version bump should be "major" for breaking API changes.

Removing a deprecated method is a breaking change and should be marked as major, not patch. Since the PR targets release-8.0.0, breaking changes are expected and appropriate at this major version boundary.

Apply this diff to correct the version bump:

  ---
- "@rocket.chat/meteor": patch
+ "@rocket.chat/meteor": major
  ---
⛔ Skipped due to learnings
Learnt from: MartinSchoeler
Repo: RocketChat/Rocket.Chat PR: 37408
File: apps/meteor/client/views/admin/ABAC/useRoomAttributeOptions.tsx:53-69
Timestamp: 2025-11-10T19:06:20.146Z
Learning: In the Rocket.Chat repository, do not provide suggestions or recommendations about code sections marked with TODO comments. The maintainers have already identified these as future work and external reviewers lack the full context about implementation plans and timing.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.1GiB 1.1GiB +8.2MiB
rocketchat 357MiB 349MiB +8.5MiB
omnichannel-transcript-service 132MiB 132MiB -89KiB
queue-worker-service 132MiB 132MiB -91KiB
ddp-streamer-service 126MiB 126MiB -38KiB
account-service 113MiB 113MiB -36KiB
presence-service 111MiB 111MiB -38KiB
authorization-service 111MiB 111MiB -38KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 13:41", "12/10 14:07 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
Loading

Statistics (last 17 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.1GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37663
  • Baseline: develop
  • Timestamp: 2025-12-10 14:07:10 UTC
  • Historical data points: 17

Updated: Wed, 10 Dec 2025 14:07:10 GMT

@ggazzo ggazzo force-pushed the release-8.0.0 branch 6 times, most recently from 590f91c to 538b89b Compare December 9, 2025 13:32
@ggazzo ggazzo added this to the 8.0.0 milestone Dec 10, 2025
@ggazzo ggazzo force-pushed the chore/v8/CORE-1411 branch from 1b7157a to 665828a Compare December 10, 2025 13:48
@ggazzo ggazzo marked this pull request as ready for review December 10, 2025 13:49
@ggazzo ggazzo requested a review from a team as a code owner December 10, 2025 13:49
@ggazzo ggazzo merged commit d17167d into release-8.0.0 Dec 10, 2025
5 of 6 checks passed
@ggazzo ggazzo deleted the chore/v8/CORE-1411 branch December 10, 2025 14:31
ggazzo added a commit that referenced this pull request Dec 15, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 17, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 17, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 17, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 18, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 18, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 18, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 18, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 19, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 19, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 19, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
ggazzo added a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
dougfabris pushed a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants