chore: Move RoomToolboxContext to ui-contexts
#37617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe PR consolidates Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/meteor/client/views/room/MemberListRouter.tsx (1)
2-2: MemberListRouter: toolbox/user context import migration is consistentImporting both
useUserIdanduseRoomToolboxfrom@rocket.chat/ui-contextsmatches the centralized contexts approach and keeps the existing behavior of routing betweenRoomMembersandUserInfounchanged.One minor optional clean‑up you might consider (not required for this PR): call
useRoomToolbox()once and destructure{ tab, context: username, closeTab }from a single hook invocation to avoid redundant hook calls.Please verify the member list/user info contextual bar still opens and closes correctly (especially the back/close flows) after this import/source change.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (90)
apps/meteor/client/apps/gameCenter/GameCenter.tsx(1 hunks)apps/meteor/client/components/Contextualbar/ContextualbarDialog.tsx(1 hunks)apps/meteor/client/hooks/roomActions/useAppsRoomStarActions.tsx(1 hunks)apps/meteor/client/hooks/roomActions/useAutotranslateRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useCallsRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useChannelSettingsRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useCleanHistoryRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useDiscussionsRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useE2EERoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useExportMessagesRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useGameCenterRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useKeyboardShortcutListRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useMediaCallRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useMembersListRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useMentionsRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useOTRRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useOutlookCalenderRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/usePinnedMessagesRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/usePushNotificationsRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useRocketSearchRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useStarredMessagesRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useTeamChannelsRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useTeamInfoRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useThreadRoomAction.tsx(1 hunks)apps/meteor/client/hooks/roomActions/useUploadedFilesListRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useUserInfoGroupRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useUserInfoRoomAction.ts(1 hunks)apps/meteor/client/hooks/roomActions/useVideoCallRoomAction.tsx(1 hunks)apps/meteor/client/hooks/roomActions/useWebRTCVideoRoomAction.ts(1 hunks)apps/meteor/client/ui.ts(1 hunks)apps/meteor/client/views/omnichannel/cannedResponses/contextualBar/CannedResponse/CannedResponseList.spec.tsx(1 hunks)apps/meteor/client/views/omnichannel/cannedResponses/contextualBar/CannedResponse/CannedResponseList.tsx(1 hunks)apps/meteor/client/views/omnichannel/cannedResponses/contextualBar/CannedResponse/WrapCannedResponseList.tsx(1 hunks)apps/meteor/client/views/omnichannel/contactInfo/ContactInfoRouter.tsx(1 hunks)apps/meteor/client/views/omnichannel/directory/calls/contextualBar/CallsContextualBarRoom.tsx(1 hunks)apps/meteor/client/views/omnichannel/directory/chats/ChatInfo/ChatsContextualBar.tsx(1 hunks)apps/meteor/client/views/omnichannel/hooks/useCannedResponsesRoomAction.ts(1 hunks)apps/meteor/client/views/omnichannel/hooks/useContactProfileRoomAction.ts(1 hunks)apps/meteor/client/views/omnichannel/hooks/useOmnichannelExternalFrameRoomAction.ts(1 hunks)apps/meteor/client/views/omnichannel/hooks/useRoomInfoRoomAction.ts(1 hunks)apps/meteor/client/views/omnichannel/hooks/useVoIPRoomInfoRoomAction.ts(1 hunks)apps/meteor/client/views/outlookCalendar/OutlookEventsRoute.tsx(1 hunks)apps/meteor/client/views/room/Header/RoomTitle.tsx(1 hunks)apps/meteor/client/views/room/Header/RoomToolbox/RoomToolbox.tsx(1 hunks)apps/meteor/client/views/room/Header/RoomToolbox/RoomToolboxE2EESetup.tsx(1 hunks)apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.ts(1 hunks)apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.ts(1 hunks)apps/meteor/client/views/room/HeaderV2/RoomTitle.tsx(1 hunks)apps/meteor/client/views/room/HeaderV2/RoomToolbox/RoomToolbox.tsx(1 hunks)apps/meteor/client/views/room/HeaderV2/RoomToolbox/RoomToolboxE2EESetup.tsx(1 hunks)apps/meteor/client/views/room/HeaderV2/RoomToolbox/hooks/useRoomToolboxActions.spec.ts(1 hunks)apps/meteor/client/views/room/HeaderV2/RoomToolbox/hooks/useRoomToolboxActions.ts(1 hunks)apps/meteor/client/views/room/MemberListRouter.tsx(1 hunks)apps/meteor/client/views/room/Room.tsx(1 hunks)apps/meteor/client/views/room/body/RoomBody.tsx(1 hunks)apps/meteor/client/views/room/body/RoomBodyV2.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/AutoTranslate/AutoTranslateWithData.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/Discussions/DiscussionsListContextBar.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/ExportMessages/ExportMessages.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfoWithData.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/Info/RoomInfoRouter.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/KeyboardShortcuts/KeyboardShortcutsWithData.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/MessageListTab.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/MessageSearchTab/MessageSearchTab.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/NotificationPreferences/NotificationPreferencesWithData.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/OTR/OTRWithData.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/RoomFiles/RoomFilesWithData.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/RoomMembers/AddUsers/AddUsers.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/RoomMembers/InviteUsers/InviteUsersWithData.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/RoomMembers/RoomMembersWithData.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/Threads/ThreadList.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/Threads/Threads.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/Threads/components/ThreadChat.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/VideoConference/VideoConfList/VideoConfListWithData.tsx(1 hunks)apps/meteor/client/views/room/contextualBar/uikit/UiKitContextualBar.tsx(1 hunks)apps/meteor/client/views/room/hooks/useAppsContextualBar.spec.ts(1 hunks)apps/meteor/client/views/room/hooks/useAppsContextualBar.ts(1 hunks)apps/meteor/client/views/room/lib/getRoomGroup.ts(1 hunks)apps/meteor/client/views/room/providers/RoomToolboxProvider.tsx(1 hunks)apps/meteor/client/views/room/providers/UserCardProvider.tsx(1 hunks)apps/meteor/client/views/room/providers/hooks/useAppsRoomActions.ts(1 hunks)apps/meteor/client/views/room/providers/hooks/useCoreRoomActions.ts(1 hunks)apps/meteor/client/views/teams/contextualBar/channels/TeamsChannelsWithData.tsx(1 hunks)apps/meteor/client/views/teams/contextualBar/info/TeamsInfoWithData.tsx(1 hunks)packages/ui-contexts/package.json(1 hunks)packages/ui-contexts/src/RoomToolboxContext.ts(1 hunks)packages/ui-contexts/src/hooks/useRoomToolbox.ts(1 hunks)packages/ui-contexts/src/index.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/client/views/room/contextualBar/RoomFiles/RoomFilesWithData.tsxapps/meteor/client/hooks/roomActions/useRocketSearchRoomAction.tsapps/meteor/client/hooks/roomActions/useCallsRoomAction.tsapps/meteor/client/hooks/roomActions/useCleanHistoryRoomAction.tsapps/meteor/client/apps/gameCenter/GameCenter.tsxapps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.tsapps/meteor/client/views/outlookCalendar/OutlookEventsRoute.tsxapps/meteor/client/views/room/providers/hooks/useCoreRoomActions.tsapps/meteor/client/hooks/roomActions/useAppsRoomStarActions.tsxpackages/ui-contexts/src/hooks/useRoomToolbox.tsapps/meteor/client/views/room/contextualBar/Discussions/DiscussionsListContextBar.tsxapps/meteor/client/views/omnichannel/hooks/useCannedResponsesRoomAction.tsapps/meteor/client/hooks/roomActions/useE2EERoomAction.tsapps/meteor/client/hooks/roomActions/useUserInfoRoomAction.tsapps/meteor/client/views/room/Header/RoomToolbox/RoomToolbox.tsxapps/meteor/client/hooks/roomActions/useTeamChannelsRoomAction.tsapps/meteor/client/views/room/contextualBar/Info/RoomInfoRouter.tsxapps/meteor/client/views/omnichannel/cannedResponses/contextualBar/CannedResponse/CannedResponseList.tsxapps/meteor/client/views/room/contextualBar/AutoTranslate/AutoTranslateWithData.tsxapps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsxpackages/ui-contexts/src/index.tsapps/meteor/client/views/room/Header/RoomToolbox/RoomToolboxE2EESetup.tsxapps/meteor/client/views/omnichannel/hooks/useOmnichannelExternalFrameRoomAction.tsapps/meteor/client/hooks/roomActions/useStarredMessagesRoomAction.tsapps/meteor/client/hooks/roomActions/usePinnedMessagesRoomAction.tsapps/meteor/client/views/room/contextualBar/OTR/OTRWithData.tsxapps/meteor/client/views/teams/contextualBar/channels/TeamsChannelsWithData.tsxapps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.tsapps/meteor/client/views/room/body/RoomBodyV2.tsxapps/meteor/client/views/room/lib/getRoomGroup.tsapps/meteor/client/views/omnichannel/cannedResponses/contextualBar/CannedResponse/CannedResponseList.spec.tsxapps/meteor/client/views/room/body/RoomBody.tsxapps/meteor/client/hooks/roomActions/useMentionsRoomAction.tsapps/meteor/client/views/room/contextualBar/RoomMembers/RoomMembersWithData.tsxapps/meteor/client/views/room/HeaderV2/RoomToolbox/RoomToolboxE2EESetup.tsxapps/meteor/client/views/omnichannel/hooks/useContactProfileRoomAction.tsapps/meteor/client/views/room/HeaderV2/RoomToolbox/hooks/useRoomToolboxActions.tsapps/meteor/client/views/omnichannel/directory/chats/ChatInfo/ChatsContextualBar.tsxapps/meteor/client/hooks/roomActions/useMembersListRoomAction.tsapps/meteor/client/views/room/Header/RoomTitle.tsxapps/meteor/client/views/omnichannel/contactInfo/ContactInfoRouter.tsxapps/meteor/client/views/room/contextualBar/Threads/Thread.tsxapps/meteor/client/views/room/MemberListRouter.tsxapps/meteor/client/views/room/Room.tsxpackages/ui-contexts/src/RoomToolboxContext.tsapps/meteor/client/views/room/contextualBar/NotificationPreferences/NotificationPreferencesWithData.tsxapps/meteor/client/views/room/contextualBar/MessageListTab.tsxapps/meteor/client/views/room/contextualBar/uikit/UiKitContextualBar.tsxapps/meteor/client/views/room/providers/UserCardProvider.tsxapps/meteor/client/views/room/contextualBar/KeyboardShortcuts/KeyboardShortcutsWithData.tsxapps/meteor/client/hooks/roomActions/usePushNotificationsRoomAction.tsapps/meteor/client/views/room/contextualBar/MessageSearchTab/MessageSearchTab.tsxapps/meteor/client/hooks/roomActions/useUserInfoGroupRoomAction.tsapps/meteor/client/views/room/contextualBar/RoomMembers/InviteUsers/InviteUsersWithData.tsxapps/meteor/client/hooks/roomActions/useTeamInfoRoomAction.tsapps/meteor/client/hooks/roomActions/useThreadRoomAction.tsxapps/meteor/client/components/Contextualbar/ContextualbarDialog.tsxapps/meteor/client/views/room/contextualBar/Threads/components/ThreadChat.tsxapps/meteor/client/views/room/contextualBar/VideoConference/VideoConfList/VideoConfListWithData.tsxapps/meteor/client/hooks/roomActions/useOutlookCalenderRoomAction.tsapps/meteor/client/views/room/hooks/useAppsContextualBar.tsapps/meteor/client/views/room/contextualBar/Threads/Threads.tsxapps/meteor/client/hooks/roomActions/useMediaCallRoomAction.tsapps/meteor/client/views/room/contextualBar/ExportMessages/ExportMessages.tsxapps/meteor/client/hooks/roomActions/useAutotranslateRoomAction.tsapps/meteor/client/views/room/providers/hooks/useAppsRoomActions.tsapps/meteor/client/hooks/roomActions/useDiscussionsRoomAction.tsapps/meteor/client/hooks/roomActions/useOTRRoomAction.tsapps/meteor/client/views/omnichannel/cannedResponses/contextualBar/CannedResponse/WrapCannedResponseList.tsxapps/meteor/client/views/teams/contextualBar/info/TeamsInfoWithData.tsxapps/meteor/client/views/room/providers/RoomToolboxProvider.tsxapps/meteor/client/hooks/roomActions/useWebRTCVideoRoomAction.tsapps/meteor/client/views/room/HeaderV2/RoomToolbox/RoomToolbox.tsxapps/meteor/client/views/omnichannel/directory/calls/contextualBar/CallsContextualBarRoom.tsxapps/meteor/client/views/room/HeaderV2/RoomTitle.tsxapps/meteor/client/hooks/roomActions/useVideoCallRoomAction.tsxapps/meteor/client/views/room/contextualBar/RoomMembers/AddUsers/AddUsers.tsxapps/meteor/client/ui.tsapps/meteor/client/views/omnichannel/hooks/useRoomInfoRoomAction.tsapps/meteor/client/hooks/roomActions/useChannelSettingsRoomAction.tsapps/meteor/client/views/room/HeaderV2/RoomToolbox/hooks/useRoomToolboxActions.spec.tsapps/meteor/client/views/room/hooks/useAppsContextualBar.spec.tsapps/meteor/client/views/omnichannel/hooks/useVoIPRoomInfoRoomAction.tsapps/meteor/client/hooks/roomActions/useGameCenterRoomAction.tsapps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfoWithData.tsxapps/meteor/client/hooks/roomActions/useUploadedFilesListRoomAction.tsapps/meteor/client/hooks/roomActions/useExportMessagesRoomAction.tsapps/meteor/client/views/room/contextualBar/Threads/ThreadList.tsxapps/meteor/client/hooks/roomActions/useKeyboardShortcutListRoomAction.ts
**/*.spec.ts
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.spec.ts: Use descriptive test names that clearly communicate expected behavior in Playwright tests
Use.spec.tsextension for test files (e.g.,login.spec.ts)
Files:
apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.tsapps/meteor/client/views/room/HeaderV2/RoomToolbox/hooks/useRoomToolboxActions.spec.tsapps/meteor/client/views/room/hooks/useAppsContextualBar.spec.ts
🧠 Learnings (15)
📓 Common learnings
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.
📚 Learning: 2025-10-28T16:53:42.761Z
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37205
File: ee/packages/federation-matrix/src/FederationMatrix.ts:296-301
Timestamp: 2025-10-28T16:53:42.761Z
Learning: In the Rocket.Chat federation-matrix integration (ee/packages/federation-matrix/), the createRoom method from rocket.chat/federation-sdk will support a 4-argument signature (userId, roomName, visibility, displayName) in newer versions. Code using this 4-argument call is forward-compatible with planned library updates and should not be flagged as an error.
Applied to files:
apps/meteor/client/hooks/roomActions/useRocketSearchRoomAction.tsapps/meteor/client/hooks/roomActions/useCallsRoomAction.tsapps/meteor/client/hooks/roomActions/useCleanHistoryRoomAction.tsapps/meteor/client/apps/gameCenter/GameCenter.tsxapps/meteor/client/views/room/providers/hooks/useCoreRoomActions.tsapps/meteor/client/hooks/roomActions/useAppsRoomStarActions.tsxapps/meteor/client/views/omnichannel/hooks/useCannedResponsesRoomAction.tsapps/meteor/client/hooks/roomActions/useE2EERoomAction.tsapps/meteor/client/hooks/roomActions/useUserInfoRoomAction.tsapps/meteor/client/views/room/Header/RoomToolbox/RoomToolbox.tsxapps/meteor/client/hooks/roomActions/useTeamChannelsRoomAction.tsapps/meteor/client/views/room/contextualBar/Info/RoomInfoRouter.tsxapps/meteor/client/hooks/roomActions/useStarredMessagesRoomAction.tsapps/meteor/client/hooks/roomActions/usePinnedMessagesRoomAction.tsapps/meteor/client/views/room/contextualBar/OTR/OTRWithData.tsxapps/meteor/client/views/room/body/RoomBodyV2.tsxapps/meteor/client/views/room/lib/getRoomGroup.tsapps/meteor/client/views/room/body/RoomBody.tsxapps/meteor/client/hooks/roomActions/useMentionsRoomAction.tsapps/meteor/client/views/room/contextualBar/RoomMembers/RoomMembersWithData.tsxapps/meteor/client/views/omnichannel/hooks/useContactProfileRoomAction.tsapps/meteor/client/views/omnichannel/directory/chats/ChatInfo/ChatsContextualBar.tsxapps/meteor/client/hooks/roomActions/useMembersListRoomAction.tsapps/meteor/client/views/room/MemberListRouter.tsxapps/meteor/client/views/room/Room.tsxapps/meteor/client/views/room/contextualBar/NotificationPreferences/NotificationPreferencesWithData.tsxapps/meteor/client/views/room/contextualBar/uikit/UiKitContextualBar.tsxapps/meteor/client/hooks/roomActions/usePushNotificationsRoomAction.tsapps/meteor/client/hooks/roomActions/useUserInfoGroupRoomAction.tsapps/meteor/client/views/room/contextualBar/RoomMembers/InviteUsers/InviteUsersWithData.tsxapps/meteor/client/hooks/roomActions/useTeamInfoRoomAction.tsapps/meteor/client/hooks/roomActions/useThreadRoomAction.tsxapps/meteor/client/hooks/roomActions/useOutlookCalenderRoomAction.tsapps/meteor/client/views/room/contextualBar/Threads/Threads.tsxapps/meteor/client/views/room/contextualBar/ExportMessages/ExportMessages.tsxapps/meteor/client/hooks/roomActions/useAutotranslateRoomAction.tsapps/meteor/client/hooks/roomActions/useDiscussionsRoomAction.tsapps/meteor/client/hooks/roomActions/useOTRRoomAction.tsapps/meteor/client/views/room/providers/RoomToolboxProvider.tsxapps/meteor/client/hooks/roomActions/useWebRTCVideoRoomAction.tsapps/meteor/client/views/omnichannel/directory/calls/contextualBar/CallsContextualBarRoom.tsxapps/meteor/client/views/room/HeaderV2/RoomTitle.tsxapps/meteor/client/hooks/roomActions/useVideoCallRoomAction.tsxapps/meteor/client/views/room/contextualBar/RoomMembers/AddUsers/AddUsers.tsxapps/meteor/client/ui.tsapps/meteor/client/views/omnichannel/hooks/useRoomInfoRoomAction.tsapps/meteor/client/views/omnichannel/hooks/useVoIPRoomInfoRoomAction.tsapps/meteor/client/hooks/roomActions/useGameCenterRoomAction.tsapps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfoWithData.tsxapps/meteor/client/hooks/roomActions/useExportMessagesRoomAction.ts
📚 Learning: 2025-11-04T16:49:19.107Z
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 37377
File: apps/meteor/ee/server/hooks/federation/index.ts:86-88
Timestamp: 2025-11-04T16:49:19.107Z
Learning: In Rocket.Chat's federation system (apps/meteor/ee/server/hooks/federation/), permission checks follow two distinct patterns: (1) User-initiated federation actions (creating rooms, adding users to federated rooms, joining from invites) should throw MeteorError to inform users they lack 'access-federation' permission. (2) Remote server-initiated federation events should silently skip/ignore when users lack permission. The beforeAddUserToRoom hook only executes for local user-initiated actions, so throwing an error there is correct. Remote federation events are handled separately by the federation Matrix package with silent skipping logic.
Applied to files:
apps/meteor/client/hooks/roomActions/useCleanHistoryRoomAction.tsapps/meteor/client/views/room/contextualBar/RoomMembers/RoomMembersWithData.tsxapps/meteor/client/hooks/roomActions/useMembersListRoomAction.tsapps/meteor/client/hooks/roomActions/useVideoCallRoomAction.tsx
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Utilize Playwright fixtures (`test`, `page`, `expect`) for consistency in test files
Applied to files:
apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.tsapps/meteor/client/views/omnichannel/cannedResponses/contextualBar/CannedResponse/CannedResponseList.spec.tsxapps/meteor/client/views/room/HeaderV2/RoomToolbox/hooks/useRoomToolboxActions.spec.tsapps/meteor/client/views/room/hooks/useAppsContextualBar.spec.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Ensure tests run reliably in parallel without shared state conflicts
Applied to files:
apps/meteor/client/views/room/Header/RoomToolbox/hooks/useRoomToolboxActions.spec.tsapps/meteor/client/views/room/hooks/useAppsContextualBar.spec.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/page-objects/**/*.ts : Utilize existing page objects pattern from `apps/meteor/tests/e2e/page-objects/`
Applied to files:
apps/meteor/client/hooks/roomActions/useE2EERoomAction.tsapps/meteor/client/views/room/Header/RoomToolbox/RoomToolboxE2EESetup.tsxapps/meteor/client/views/room/HeaderV2/RoomToolbox/RoomToolboxE2EESetup.tsxapps/meteor/client/views/room/hooks/useAppsContextualBar.spec.ts
📚 Learning: 2025-11-19T12:32:29.696Z
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.
Applied to files:
apps/meteor/client/views/room/contextualBar/AutoTranslate/AutoTranslateWithData.tsxpackages/ui-contexts/package.jsonapps/meteor/client/hooks/roomActions/useMediaCallRoomAction.tsapps/meteor/client/hooks/roomActions/useAutotranslateRoomAction.ts
📚 Learning: 2025-11-19T18:20:07.720Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37419
File: packages/i18n/src/locales/en.i18n.json:918-921
Timestamp: 2025-11-19T18:20:07.720Z
Learning: Repo: RocketChat/Rocket.Chat — i18n/formatting
Learning: This repository uses a custom message formatting parser in UI blocks/messages; do not assume standard Markdown rules. For keys like Call_ended_bold, Call_not_answered_bold, Call_failed_bold, and Call_transferred_bold in packages/i18n/src/locales/en.i18n.json, retain the existing single-asterisk emphasis unless maintainers request otherwise.
Applied to files:
apps/meteor/client/hooks/roomActions/useStarredMessagesRoomAction.tsapps/meteor/client/hooks/roomActions/useMediaCallRoomAction.ts
📚 Learning: 2025-09-25T09:59:26.461Z
Learnt from: Dnouv
Repo: RocketChat/Rocket.Chat PR: 37057
File: packages/apps-engine/src/definition/accessors/IUserRead.ts:23-27
Timestamp: 2025-09-25T09:59:26.461Z
Learning: AppUserBridge.getUserRoomIds in apps/meteor/app/apps/server/bridges/users.ts always returns an array of strings (mapping subscription documents to room IDs), never undefined, even when user has no room subscriptions.
Applied to files:
apps/meteor/client/views/room/lib/getRoomGroup.ts
📚 Learning: 2025-09-25T09:59:26.461Z
Learnt from: Dnouv
Repo: RocketChat/Rocket.Chat PR: 37057
File: packages/apps-engine/src/definition/accessors/IUserRead.ts:23-27
Timestamp: 2025-09-25T09:59:26.461Z
Learning: AppUserBridge.getUserRoomIds in apps/meteor/app/apps/server/bridges/users.ts always returns an array of strings by mapping subscription documents to room IDs, never undefined, even when user has no room subscriptions.
Applied to files:
apps/meteor/client/views/room/lib/getRoomGroup.ts
📚 Learning: 2025-11-17T22:38:48.631Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37505
File: packages/i18n/src/locales/en.i18n.json:3765-3765
Timestamp: 2025-11-17T22:38:48.631Z
Learning: Rocket.Chat i18n copy: Keep sentence case for the value of "Notification_Desktop_show_voice_calls" in packages/i18n/src/locales/en.i18n.json (“Show desktop notifications for voice calls”) per design directive; do not change to Title Case even if nearby labels differ.
Applied to files:
apps/meteor/client/views/room/contextualBar/NotificationPreferences/NotificationPreferencesWithData.tsx
📚 Learning: 2025-11-17T14:30:36.271Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 37491
File: packages/desktop-api/src/index.ts:17-27
Timestamp: 2025-11-17T14:30:36.271Z
Learning: In the Rocket.Chat desktop API (`packages/desktop-api/src/index.ts`), the `CustomNotificationOptions` type has an optional `id` field by design. Custom notifications dispatched without an ID cannot be closed programmatically using `closeCustomNotification`, and this is intentional.
Applied to files:
apps/meteor/client/views/room/contextualBar/NotificationPreferences/NotificationPreferencesWithData.tsx
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Maintain test isolation between test cases in Playwright tests
Applied to files:
apps/meteor/client/views/room/hooks/useAppsContextualBar.spec.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use `expect` matchers for assertions (`toEqual`, `toContain`, `toBeTruthy`, `toHaveLength`, etc.) instead of `assert` statements in Playwright tests
Applied to files:
apps/meteor/client/views/room/hooks/useAppsContextualBar.spec.ts
📚 Learning: 2025-11-24T17:08:17.065Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Ensure clean state for each test execution in Playwright tests
Applied to files:
apps/meteor/client/views/room/hooks/useAppsContextualBar.spec.ts
🧬 Code graph analysis (1)
packages/ui-contexts/src/hooks/useRoomToolbox.ts (2)
packages/ui-contexts/src/index.ts (3)
useRoomToolbox(61-61)RoomToolboxContextValue(9-9)RoomToolboxContext(9-9)packages/ui-contexts/src/RoomToolboxContext.ts (2)
RoomToolboxContextValue(34-40)RoomToolboxContext(42-46)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: 📦 Build Packages
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
Contributor
📦 Docker Image Size Report📈 Changes
📊 Historical Trend---
config:
theme: "dark"
xyChart:
width: 900
height: 400
---
xychart
title "Image Size Evolution by Service (Last 30 Days + This PR)"
x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 13:35 (PR)"]
y-axis "Size (GB)" 0 --> 0.5
line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13]
line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13]
line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.35]
line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Statistics (last 7 days):
ℹ️ About this reportThis report compares Docker image sizes from this build against the
Updated: Thu, 27 Nov 2025 13:35:52 GMT |
tassoevan
approved these changes
Nov 27, 2025
tassoevan
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #37617 +/- ##
===========================================
- Coverage 68.83% 68.82% -0.01%
===========================================
Files 3361 3361
Lines 114340 114277 -63
Branches 20619 20618 -1
===========================================
- Hits 78706 78654 -52
+ Misses 33536 33525 -11
Partials 2098 2098
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This was referenced Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
VGA-90
Steps to test or reproduce
Further comments
Summary by CodeRabbit
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.