chore(server-fetch): Review build configuration

[tassoevan]

Proposed changes (including videos or screenshots)

It normalizes TypeScript and ESLint configurations for @rocket.chat/server-fetch.

Issue(s)

ARCH-1896

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Chores
  • Refined ESLint configuration patterns to improve precision in file exclusion during development
  • Reorganized package structure, including script commands and dependency arrangement, to enhance project maintainability
  • Added a new type checking script to the development workflow
  • Updated TypeScript compiler configuration settings

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 7.14.0, but it targets 7.13.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 707562c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The @rocket.chat/server-fetch package's build configuration is revised by updating ESLint ignore patterns, removing the TypeScript project flag from build scripts, adding a dedicated typecheck script, and updating the TypeScript module compiler option.

Changes

Cohort / File(s)	Summary
ESLint Configuration packages/server-fetch/.eslintrc.json	Changed ignorePatterns from recursive "**/dist" to non-recursive "dist" entry
TypeScript Configuration packages/server-fetch/tsconfig.json	Added "module": "esnext" to compilerOptions
Build Scripts & Structure packages/server-fetch/package.json	Removed -p tsconfig.json flag from build and dev scripts; added new typecheck script with tsc --noEmit; reorganized package.json structure with devDependencies repositioned

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• All changes are configuration-only with no logic modifications
• ESLint pattern change is a straightforward pattern simplification
• Build script updates are simple flag removals following a common pattern (consistent with related PRs)
• Single TypeScript compiler option addition

Possibly related PRs

• chore(ui-contexts): Review build configuration #37598: Identical ESLint ignore pattern change from "**/dist" to "dist" in a different package
• chore(web-ui-registration): Review build configuration #37584: Related build and config settings review across multiple packages
• chore(tracing): Review build configuration #37609: Same ESLint ignore pattern modification in another package-specific configuration

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• ggazzo

Poem

🐰 Lint and build, now neat and tight,
From /dist to dist, the patterns right,
With esnext flow and scripts so clean,
The finest config ever seen! ✨

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/server-fetch-build-configuration

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b33673b and 707562c.

📒 Files selected for processing (3)

• packages/server-fetch/.eslintrc.json (1 hunks)
• packages/server-fetch/package.json (1 hunks)
• packages/server-fetch/tsconfig.json (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change	Percent
sum of all images	1.2GiB	1.2GiB	+12MiB
rocketchat	358MiB	346MiB	+12MiB
omnichannel-transcript-service	132MiB	132MiB	+39B
queue-worker-service	132MiB	132MiB	+20B
ddp-streamer-service	127MiB	127MiB	-974B
account-service	114MiB	114MiB	-570B
stream-hub-service	111MiB	111MiB	+256B
authorization-service	111MiB	111MiB	-490B
presence-service	111MiB	111MiB	+510B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/26 13:38 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Loading

Statistics (last 7 days):

• 📊 Average: 1.5GiB
• ⬇️ Minimum: 1.2GiB
• ⬆️ Maximum: 1.6GiB
• 🎯 Current PR: 1.2GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

• Tag: pr-37613
• Baseline: develop
• Timestamp: 2025-11-26 13:38:34 UTC
• Historical data points: 7

---

Updated: Wed, 26 Nov 2025 13:38:35 GMT

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.81%. Comparing base (f5eedbe) to head (707562c).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #37613      +/-   ##
===========================================
- Coverage    68.83%   68.81%   -0.02%     
===========================================
  Files         3361     3361              
  Lines       114340   114291      -49     
  Branches     20619    20618       -1     
===========================================
- Hits         78706    78653      -53     
- Misses       33536    33543       +7     
+ Partials      2098     2095       -3     

Flag	Coverage Δ
e2e	57.32% <ø> (-0.03%)	⬇️
e2e-api	42.21% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.