fix: fuselage-ui-kit i18next version mismatch breaking apps translations locally
#37549
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
WalkthroughThe i18next devDependency in fuselage-ui-kit is downgraded from ^23.10.1 to ~23.4.9. i18next and react-i18next are added to dependencies and peerDependencies with wildcard versions, restructuring the package's internationalization dependency declarations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/fuselage-ui-kit/package.json (1)
42-114: Verify the fix resolves translations locally without breaking tests.The PR description lacks critical details: no explanation of the version mismatch, no test results, no reproduction steps, and no linked issues. Before merging, please confirm:
- The fix has been tested locally and translations now work correctly.
- All existing tests pass with these version changes.
- No regressions are introduced in other parts of the codebase.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
packages/fuselage-ui-kit/package.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: 📦 Build Packages
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
🔇 Additional comments (1)
packages/fuselage-ui-kit/package.json (1)
111-114: Clarify the actual changes and address the wildcard version concern.Your review contains an incorrect claim:
i18nextandreact-i18nextwere not added to thedependenciessection—they were added topeerDependencieswith wildcard versions. Thedependenciessection remains unchanged with only internal@rocket.chat/*packages. However, your concern about wildcard versions is valid and worth addressing:
- In
devDependencies:i18nextwas downgraded from^23.10.1to~23.4.9- In
peerDependencies:i18nextwas added as*(allows any version)This creates a contradictory constraint: the PR tightens the version in devDependencies but loosens it to any version in peerDependencies, which could reintroduce the mismatch you mention. Verify whether the wildcard versions are intentional for library compatibility or if they should be pinned to match the devDependencies versions.
Likely an incorrect or invalid review comment.
📦 Docker Image Size Report📈 Changes
📊 Historical Trend---
config:
theme: "dark"
xyChart:
width: 900
height: 400
---
xychart
title "Image Size Evolution by Service (Last 30 Days + This PR)"
x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 18:25", "12/08 19:07 (PR)"]
y-axis "Size (GB)" 0 --> 0.5
line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Statistics (last 15 days):
ℹ️ About this reportThis report compares Docker image sizes from this build against the
Updated: Mon, 08 Dec 2025 19:07:15 GMT |
gabriellsh
changed the title
fuselage-ui-kit i18next version mismatch breaking app translations locallyfuselage-ui-kit i18next version mismatch breaking apps translations locally
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #37549 +/- ##
===========================================
- Coverage 67.88% 67.80% -0.08%
===========================================
Files 3450 3450
Lines 113976 113976
Branches 20955 20955
===========================================
- Hits 77374 77286 -88
- Misses 34473 34574 +101
+ Partials 2129 2116 -13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
tassoevan
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Proposed changes (including videos or screenshots)
The mismatched version makes the
useTranslationhook fromreact-i18nextunable to get the i18next instance from the TranslationProvider that is rendered by theapps/meteorapp. This issue happens only on develop due to the dependency being a devDependency only, so up until now no workspace should have been impacted.Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit