Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Nov 14, 2025

ARCH-1880

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Removed the deprecated VoIP FreeSwitch extension assignment API endpoint. Update integrations and applications using this endpoint for compatibility with this major version release.

@juliajforesti juliajforesti added this to the 8.0.0 milestone Nov 14, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 14, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2025

🦋 Changeset detected

Latest commit: d2a5cc7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025

Walkthrough

Removes the deprecated voip-freeswitch.extension.assign API endpoint, including its route handler, TypeScript type definition, JSON schema validator, and all related exports. Updates changeset for major version bump.

Changes

Cohort / File(s) Summary
Changeset Entry
.changeset/fluffy-windows-train.md
Documents major version bump and removal of deprecated voip-freeswitch.extension.assign endpoint.
API Route Removal
apps/meteor/ee/app/api-enterprise/server/voip-freeswitch.ts
Removed the POST voip-freeswitch.extension.assign route handler, including request validation and license requirements. Removed import of isVoipFreeSwitchExtensionAssignProps.
Type Definitions & Exports
packages/rest-typings/src/v1/voip-freeswitch/VoipFreeSwitchExtensionAssignProps.ts, packages/rest-typings/src/v1/voip-freeswitch/index.ts
Deleted VoipFreeSwitchExtensionAssignProps type definition, JSON schema, and validator. Removed related imports and exports from index file.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Homogeneous changes following a consistent removal pattern across multiple files
  • No complex logic or conditional restructuring
  • Straightforward deprecation cleanup with clear scope

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • ggazzo

Poem

🐰 A deprecated path now fades away,
With schemas and validators swept from play,
The Freeswitch extension bids farewell,
While cleaner APIs emerge to tell,
Of progress made with each removal made! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing the deprecated voip-freeswitch.extension.assign endpoint, which aligns with the changeset and file modifications.
Linked Issues check ✅ Passed The pull request fulfills the objective stated in ARCH-1880 by removing all references to the deprecated voip-freeswitch.extension.assign endpoint across the codebase.
Out of Scope Changes check ✅ Passed All changes are focused on removing the deprecated voip-freeswitch.extension.assign endpoint and related type definitions, with no unrelated modifications present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-voip-freeswitch.extension.assign

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 481c8af and 02fe6d3.

📒 Files selected for processing (4)
  • .changeset/fluffy-windows-train.md (1 hunks)
  • apps/meteor/ee/app/api-enterprise/server/voip-freeswitch.ts (0 hunks)
  • packages/rest-typings/src/v1/voip-freeswitch/VoipFreeSwitchExtensionAssignProps.ts (0 hunks)
  • packages/rest-typings/src/v1/voip-freeswitch/index.ts (0 hunks)
💤 Files with no reviewable changes (3)
  • packages/rest-typings/src/v1/voip-freeswitch/VoipFreeSwitchExtensionAssignProps.ts
  • packages/rest-typings/src/v1/voip-freeswitch/index.ts
  • apps/meteor/ee/app/api-enterprise/server/voip-freeswitch.ts
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-19T15:15:04.642Z
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

Applied to files:

  • .changeset/fluffy-windows-train.md
🔇 Additional comments (1)
.changeset/fluffy-windows-train.md (1)

1-5: Changeset is well-formed and appropriately documents the removal.

The major version bump is correct for removing a deprecated API endpoint (breaking change). The changelog message clearly describes the removal.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@juliajforesti juliajforesti marked this pull request as ready for review November 14, 2025 18:21
@juliajforesti juliajforesti requested review from a team as code owners November 14, 2025 18:21
@ggazzo ggazzo requested review from a team as code owners November 18, 2025 18:57
@ggazzo ggazzo force-pushed the chore/remove-voip-freeswitch.extension.assign branch from 02fe6d3 to d2a5cc7 Compare November 18, 2025 18:59
@juliajforesti juliajforesti removed request for a team December 1, 2025 13:59
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.1GiB 1.1GiB +36MiB
rocketchat 366MiB 347MiB +19MiB
omnichannel-transcript-service 141MiB 132MiB +8.7MiB
queue-worker-service 141MiB 132MiB +8.7MiB
ddp-streamer-service 127MiB 127MiB +49KiB
account-service 114MiB 114MiB +46KiB
authorization-service 111MiB 111MiB +49KiB
presence-service 111MiB 111MiB +48KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 15:59", "12/01 17:01 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.14]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.14]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.36]
Loading

Statistics (last 10 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.1GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37507
  • Baseline: develop
  • Timestamp: 2025-12-01 17:01:14 UTC
  • Historical data points: 10

Updated: Mon, 01 Dec 2025 17:01:14 GMT

@juliajforesti
Copy link
Contributor Author

The removal of this method is included in PR #37657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants