feat: Move enhanced navigation out of feature preview

[dougfabris]

Proposed changes (including videos or screenshots)

Move enhanced navigation outside of feature preview

Issue(s)

Steps to test or reproduce

Further comments

CORE-1351

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: ad22a34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages

Name	Type
@rocket.chat/ui-client	Major
@rocket.chat/meteor	Major
@rocket.chat/gazzodown	Major
@rocket.chat/ui-voip	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/livechat	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/core-typings	Major
@rocket.chat/rest-typings	Major
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/http-router	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-contexts	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/federation-matrix	Patch
@rocket.chat/license	Patch
@rocket.chat/media-calls	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/omni-core-ee	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-video-conf	Major
@rocket.chat/instance-status	Patch
@rocket.chat/omni-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

127 files out of 244 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/promote-newNavigation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 90.38462% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.14%. Comparing base (3c42f0d) to head (0622b2c).
⚠️ Report is 401 commits behind head on release-8.0.0.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-8.0.0   #37285      +/-   ##
=================================================
+ Coverage          66.43%   72.14%   +5.70%     
=================================================
  Files               3276     1454    -1822     
  Lines             109596    75926   -33670     
  Branches           20860    10822   -10038     
=================================================
- Hits               72814    54776   -18038     
+ Misses             34116    20736   -13380     
+ Partials            2666      414    -2252     

Flag	Coverage Δ
e2e	?
e2e-api	?
unit	72.14% <90.38%> (+0.57%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[reetp]

Are you seriously going to foist this junk on everyone?

Amongst others..... This is seriously poor and not prime time.

#36727

[dougfabris]

Hello @reetp have you considered change your tone? I've been seen you all the time so mad with the community, I don't think this is the spirit of the thing. We're all professionals here mate, we appreciate kind and respect. I already answered you in the issue you attached.

[reetp]

Hello @reetp have you considered change your tone? I've been seen you all the time so mad with the community, I don't think this is the spirit of the thing.

Nope. If it's junk, it's junk.

I've probably done more work in the community here than anyone. Check my record over 9 years. I'm critical if criticism is required.

What I can't stand is an ostrich mentality.

We're all professionals here mate, we appreciate kind and respect.

Respect goes two ways.

Get over it & start listening. That's what professionals do. Accept they've made mistakes. When my staff tell me I've made a mistake I have to listen.

I've raised criticisms & effectively been told "it's great, you'll get used to it & love it". Very Gnome.

I've told you why it's a bad piece of design. And I won't be using it.

#33561 (comment)

[dougfabris]

Let me tell you something John, as soon as you raised your concern here, I get into all your comments regarding this feature and detailed it to share with the product team, who makes such decision. I stand there trying to make community being heard, but it seems who doesn't listens is you.

If you've been around for 9 years, you should already know that, although engineers are the ones who raise pull requests, they aren't the ones who make the major product decisions.

I agree with you in a lot of points but in the end, I'm payed to make my work and accept that sometimes is not up to me.
The only thing I'm asking you, is to be polite with who dedicate time to listen and talk to you in this open community, because there are others that don't give a shit, so try to be patient as we are with you.