chore: Prevent default room & team channels from becoming abac managed (and viceversa) #37264
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughAdds checks preventing default and team-default rooms from becoming ABAC-managed or being set as defaults when ABAC is enabled, with API guards, channel-settings validation, subscription skipping, ABAC core guards, and new unit and end-to-end tests. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant API as API / Methods
participant ABAC as ABAC Service
participant DB as Rooms DB
User->>API: request (set default / update team / modify ABAC)
API->>DB: fetch room (include abacAttributes, default, teamDefault)
DB-->>API: room metadata
alt Room has abacAttributes AND (default or teamDefault) AND ABAC enabled
API-->>User: reject (error-cannot-convert-default-room-to-abac / error-room-is-abac-managed)
else
API->>ABAC: proceed with ABAC operation or update
ABAC-->>API: result
API-->>User: result
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
KevLehman
force-pushed
the
chore/prevent-default-room-abac
branch
from
a17f4ac to
9103d1e
Compare
apps/meteor/app/lib/server/functions/addUserToDefaultChannels.ts
Outdated
Show resolved
Hide resolved
apps/meteor/app/channel-settings/server/methods/saveRoomSettings.ts
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/abac #37264 +/- ##
============================================
Coverage ? 70.11%
============================================
Files ? 3035
Lines ? 104276
Branches ? 18501
============================================
Hits ? 73118
Misses ? 29211
Partials ? 1947
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
KevLehman
force-pushed
the
chore/prevent-default-room-abac
branch
from
6fa04b9 to
aa54532
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
♻️ Duplicate comments (1)
apps/meteor/app/lib/server/functions/addUserToDefaultChannels.ts (1)
17-19: Skip ABAC‑managed rooms: OK, but cache flag and confirm settings key.
- Compute the flag once before the loop to avoid repeated lookups.
- Verify the setting id; prior reviews referenced Abac_Enabled/Abac_Enable. Align repo‑wide on a single key and consider a shared helper to read it.
Apply:
- for await (const room of defaultRooms) { - if (settings.get('ABAC_Enabled') && room?.abacAttributes?.length) { + const abacEnabled = settings.get('ABAC_Enabled'); + for await (const room of defaultRooms) { + if (abacEnabled && room?.abacAttributes?.length) { continue; }Run to check for mixed keys:
#!/bin/bash rg -n -C1 -S "settings\.get\(['\"]A?B?A?C?_?E?n?a?b?l?e?d?['\"]" \ | sed 's/.*settings\.get(\x27\|\x22\)\(.*\)\(\x27\|\x22\).*/\1/' \ | sort -u
🧹 Nitpick comments (7)
apps/meteor/app/channel-settings/server/methods/saveRoomSettings.ts (1)
66-79: Validator correctly blocks default=true on ABAC rooms.Logic and placement are sound. Consider standardizing the error id to match routes (e.g., error-room-is-abac-managed) and a more precise action string for easier i18n/handling.
ee/packages/abac/src/index.ts (3)
172-179: Block converting default/teamDefault rooms to ABAC: LGTM.Projection includes needed fields; guard throws early as intended. Consider logging a warn before throwing to aid ops diagnostics.
Also applies to: 183-186
222-241: Normalize ABAC attributes: dedupe values to avoid redundant churn.Current normalize allows duplicate values (tests rely on this), which can create noisy diffs and unnecessary writes. Safely dedupe while preserving order.
Apply:
- private validateAndNormalizeAttributes(attributes: Record<string, string[]>): IAbacAttributeDefinition[] { + private validateAndNormalizeAttributes(attributes: Record<string, string[]>): IAbacAttributeDefinition[] { const keyPattern = /^[A-Za-z0-9_-]+$/; const normalized: IAbacAttributeDefinition[] = []; if (Object.keys(attributes).length > 10) { throw new Error('error-invalid-attribute-values'); } for (const [key, values] of Object.entries(attributes)) { if (!keyPattern.test(key)) { throw new Error('error-invalid-attribute-key'); } if (values.length > 10) { throw new Error('error-invalid-attribute-values'); } - normalized.push({ key, values }); + // de-duplicate values while preserving order + const seen = new Set<string>(); + const deduped = values.filter((v) => (seen.has(v) ? false : (seen.add(v), true))); + normalized.push({ key, values: deduped }); } return normalized; }
10-12: Variable shadowing of ‘limit’.Module‑scope limit from p‑limit and local pagination limit share the same name. It’s harmless but confusing. Rename the pagination variable (e.g., pageSize) for clarity.
Also applies to: 52-55
ee/packages/abac/src/index.spec.ts (1)
1-818: Add tests for team default toggling semantics.After adjusting teams.updateRoom to only block when isDefault=true, add tests to ensure isDefault=false succeeds for ABAC rooms and isDefault=true is blocked.
apps/meteor/tests/end-to-end/api/abac.ts (2)
410-462: Consider consolidating setup logic.While multiple
beforehooks are functionally correct, the static analysis tool flags this pattern. Consider consolidating related setup steps into fewer hooks for better readability, or add comments explaining why they're separated.For example:
-before('create team main room for rooms.saveRoomSettings default restriction test', async () => { - // ... setup code ... -}); - -before('create local ABAC attribute definition for tests', async () => { - // ... setup code ... -}); - -before('create private room and try to set it as default', async () => { - // ... setup code ... -}); - -before('create private team, private room inside it and set as team default', async () => { - // ... setup code ... -}); +before('setup test fixtures for default room restrictions', async () => { + // Create team main room for rooms.saveRoomSettings default restriction test + // ... consolidated setup code ... + + // Create local ABAC attribute definition for tests + // ... consolidated setup code ... + + // Create private room and try to set it as default + // ... consolidated setup code ... + + // Create private team, private room inside it and set as team default + // ... consolidated setup code ... +});
611-648: Consider consolidating setup hooks.Similar to the previous suite, multiple
beforehooks are flagged by static analysis. While functionally correct, consolidating these two related setup steps into a single hook would improve readability.Based on learnings
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (6)
apps/meteor/app/api/server/v1/teams.ts(2 hunks)apps/meteor/app/channel-settings/server/methods/saveRoomSettings.ts(2 hunks)apps/meteor/app/lib/server/functions/addUserToDefaultChannels.ts(2 hunks)apps/meteor/tests/end-to-end/api/abac.ts(3 hunks)ee/packages/abac/src/index.spec.ts(5 hunks)ee/packages/abac/src/index.ts(5 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
ee/packages/abac/src/index.ts (1)
packages/core-typings/src/IRoom.ts (1)
IRoom(22-98)
apps/meteor/tests/end-to-end/api/abac.ts (2)
apps/meteor/tests/data/api-data.ts (2)
request(10-10)credentials(39-42)apps/meteor/tests/e2e/utils/create-target-channel.ts (2)
deleteTeam(66-68)deleteRoom(48-50)
🪛 Biome (2.1.2)
apps/meteor/tests/end-to-end/api/abac.ts
[error] 424-430: Disallow duplicate setup and teardown hooks.
Disallow before duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
[error] 432-440: Disallow duplicate setup and teardown hooks.
Disallow before duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
[error] 442-462: Disallow duplicate setup and teardown hooks.
Disallow before duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
[error] 545-550: Disallow duplicate setup and teardown hooks.
Disallow after duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
[error] 631-648: Disallow duplicate setup and teardown hooks.
Disallow before duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
🔇 Additional comments (9)
apps/meteor/app/lib/server/functions/addUserToDefaultChannels.ts (1)
8-8: Import looks good.Consistent with other modules using server settings.
apps/meteor/app/api/server/v1/teams.ts (1)
23-23: Import looks good.apps/meteor/app/channel-settings/server/methods/saveRoomSettings.ts (1)
14-14: Import looks good.ee/packages/abac/src/index.ts (4)
270-276: Update values guard for default/teamDefault: LGTM.Also applies to: 281-284
323-325: Remove attribute guard for default/teamDefault: LGTM.Also applies to: 330-333
351-357: Add attribute-by-key guard for default/teamDefault: LGTM.Also applies to: 362-365
384-390: Replace attribute-by-key guard for default/teamDefault: LGTM.Also applies to: 395-398
ee/packages/abac/src/index.spec.ts (1)
392-397: Great negative‑path coverage for default/teamDefault.Tests assert the new guards across all entry points. Nicely done.
Also applies to: 398-403, 530-536, 537-543, 601-606, 607-613, 655-661, 662-668, 739-745, 746-752
apps/meteor/tests/end-to-end/api/abac.ts (1)
400-677: Excellent test coverage for ABAC default room restrictions.The new test suites thoroughly validate that:
- Default and team-default rooms cannot become ABAC-managed
- ABAC-managed rooms cannot become default or team-default
- Restrictions are properly lifted when flags are removed
The test scenarios cover the key edge cases outlined in the PR objectives (ABAC-64).
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/meteor/tests/end-to-end/api/abac.ts (2)
411-462: Multiplebeforehooks are intentional but could be consolidated.The static analysis tool flags multiple
beforehooks, but each performs a distinct setup step (team creation, attribute definition, room setup). While this is valid, combining them into a singlebeforehook might improve readability and make the test setup flow clearer.Example consolidation:
-before('create team main room for rooms.saveRoomSettings default restriction test', async () => { +before('setup test environment', async () => { + // Create team with main room const createTeamMain = await request .post(`${v1}/teams.create`) .set(credentials) .send({ name: teamNameMainRoom, type: 1 }) .expect(200); teamIdMainRoom = createTeamMain.body.team._id; - mainRoomIdSaveSettings = createTeamMain.body.team?.roomId; - await request.post(`${v1}/rooms.saveRoomSettings`).set(credentials).send({ rid: mainRoomIdSaveSettings, default: true }).expect(200); -}); - -before('create local ABAC attribute definition for tests', async () => { + + // Create ABAC attribute definition await request .post(`${v1}/abac/attributes`) .set(credentials) .send({ key: localAbacKey, values: ['red', 'green'] }) .expect(200); -}); - -before('create private room and try to set it as default', async () => { + + // Create private default room const res = await createRoom({ type: 'p', name: `abac-default-room-${Date.now()}`, }); privateDefaultRoomId = res.body.group._id; - await request.post(`${v1}/rooms.saveRoomSettings`).set(credentials).send({ rid: privateDefaultRoomId, default: true }).expect(200); -}); - -before('create private team, private room inside it and set as team default', async () => { + + // Create team with default room const createTeamRes = await request.post(`${v1}/teams.create`).set(credentials).send({ name: teamName, type: 0 }).expect(200); teamId = createTeamRes.body.team._id; - const roomRes = await createRoom({ type: 'p', name: `abac-team-room-${Date.now()}`, extraData: { teamId }, }); teamPrivateRoomId = roomRes.body.group._id; - const setDefaultRes = await request .post(`${v1}/teams.updateRoom`) .set(credentials) .send({ teamId, roomId: teamPrivateRoomId, isDefault: true }) .expect(200); - if (setDefaultRes.body?.room?.teamDefault) { teamDefaultRoomId = teamPrivateRoomId; } });
606-643: Multiplebeforehooks could be consolidated.Similar to the first test suite, these
beforehooks perform distinct setup steps but could be combined into a single hook for better readability. The current approach is valid but consolidation would improve test organization.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/meteor/tests/end-to-end/api/abac.ts(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
apps/meteor/tests/end-to-end/api/abac.ts (2)
apps/meteor/tests/data/api-data.ts (2)
request(10-10)credentials(39-42)apps/meteor/tests/e2e/utils/create-target-channel.ts (2)
deleteRoom(48-50)deleteTeam(66-68)
🪛 Biome (2.1.2)
apps/meteor/tests/end-to-end/api/abac.ts
[error] 424-430: Disallow duplicate setup and teardown hooks.
Disallow before duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
[error] 432-440: Disallow duplicate setup and teardown hooks.
Disallow before duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
[error] 442-462: Disallow duplicate setup and teardown hooks.
Disallow before duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
[error] 626-643: Disallow duplicate setup and teardown hooks.
Disallow before duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: 📦 Build Packages
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
🔇 Additional comments (5)
apps/meteor/tests/end-to-end/api/abac.ts (5)
9-9: LGTM!The
deleteTeamimport is correct, and all usages in the file (lines 543, 544, 646) properly pass team names as strings, matching the expected signature.
464-539: LGTM!The test cases comprehensively verify that:
- Default rooms cannot be converted to ABAC-managed rooms
- Team default rooms cannot be converted to ABAC-managed rooms
- ABAC attributes can be added after removing default flags
- The restrictions apply correctly to team main rooms
The error assertions and success conditions are appropriate.
541-545: LGTM!The cleanup correctly uses team names (
teamNameandteamNameMainRoom) instead of IDs, addressing the previous review concerns. All resources created during test setup are properly cleaned up.
649-671: LGTM!The tests correctly verify the inverse restriction: ABAC-managed rooms (both regular and team rooms) cannot be converted to default rooms. The error assertions properly check for the expected error messages.
645-647: LGTM!The cleanup properly addresses the previous review comment by including
abacRoomIddeletion. TheteamRoomIdis likely cascade-deleted when the team is deleted. UsingPromise.allfor concurrent cleanup is appropriate.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/meteor/tests/end-to-end/api/abac.ts (2)
410-460: Consider consolidating duplicatebeforehooks (linter warning).Biome flags duplicate
beforehooks at lines 410-420, 422-428, 430-438, and 440-460. While your descriptive labels improve readability, consolidating these into a singlebeforehook or using nesteddescribeblocks would resolve the linter warnings and follow testing best practices.Example consolidation:
-before('create team main room for rooms.saveRoomSettings default restriction test', async () => { - const createTeamMain = await request - .post(`${v1}/teams.create`) - .set(credentials) - .send({ name: teamNameMainRoom, type: 1 }) - .expect(200); - - mainRoomIdSaveSettings = createTeamMain.body.team?.roomId; - - await request.post(`${v1}/rooms.saveRoomSettings`).set(credentials).send({ rid: mainRoomIdSaveSettings, default: true }).expect(200); -}); - -before('create local ABAC attribute definition for tests', async () => { - await request - .post(`${v1}/abac/attributes`) - .set(credentials) - .send({ key: localAbacKey, values: ['red', 'green'] }) - .expect(200); -}); - -before('create private room and try to set it as default', async () => { - const res = await createRoom({ - type: 'p', - name: `abac-default-room-${Date.now()}`, - }); - privateDefaultRoomId = res.body.group._id; - - await request.post(`${v1}/rooms.saveRoomSettings`).set(credentials).send({ rid: privateDefaultRoomId, default: true }).expect(200); -}); - -before('create private team, private room inside it and set as team default', async () => { +before(async () => { + // Create team main room for rooms.saveRoomSettings default restriction test + const createTeamMain = await request + .post(`${v1}/teams.create`) + .set(credentials) + .send({ name: teamNameMainRoom, type: 1 }) + .expect(200); + + mainRoomIdSaveSettings = createTeamMain.body.team?.roomId; + await request.post(`${v1}/rooms.saveRoomSettings`).set(credentials).send({ rid: mainRoomIdSaveSettings, default: true }).expect(200); + + // Create local ABAC attribute definition for tests + await request + .post(`${v1}/abac/attributes`) + .set(credentials) + .send({ key: localAbacKey, values: ['red', 'green'] }) + .expect(200); + + // Create private room and set as default + const res = await createRoom({ + type: 'p', + name: `abac-default-room-${Date.now()}`, + }); + privateDefaultRoomId = res.body.group._id; + await request.post(`${v1}/rooms.saveRoomSettings`).set(credentials).send({ rid: privateDefaultRoomId, default: true }).expect(200); + + // Create private team, private room inside it and set as team default const createTeamRes = await request.post(`${v1}/teams.create`).set(credentials).send({ name: teamName, type: 0 }).expect(200); teamId = createTeamRes.body.team._id; const roomRes = await createRoom({ type: 'p', name: `abac-team-room-${Date.now()}`, extraData: { teamId }, }); teamPrivateRoomId = roomRes.body.group._id; const setDefaultRes = await request .post(`${v1}/teams.updateRoom`) .set(credentials) .send({ teamId, roomId: teamPrivateRoomId, isDefault: true }) .expect(200); if (setDefaultRes.body?.room?.teamDefault) { teamDefaultRoomId = teamPrivateRoomId; } });
604-641: Consider consolidating duplicatebeforehooks (linter warning).Similar to the previous test block, Biome flags duplicate
beforehooks at lines 604-622 and 624-641. Consider consolidating them into a singlebeforehook for cleaner code and to resolve linter warnings.Example consolidation:
-before('create attribute definition and ABAC-managed private room', async () => { +before(async () => { + // Create attribute definition and ABAC-managed private room await request .post(`${v1}/abac/attributes`) .set(credentials) .send({ key: conversionAttrKey, values: ['alpha', 'beta'] }) .expect(200); const roomRes = await createRoom({ type: 'p', name: `abac-conversion-room-${Date.now()}`, }); abacRoomId = roomRes.body.group._id; await request .post(`${v1}/abac/room/${abacRoomId}/attributes/${conversionAttrKey}`) .set(credentials) .send({ values: ['alpha'] }) .expect(200); -}); - -before('create team, private room inside, add ABAC attribute', async () => { - // Public team + + // Create team, private room inside, add ABAC attribute const teamRes = await request.post(`${v1}/teams.create`).set(credentials).send({ name: teamName, type: 0 }).expect(200); teamIdForConversion = teamRes.body.team._id; const teamRoomRes = await createRoom({ type: 'p', name: `abac-team-conversion-room-${Date.now()}`, extraData: { teamId: teamIdForConversion }, }); teamRoomId = teamRoomRes.body.group._id; await request .post(`${v1}/abac/room/${teamRoomId}/attributes/${conversionAttrKey}`) .set(credentials) .send({ values: ['beta'] }) .expect(200); });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/meteor/tests/end-to-end/api/abac.ts(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
apps/meteor/tests/end-to-end/api/abac.ts (2)
apps/meteor/tests/data/api-data.ts (2)
request(10-10)credentials(39-42)apps/meteor/tests/e2e/utils/create-target-channel.ts (2)
deleteRoom(48-50)deleteTeam(66-68)
🪛 Biome (2.1.2)
apps/meteor/tests/end-to-end/api/abac.ts
[error] 422-428: Disallow duplicate setup and teardown hooks.
Disallow before duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
[error] 430-438: Disallow duplicate setup and teardown hooks.
Disallow before duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
[error] 440-460: Disallow duplicate setup and teardown hooks.
Disallow before duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
[error] 624-641: Disallow duplicate setup and teardown hooks.
Disallow before duplicacy inside the describe function.
(lint/suspicious/noDuplicateTestHooks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: 📦 Build Packages
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
🔇 Additional comments (5)
apps/meteor/tests/end-to-end/api/abac.ts (5)
9-9: LGTM! Import is correct.The
deleteTeamimport and its usage throughout the file correctly match the helper signature(credentials, teamName).
462-537: Excellent test coverage for default room ABAC restrictions.The test cases comprehensively validate the PR objective:
- Blocking ABAC attribute assignment to default and team-default rooms (lines 462-484)
- Allowing ABAC after removing default flags (lines 486-514)
- Enforcing restrictions on team main rooms (lines 516-537)
Error messages are properly validated, and both negative and positive paths are tested.
539-543: LGTM! Cleanup is complete.The
afterhook properly cleans up all created resources. Team deletions will cascade to associated rooms (mainRoomIdSaveSettingsandteamPrivateRoomId).
647-669: Excellent coverage for ABAC-to-default conversion restrictions.These tests properly validate the reverse direction: preventing ABAC-managed rooms from being converted to default or team-default. Error messages are validated, completing the bidirectional protection required by the PR objective.
643-645: LGTM! Cleanup properly handles all resources.The
afterhook correctly cleans up both the team (which cascades toteamRoomId) and the standalone ABAC-managed room.
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
…d (and viceversa) (#37264) Co-authored-by: Tasso <tasso.evangelista@rocket.chat>
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/ABAC-64
Steps to test or reproduce
Further comments
Summary by CodeRabbit
New Features
Bug Fixes
Tests