chore: Remove unused expect-error directives

[KevLehman]

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Refactor

  • Removed legacy TypeScript suppression comments across message action handlers and toolbar hooks to align with current typings and improve maintainability. No changes to runtime behavior.
  • All existing tooltips, enable/disable states, and encryption checks remain unaffected.

• Chores

  • Strengthened type safety for message forwarding, permalinking, and reply-in-DM actions through minor internal cleanup.
  • No user-facing changes; functionality and UI remain the same.

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: f1ddcdf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Removed TypeScript suppression comments related to ABAC properties and flags in three message toolbar components/hooks. No runtime logic, control flow, or exports changed.

Changes

Cohort / File(s)	Summary
Remove TS suppression in message toolbar actions apps/meteor/client/components/message/toolbar/items/actions/ForwardMessageAction.tsx, apps/meteor/client/components/message/toolbar/usePermalinkAction.ts, apps/meteor/client/components/message/toolbar/useReplyInDMAction.ts	Deleted // @ts-expect-error comments guarding access to ABAC-related fields (e.g., abacAttributes, isABACEnabled). No functional changes; enables type checking for these properties.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• chore: Restrict certain messages actions on ABAC rooms #37128 — Introduced ABAC-aware logic in the same files; this PR removes the temporary TS suppressions added then.
• chore: Stop hardcoding tooltips on message actions #37127 — Adjusted message toolbar action tooltips; overlaps with the hooks where suppressions are now removed.

Suggested labels

stat: ready to merge

Suggested reviewers

• dougfabris

Poem

I nibble at comments, snip-snip—so neat,
No logic disturbed, just tidy and sweet.
ABAC now typed, my whiskers agree,
Fewer hush-notes, more clarity.
Hop, test, merge—carrot complete! 🥕🐇

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/update-types

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7a64054 and f1ddcdf.

📒 Files selected for processing (3)

• apps/meteor/client/components/message/toolbar/items/actions/ForwardMessageAction.tsx (0 hunks)
• apps/meteor/client/components/message/toolbar/usePermalinkAction.ts (0 hunks)
• apps/meteor/client/components/message/toolbar/useReplyInDMAction.ts (0 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.92%. Comparing base (7a64054) to head (f1ddcdf).
⚠️ Report is 1 commits behind head on feat/abac.

Additional details and impacted files

@@              Coverage Diff              @@
##           feat/abac   #37234      +/-   ##
=============================================
- Coverage      71.52%   69.92%   -1.61%     
=============================================
  Files           1409     2983    +1574     
  Lines          73664   102098   +28434     
  Branches       10622    18270    +7648     
=============================================
+ Hits           52690    71391   +18701     
- Misses         20572    28752    +8180     
- Partials         402     1955    +1553     

Flag	Coverage Δ
e2e	57.29% <ø> (?)
unit	71.51% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.