Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Oct 15, 2025

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-1843

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • New Features
    • None
  • Bug Fixes
    • None
  • Refactor
    • Standardized input skeletons by replacing legacy placeholders with the new InputBoxSkeleton across admin dashboard filters, settings skeletons, invite link, and registration forms for consistent loading states.
  • Chores
    • Updated imports to align with the latest UI component naming, ensuring consistency with the UI library and future compatibility.

@tassoevan tassoevan added this to the 7.12.0 milestone Oct 15, 2025
@tassoevan tassoevan requested a review from a team as a code owner October 15, 2025 13:34
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 15, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.12.0, but it targets 7.11.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2025

⚠️ No Changeset found

Latest commit: d68b16d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 15, 2025

Walkthrough

Replaces usages of InputBox.Skeleton with the new InputBoxSkeleton component across admin, room invite, and registration UI files, updating imports and JSX accordingly. No changes to component APIs, logic, or control flow.

Changes

Cohort / File(s) Summary of changes
Admin dashboard filter skeleton update
apps/meteor/client/views/admin/engagementDashboard/EngagementDashboardCardFilter.tsx
Swapped InputBox.Skeleton to InputBoxSkeleton and updated import from @rocket.chat/fuselage.
Admin settings skeleton update
apps/meteor/client/views/admin/settings/Setting/SettingSkeleton.tsx
Replaced InputBox.Skeleton with InputBoxSkeleton; adjusted import accordingly.
Room invite link skeleton update
apps/meteor/client/views/room/contextualBar/RoomMembers/InviteUsers/InviteLink.tsx
Updated conditional render from InputBox.Skeleton to InputBoxSkeleton and modified import.
Registration form skeleton update
packages/web-ui-registration/src/template/FormSkeleton.tsx
Changed JSX to use InputBoxSkeleton and updated imports to remove InputBox usage.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

stat: ready to merge

Suggested reviewers

  • ggazzo

Poem

A hop, a bop, I shuffle code in light,
Skeletons switched—now everything feels right.
InputBox sheds old bones for new,
UI hums a sleeker hue.
Thump-thump, says my rabbit heart—
Tiny refactors, tidy art. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely summarizes the primary change of replacing InputBox.Skeleton with InputBoxSkeleton, which directly reflects the modifications made in the pull request. It is specific, free of extraneous details, and immediately conveys the main intent to a reviewer.
Linked Issues Check ✅ Passed All occurrences of InputBox.Skeleton have been replaced with the new InputBoxSkeleton component in imports and JSX across the affected files, fulfilling the sole coding objective specified in ARCH-1843 without leaving any references behind.
Out of Scope Changes Check ✅ Passed The changes are strictly limited to renaming and replacing skeleton component imports and usages and do not include any unrelated logic or structural modifications outside the scope of the referenced issue.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/inputbox-component-namespace

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9282732 and d68b16d.

📒 Files selected for processing (4)
  • apps/meteor/client/views/admin/engagementDashboard/EngagementDashboardCardFilter.tsx (1 hunks)
  • apps/meteor/client/views/admin/settings/Setting/SettingSkeleton.tsx (2 hunks)
  • apps/meteor/client/views/room/contextualBar/RoomMembers/InviteUsers/InviteLink.tsx (2 hunks)
  • packages/web-ui-registration/src/template/FormSkeleton.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
🔇 Additional comments (5)
packages/web-ui-registration/src/template/FormSkeleton.tsx (1)

1-1: LGTM! Import and usage correctly updated.

The migration from InputBox.Skeleton to InputBoxSkeleton is clean and consistent.

Also applies to: 22-22

apps/meteor/client/views/room/contextualBar/RoomMembers/InviteUsers/InviteLink.tsx (1)

1-1: LGTM! Import and conditional rendering correctly updated.

The replacement is properly applied in the conditional loading state.

Also applies to: 25-25

apps/meteor/client/views/admin/settings/Setting/SettingSkeleton.tsx (1)

1-1: LGTM! Import and usage correctly updated.

The migration is properly applied in the skeleton component.

Also applies to: 12-12

apps/meteor/client/views/admin/engagementDashboard/EngagementDashboardCardFilter.tsx (2)

1-1: LGTM! Import and default prop correctly updated.

The migration is properly applied in the default children prop.

Also applies to: 8-8


1-14: Confirm migration complete: no remaining InputBox.Skeleton references
Search returned zero matches for InputBox.Skeleton—no further action needed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.43%. Comparing base (9282732) to head (d68b16d).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37231      +/-   ##
===========================================
- Coverage    67.44%   67.43%   -0.01%     
===========================================
  Files         3289     3289              
  Lines       111887   111887              
  Branches     20443    20441       -2     
===========================================
- Hits         75465    75454      -11     
- Misses       33736    33747      +11     
  Partials      2686     2686              
Flag Coverage Δ
e2e 57.33% <0.00%> (+0.01%) ⬆️
unit 71.46% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Oct 15, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 15, 2025
@kodiakhq kodiakhq bot merged commit 31a135c into develop Oct 15, 2025
89 of 93 checks passed
@kodiakhq kodiakhq bot deleted the chore/inputbox-component-namespace branch October 15, 2025 15:28
antm-rp pushed a commit to antm-rp/Rocket.Chat that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants