Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Oct 14, 2025

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-1842

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Style
    • Updated the New Import page to use the latest design system components for form labels, rows, and hints, improving visual consistency and alignment.
    • Refined JSX structure to ensure correct nesting and layout, resulting in cleaner spacing and presentation.
    • No functional changes; the update is purely presentational to enhance readability and coherence across the form.

@tassoevan tassoevan requested a review from a team as a code owner October 14, 2025 21:47
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 14, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.12.0, but it targets 7.11.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2025

⚠️ No Changeset found

Latest commit: c436312

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Walkthrough

Replaced deprecated Field subcomponents with named components in NewImportPage: Field.Label → FieldLabel, Field.Row → FieldRow, and Field.Hint → FieldHint. Adjusted JSX structure and closing tags accordingly. No logic, exports, or control flow changes.

Changes

Cohort / File(s) Summary
UI component renaming in NewImportPage
apps/meteor/client/views/admin/import/NewImportPage.tsx
Swapped Field.LabelFieldLabel, Field.RowFieldRow, Field.HintFieldHint; updated JSX nesting/closing tags to match new components; presentation-only refactor aligning with fuselage public components.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at tidy code,
Hop-hop through fields where labels flowed.
Rows renamed, hints neatly aligned—
Carrots of clarity, all redefined.
In burrows of JSX I gleam,
A rabbit proud of this clean theme. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly identifies the main change of replacing the Field.* namespace with named components, accurately reflecting the core update made in the pull request.
Linked Issues Check ✅ Passed The changes consistently replace Field.Label, Field.Row, and Field.Hint with the corresponding named components FieldLabel, FieldRow, and FieldHint as required by ARCH-1842, fulfilling the linked issue’s coding objective.
Out of Scope Changes Check ✅ Passed The diff contains only the intended renaming of UI component tags and does not introduce any code unrelated to switching from Field.* to named components.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/field-component-namespace

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 40e68e5 and 9ce3726.

📒 Files selected for processing (1)
  • apps/meteor/client/views/admin/import/NewImportPage.tsx (5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: Builds matrix rust bindings against alpine
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🔇 Additional comments (2)
apps/meteor/client/views/admin/import/NewImportPage.tsx (2)

219-237: LGTM! Consistent migration across all Field blocks.

All instances of Field.Label, Field.Row, and Field.Hint have been correctly replaced with their named equivalents (FieldLabel, FieldRow, FieldHint). The props and component hierarchy are preserved, and the Field wrapper component continues to be used appropriately.

Also applies to: 242-258, 277-290, 297-302, 307-312


1-16: Verify fuselage named exports
Ensure FieldLabel, FieldRow, and FieldHint are exported by @rocket.chat/fuselage@~0.66.4.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.45%. Comparing base (2f59e71) to head (c436312).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37228      +/-   ##
===========================================
+ Coverage    67.43%   67.45%   +0.02%     
===========================================
  Files         3289     3289              
  Lines       111887   111887              
  Branches     20443    20441       -2     
===========================================
+ Hits         75447    75470      +23     
+ Misses       33751    33734      -17     
+ Partials      2689     2683       -6     
Flag Coverage Δ
e2e 57.31% <ø> (-0.03%) ⬇️
unit 71.49% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan added this to the 7.12.0 milestone Oct 14, 2025
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Oct 14, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 14, 2025
@kodiakhq kodiakhq bot merged commit 9282732 into develop Oct 15, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/field-component-namespace branch October 15, 2025 08:07
antm-rp pushed a commit to antm-rp/Rocket.Chat that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants