-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: Use named components instead of Field.*
#37228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughReplaced deprecated Field subcomponents with named components in NewImportPage: Field.Label → FieldLabel, Field.Row → FieldRow, and Field.Hint → FieldHint. Adjusted JSX structure and closing tags accordingly. No logic, exports, or control flow changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #37228 +/- ##
===========================================
+ Coverage 67.43% 67.45% +0.02%
===========================================
Files 3289 3289
Lines 111887 111887
Branches 20443 20441 -2
===========================================
+ Hits 75447 75470 +23
+ Misses 33751 33734 -17
+ Partials 2689 2683 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Issue(s)
ARCH-1842
Steps to test or reproduce
Further comments
Summary by CodeRabbit