Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Oct 14, 2025

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-1841

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Style

    • Polished the display of participant avatars in video conference lists for a more consistent, compact look.
  • Refactor

    • Aligned the video conference participant avatar rendering with the current design system for improved maintainability and consistency.

@tassoevan tassoevan added this to the 7.12.0 milestone Oct 14, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 14, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.12.0, but it targets 7.11.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2025

⚠️ No Changeset found

Latest commit: 2343625

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Walkthrough

Replaced Avatar.Stack with AvatarStack in the VideoConfListItem component and updated imports accordingly. No public APIs or signatures changed.

Changes

Cohort / File(s) Summary
UI component swap: Avatar.Stack ➜ AvatarStack
apps/meteor/client/views/room/contextualBar/VideoConference/VideoConfList/VideoConfListItem.tsx
Updated import to include AvatarStack from @rocket.chat/fuselage and replaced JSX wrapper from Avatar.Stack to AvatarStack, keeping inner UserAvatar usage unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A hop and a swap in the UI stack,
I nudge my whiskers—no logic to track.
From dot to no-dot, the avatars align,
Carrots approved, the components shine.
Thump-thump! Minor tweak, squeaky-clean—
Ship it swift, like a springtime scene. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title succinctly describes the main change of replacing Avatar.Stack with AvatarStack, matching the modifications in the code and providing clear context to reviewers.
Linked Issues Check ✅ Passed The changes directly implement the objective from ARCH-1841 by updating the import and usage of Avatar.Stack to AvatarStack in the VideoConfListItem component without omitting any required modifications.
Out of Scope Changes Check ✅ Passed All modifications are confined to replacing the Avatar component usage in the specified file and align with the chore objective, with no unrelated code or files altered.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/avatar-component-namespace

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 40e68e5 and 2343625.

📒 Files selected for processing (1)
  • apps/meteor/client/views/room/contextualBar/VideoConference/VideoConfList/VideoConfListItem.tsx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: 🔎 Code Check / Code Lint
  • GitHub Check: 📦 Meteor Build - coverage
🔇 Additional comments (2)
apps/meteor/client/views/room/contextualBar/VideoConference/VideoConfList/VideoConfListItem.tsx (2)

3-3: LGTM! Import updated correctly.

The AvatarStack component is properly imported from @rocket.chat/fuselage, and the import list maintains good organization.


93-107: Confirm AvatarStack API availability
No remaining Avatar.Stack usages found; ensure AvatarStack is exported by the installed @rocket.chat/fuselage version.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tassoevan tassoevan marked this pull request as ready for review October 14, 2025 20:31
@tassoevan tassoevan requested a review from a team as a code owner October 14, 2025 20:31
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.43%. Comparing base (40e68e5) to head (2343625).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37226      +/-   ##
===========================================
- Coverage    67.43%   67.43%   -0.01%     
===========================================
  Files         3289     3289              
  Lines       111887   111887              
  Branches     20442    20437       -5     
===========================================
- Hits         75452    75446       -6     
- Misses       33747    33753       +6     
  Partials      2688     2688              
Flag Coverage Δ
e2e 57.31% <ø> (ø)
unit 71.46% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 14, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 14, 2025
@ggazzo ggazzo merged commit fef8715 into develop Oct 14, 2025
94 of 100 checks passed
@ggazzo ggazzo deleted the chore/avatar-component-namespace branch October 14, 2025 22:01
antm-rp pushed a commit to antm-rp/Rocket.Chat that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants