Skip to content

Conversation

@MartinSchoeler
Copy link
Member

Proposed changes (including videos or screenshots)

While implementing another feature preview item we've noticed that one of the images was low res, what was happening is that the image was being stretched beyond it's native size, this PR changes the image to have the same size as the other feature preview images

Issue(s)

Steps to test or reproduce

Just open the feature preview page and examine the html
Screenshot 2025-10-07 at 17 18 18

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 7, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.12.0, but it targets 7.11.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2025

⚠️ No Changeset found

Latest commit: 3a5bd6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 7, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • apps/meteor/public/images/featurePreview/quick-reactions.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/feature-preview-img-size

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.36%. Comparing base (5403210) to head (3a5bd6d).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37163      +/-   ##
===========================================
+ Coverage    67.34%   67.36%   +0.02%     
===========================================
  Files         3285     3285              
  Lines       112249   112249              
  Branches     20361    20366       +5     
===========================================
+ Hits         75593    75621      +28     
+ Misses       33976    33955      -21     
+ Partials      2680     2673       -7     
Flag Coverage Δ
e2e 57.32% <ø> (+0.01%) ⬆️
unit 71.17% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review October 7, 2025 21:38
@dougfabris dougfabris changed the title fix: blurry quick reactions preview chore: Replace blurry quick reactions image preview Oct 7, 2025
@dougfabris dougfabris added this to the 7.12.0 milestone Oct 7, 2025
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Oct 7, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 7, 2025
@kodiakhq kodiakhq bot merged commit beebaf0 into develop Oct 8, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/feature-preview-img-size branch October 8, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants