-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: send to client the contact info of who requested a call transfer. #37150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…uested a call transfer.
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughAdds transfer attribution to media calls. Introduces getNewCallTransferredBy, computes transferredBy for new/existing call signals, conditionally includes parentCallId and transferredBy in server-emitted payloads, extends public signal and client call types with transferredBy, and stores/exposes it in the client Call during remote initialization. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as UserActorAgent
participant SP as SignalProcessor
participant Util as getNewCallTransferredBy
participant C as Client (ClientMediaCall)
rect rgb(240,248,255)
U->>Util: getNewCallTransferredBy(call)
Util-->>U: transferredBy | null
U->>SP: emit NewCall signal { ..., parentCallId?, transferredBy? }
end
Note over SP: Build payloads for caller/callee variants
SP-->>C: ServerMediaSignalNewCall { ..., transferredBy? }
rect rgb(245,255,250)
C->>C: initializeRemoteCall(signal)
C->>C: this._transferredBy = signal.transferredBy || null
C-->>C: getter transferredBy exposes value
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (6)
🧰 Additional context used🧬 Code graph analysis (5)packages/media-signaling/src/definition/signals/server/new.ts (1)
ee/packages/media-calls/src/server/getNewCallTransferredBy.ts (2)
packages/media-signaling/src/lib/Call.ts (1)
ee/packages/media-calls/src/internal/SignalProcessor.ts (2)
ee/packages/media-calls/src/internal/agents/UserActorAgent.ts (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #37150 +/- ##
===========================================
+ Coverage 67.42% 67.44% +0.02%
===========================================
Files 3289 3287 -2
Lines 111887 111747 -140
Branches 20437 20404 -33
===========================================
- Hits 75438 75373 -65
+ Misses 33763 33688 -75
Partials 2686 2686
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Issue(s)
Related to VGA-9
Steps to test or reproduce
Further comments
Summary by CodeRabbit