-
Notifications
You must be signed in to change notification settings - Fork 13k
regression: missing "duration" and "success" information for voice calls #37100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
WalkthroughAdded two optional timestamp fields to IMediaCall (acceptedAt, activatedAt). Updated model methods to set these timestamps when accepting or activating a call, alongside existing state and expiration updates. No signature changes; surrounding logic and error handling unchanged. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client
participant MediaCallsModel as Models.MediaCalls
participant Store as Persistence
rect rgba(200,230,255,0.25)
note over Client,Store: Accept call flow (adds acceptedAt)
Client->>MediaCallsModel: acceptCallById(callId, userId)
MediaCallsModel->>Store: update(callId, { state: accepted, expiresAt, acceptedAt: now })
Store-->>MediaCallsModel: ack
MediaCallsModel-->>Client: result
end
rect rgba(220,255,220,0.25)
note over Client,Store: Activate call flow (adds activatedAt)
Client->>MediaCallsModel: activateCallById(callId, userId)
MediaCallsModel->>Store: update(callId, { state: active, expiresAt, activatedAt: now })
Store-->>MediaCallsModel: ack
MediaCallsModel-->>Client: result
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-7.11.0 #37100 +/- ##
==================================================
- Coverage 67.39% 67.39% -0.01%
==================================================
Files 3328 3330 +2
Lines 113341 113481 +140
Branches 20564 20605 +41
==================================================
+ Hits 76387 76478 +91
- Misses 34348 34396 +48
- Partials 2606 2607 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
On the next phase of the voip project, we'll be implementing several features that may need to identify the duration of a call or identify if the call was sucessfull or not. These features include the call history, message blocks and also statistics.
However, the current version doesn't save any data that can be used to calculate a call's duration or indicate if it was successful once it is over. This PR makes a simple change to make the data format more future-proof, so that this information won't be missing from old calls when the new features get implemented.
With this information being already available, it also makes it much easier to identify problems when looking at a call's data on the database.
Issue(s)
VAI-148
Steps to test or reproduce
Further comments
Summary by CodeRabbit