chore: improve voip session handling

[pierre-lehnen-rc]

Proposed changes (including videos or screenshots)

Issue(s)

VGA-29

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Bug Fixes
  • Ensures previous call sessions are fully terminated before starting a new one, preventing duplicated sessions.
  • Reduces occurrences of stuck call indicators and improves reconnection reliability.
  • Lowers unnecessary background activity after ending a call, enhancing call stability and resource usage.

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 7.12.0, but it targets 7.11.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 855b277

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

Reworks MediaSessionStore.makeInstance cleanup: if an existing sessionInstance exists, call endSession() and set sessionInstance = null before constructing a new MediaSignalingSession, replacing the prior disableStateReport() call. No public exports changed.

Changes

Cohort / File(s)	Summary
Media session lifecycle update packages/ui-voip/src/v2/useMediaSessionInstance.ts	On re-instantiation, invoke endSession() and set sessionInstance = null before creating a new MediaSignalingSession, replacing prior disableStateReport() call.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Store as MediaSessionStore
    participant Old as existing sessionInstance
    participant New as MediaSignalingSession (new)

    Store->>Store: makeInstance()
    alt sessionInstance exists
        rect rgba(200,230,255,0.35)
        note right of Old: Cleanup changed
        Store->>Old: endSession()
        Store->>Store: sessionInstance = null
        end
    else
        note over Store: No prior session
    end
    Store->>New: new MediaSignalingSession(...)
    Store->>Store: sessionInstance = New

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• chore: enable media calls client logger #37079 — Modifies MediaSessionStore.makeInstance to add a MediaCallLogger and pass it into MediaSignalingSession; touches the same construction site and lifecycle code.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• tassoevan
• ggazzo

Poem

A hop, a stop — the old I end,
I clear the burrow, then begin.
Threads untied, a tidy spin,
New call springs forth with mittened grin. 🐇📞

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title uses a concise conventional-commit style and accurately summarizes that the change improves VOIP session handling, which matches the updated cleanup logic in useMediaSessionInstance.ts.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/voip-client-issues

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e233ce1 and 9dc708f.

📒 Files selected for processing (1)

• packages/ui-voip/src/v2/useMediaSessionInstance.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: 📦 Build Packages
• GitHub Check: Builds matrix rust bindings against alpine
• GitHub Check: CodeQL-Build
• GitHub Check: CodeQL-Build

🔇 Additional comments (1)

packages/ui-voip/src/v2/useMediaSessionInstance.ts (1)

98-101: Improved cleanup approach; endSession is synchronous.

endSession() is a synchronous void method (no async/Promise), so cleanup completes before instantiating a new session.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.42%. Comparing base (c4b3153) to head (855b277).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #37094      +/-   ##
===========================================
+ Coverage    67.41%   67.42%   +0.01%     
===========================================
  Files         3288     3288              
  Lines       111815   111815              
  Branches     20421    20420       -1     
===========================================
+ Hits         75379    75396      +17     
+ Misses       33748    33712      -36     
- Partials      2688     2707      +19     

Flag	Coverage Δ
e2e	57.31% <ø> (-0.01%)	⬇️
unit	71.40% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.