fix: wrong feedback message when inviting external users

[juliajforesti]

FDR-83

Proposed changes (including videos or screenshots)

Toast message was indicating the users have been added instead of invited to join a federated channel.

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• New Features

  • Federation-aware Add Users flow: uses a federated user selector in federated rooms and respects federation block status.
  • Contextual success feedback: shows “Users invited” when inviting users to federated rooms; keeps “Users added” elsewhere.

• Localization

  • Added translation string for “Users invited” to improve invitation messaging.

• Chores

  • Patch updates to related packages.

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 1f03659

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 43 packages

Name	Type
@rocket.chat/i18n	Patch
@rocket.chat/meteor	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/http-router	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/federation-service	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/federation-matrix	Patch
@rocket.chat/license	Patch
@rocket.chat/media-calls	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/omni-core-ee	Patch
@rocket.chat/instance-status	Patch
@rocket.chat/omni-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

Derives federation flags in AddUsers, switches between federated and non-federated user-autocomplete components, and changes the save success toast to Users_invited when inviting external users. Adds the Users_invited i18n key and a changeset documenting patch bumps for two packages.

Changes

Cohort / File(s)	Summary
Federation-aware AddUsers flow apps/meteor/client/views/room/contextualBar/RoomMembers/AddUsers/AddUsers.tsx	Introduces roomIsFederated and isFederationBlocked derived flags, consolidates their usage, selects federated vs non-federated autocomplete components, and conditionally shows Users_invited vs Users_added on success.
Locale additions packages/i18n/src/locales/en.i18n.json	Adds new translation key Users_invited with value "The users have been invited".
Release metadata .changeset/late-impalas-battle.md	Adds a changeset documenting the messaging change and patch bumps for @rocket.chat/i18n and @rocket.chat/meteor.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant UI as AddUsers UI
  participant S as Server

  U->>UI: Select users and click Save
  UI->>UI: Evaluate roomIsFederated / isFederationBlocked
  UI->>S: Submit add/invite request
  S-->>UI: Success

  alt roomIsFederated && !isFederationBlocked
    UI->>U: Toast: Users_invited
  else
    UI->>U: Toast: Users_added
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: missing external users validation on members tab #37071 — Modifies AddUsers.tsx and federation handling; overlaps in federated UI/toast behavior.
• refactor: better isRoomFederated usage  #36952 — Centralizes isRoomFederated checks into derived variables across room components.
• fix: Add users on federated room members wrong behavior #36994 — Edits AddUsers.tsx federated flow, component selection, and post-action messaging.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• ggazzo
• dougfabris

Poem

I twitch my whiskers at the merge,
Invite, not add — a careful surge.
A tiny toast hops into view,
"The users have been invited" — true.
I thump my foot and clap my paws, hooray! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly summarizes the primary change by specifying that it fixes the incorrect feedback message shown when inviting external users, and it is concise and specific enough for teammates to understand the main update.
Linked Issues Check	✅ Passed	The changes update the success toast in AddUsers to use the new Users_invited translation key for federated channels and add the corresponding string to the locale file, directly satisfying the objective of FDR-83 to correct the feedback when inviting external users.
Out of Scope Changes Check	✅ Passed	All modifications are focused on updating the invitation feedback logic for federated rooms, adding the translation key, and documenting the patch in the changeset, with no unrelated code alterations.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/add-external-users

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 11e34ca and 1f03659.

📒 Files selected for processing (3)

• .changeset/late-impalas-battle.md (1 hunks)
• apps/meteor/client/views/room/contextualBar/RoomMembers/AddUsers/AddUsers.tsx (2 hunks)
• packages/i18n/src/locales/en.i18n.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• .changeset/late-impalas-battle.md
• packages/i18n/src/locales/en.i18n.json
• apps/meteor/client/views/room/contextualBar/RoomMembers/AddUsers/AddUsers.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: 📦 Build Packages
• GitHub Check: CodeQL-Build
• GitHub Check: CodeQL-Build

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.38%. Comparing base (23ba66a) to head (1f03659).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #37068   +/-   ##
========================================
  Coverage    67.38%   67.38%           
========================================
  Files         3328     3328           
  Lines       113342   113342           
  Branches     20559    20562    +3     
========================================
+ Hits         76371    76380    +9     
+ Misses       34364    34361    -3     
+ Partials      2607     2601    -6     

Flag	Coverage Δ
e2e	57.27% <66.66%> (-0.01%)	⬇️
unit	71.15% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.