fix(federation): missing icon tooltip on add users modal #37065

juliajforesti · 2025-09-25T18:31:40Z

FDR-137

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

New Features
- Added a tooltip showing user verification status when adding users to federated rooms.
- Introduced status icons and titles (Verified, Unverified, Unable to verify) in the add-users modal.
Style
- Refined the add-users modal layout for clearer status display and improved readability.
Localization
- Added English translations for verification statuses: VERIFIED, UNVERIFIED, UNABLE_TO_VERIFY.
Chores
- Recorded patch release updates for related packages.

changeset-bot · 2025-09-25T18:31:44Z

🦋 Changeset detected

Latest commit: 69b7a8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages

Name	Type
@rocket.chat/i18n	Patch
@rocket.chat/meteor	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/http-router	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/media-calls	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/omni-core-ee	Patch
@rocket.chat/instance-status	Patch
@rocket.chat/omni-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dionisio-bot · 2025-09-25T18:31:45Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

coderabbitai · 2025-09-25T18:31:47Z

Walkthrough

Adds a changeset for patch releases. Updates AddMatrixUsersModal.tsx to render a verification tooltip list with explicit icon typing and simplified layout. Adds three i18n keys (VERIFIED, UNVERIFIED, UNABLE_TO_VERIFY) for tooltip messages in en.i18n.json.

Changes

Cohort / File(s)	Summary
UI: Federated add-users modal `apps/meteor/client/views/room/contextualBar/RoomMembers/AddUsers/AddMatrixUsers/AddMatrixUsersModal.tsx`	Refactors list rendering to flex-based Box li items; adds tooltip text via i18n keys; sets explicit return type for verificationStatusAsIcon; defaults unknown status to circle-exclamation; simplifies ModalFooter.
i18n additions `packages/i18n/src/locales/en.i18n.json`	Adds keys: VERIFIED, UNVERIFIED, UNABLE_TO_VERIFY with messages; minor comma/structure update to allow new entries.
Release metadata `.changeset/neat-spoons-worry.md`	Declares patch updates for @rocket.chat/i18n and @rocket.chat/meteor; notes tooltip feature.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant UI as AddMatrixUsersModal (UI)
  participant I18N as i18n
  participant M as Matrix Verification

  U->>UI: Open modal / add federated users
  UI->>M: Fetch verification statuses
  M-->>UI: Status list (verified/unverified/unable)
  UI->>I18N: Resolve tooltip texts (VERIFIED/UNVERIFIED/UNABLE_TO_VERIFY)
  I18N-->>UI: Localized strings
  UI-->>U: Render list with status icon + tooltip
  U->>UI: Hover status icon
  UI-->>U: Show tooltip text

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

ggazzo

Poem

A nibble of code, a tooltip to show,
I hop through the modal where federated winds blow.
Three little strings, verified and bright—
Icons aligned, tooltips now right.
Thump-thump, ship the patch—onward we go! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Out of Scope Changes Check	⚠️ Warning	The PR includes refactoring of the list markup and ModalFooter layout that are unrelated to the tooltip fix, as well as version bump changes, which exceed the scope of the linked issue FDR-137.	Please remove or isolate unrelated refactors such as the list markup restructuring and ModalFooter layout changes, and restrict version bump changes to the release process separate from the bug fix.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title “fix(federation): missing icon tooltip on add users modal” clearly summarizes the primary change of adding a tooltip for the federated users modal, following conventional commit format and directly matching the PR’s main objective.
Linked Issues Check	✅ Passed	The changes implement Option A from FDR-137 by adding explanatory tooltip text for verification statuses via new i18n keys and integrating a title attribute on the icon, satisfactorily addressing the reported missing tooltip functionality in the add users modal.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/matrix-users-modal

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 22b63f0 and 69b7a8b.

📒 Files selected for processing (3)

.changeset/neat-spoons-worry.md (1 hunks)
apps/meteor/client/views/room/contextualBar/RoomMembers/AddUsers/AddMatrixUsers/AddMatrixUsersModal.tsx (2 hunks)
packages/i18n/src/locales/en.i18n.json (1 hunks)

🔇 Additional comments (4)

packages/i18n/src/locales/en.i18n.json (1)

7038-7041: New verification strings look good

Wording is clear and matches the intended tooltip messaging.

apps/meteor/client/views/room/contextualBar/RoomMembers/AddUsers/AddMatrixUsers/AddMatrixUsersModal.tsx (2)

30-39: Typed icon mapping looks great

Returning ComponentProps<typeof Icon>['name'] keeps future icon updates type-safe and prevents regressions.

71-82: Tooltip fix confirmed

Driving the list through Fuselage Box elements and setting the Icon’s title ensures the status tooltip now appears as expected while keeping the markup simple.

.changeset/neat-spoons-worry.md (1)

6-6: Concise changeset summary reads well.

The note clearly states the UX fix and scope—nothing else needed.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…odal

codecov · 2025-09-25T18:58:53Z

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.39%. Comparing base (22b63f0) to head (69b7a8b).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #37065      +/-   ##
===========================================
+ Coverage    67.35%   67.39%   +0.04%     
===========================================
  Files         3326     3326              
  Lines       113195   113253      +58     
  Branches     20534    20556      +22     
===========================================
+ Hits         76240    76327      +87     
+ Misses       34350    34306      -44     
- Partials      2605     2620      +15

Flag	Coverage Δ
e2e	`57.29% <25.00%> (+0.01%)`	⬆️
e2e-api	`40.82% <ø> (+0.41%)`	⬆️
unit	`71.12% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

juliajforesti added 3 commits September 25, 2025 15:35

fix: add icon tooltip and improve type definitions in AddMatrixUsersM…

cae8cd5

…odal

chore: add translations

fafadbb

chore: changeset

69b7a8b

juliajforesti force-pushed the fix/matrix-users-modal branch from b0c0044 to 69b7a8b Compare September 25, 2025 18:35

juliajforesti marked this pull request as ready for review September 25, 2025 20:40

juliajforesti requested a review from a team as a code owner September 25, 2025 20:40

ggazzo approved these changes Sep 25, 2025

View reviewed changes

ggazzo added this to the 7.11.0 milestone Sep 25, 2025

ggazzo merged commit d0467df into develop Sep 25, 2025
50 checks passed

ggazzo deleted the fix/matrix-users-modal branch September 25, 2025 21:46

rocketchat-github-ci mentioned this pull request Sep 27, 2025

Release 7.11.0 #37081

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(federation): missing icon tooltip on add users modal #37065

fix(federation): missing icon tooltip on add users modal #37065

Uh oh!

juliajforesti commented Sep 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

dionisio-bot bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(federation): missing icon tooltip on add users modal #37065

fix(federation): missing icon tooltip on add users modal #37065

Uh oh!

Conversation

juliajforesti commented Sep 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

dionisio-bot bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

codecov bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

juliajforesti commented Sep 25, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Sep 25, 2025 •

edited

Loading

dionisio-bot bot commented Sep 25, 2025 •

edited

Loading

coderabbitai bot commented Sep 25, 2025 •

edited

Loading

codecov bot commented Sep 25, 2025 •

edited

Loading