Skip to content

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Sep 23, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Bug Fixes
    • Fixed login failures when using iframe-based authentication, ensuring a consistent sign-in experience for users in embedded contexts (e.g., portals or third-party integrations).
    • Improves reliability of authentication flows without changing existing user workflows or introducing new features.
    • No other user-facing changes detected.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 23, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2025

⚠️ No Changeset found

Latest commit: 6ff4aba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 23, 2025

Walkthrough

Updated a changeset file to adjust the release bump for @rocket.chat/meteor from minor to patch, retaining the note "Fixes login using iframe authentication." No source or API changes.

Changes

Cohort / File(s) Summary
Changeset metadata
\.changeset/green-ants-shop.md
Changed version bump type from minor to patch; release note unchanged; no code or API modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nibbled the notes with careful cheer,
A patch, not minor—let’s make it clear.
No code to hop, no fields to till,
Just tidy tags on the changelog hill.
Fixes iframe logins? Ear-perk thrill! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore: Update changeset" succinctly reflects the primary change in this PR — an update to a changeset file (.changeset/green-ants-shop.md) rather than functional code — and is concise and clear for repository history scanning.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/update-more-changeset

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 909698a and 6ff4aba.

📒 Files selected for processing (1)
  • .changeset/green-ants-shop.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🔇 Additional comments (2)
.changeset/green-ants-shop.md (2)

1-6: Patch bump matches a bug fix; frontmatter looks valid.

Format is correct and aligns with the stated intent. Good to merge.


2-2: Verified — package exists and no conflicting changesets.

Found .changeset/green-ants-shop.md, .changeset/bump-patch-1758105438017.md, .changeset/grumpy-berries-arrive.md (all 'patch'); package declared at apps/meteor/package.json; .changeset/config.json lists @rocket.chat/meteor in a fixed group with @rocket.chat/core-typings and @rocket.chat/rest-typings. Optional: add the fixing PR/issue link to the changeset body for changelog clarity.


Comment @coderabbitai help to get the list of available commands and usage tips.

@yash-rajpal yash-rajpal marked this pull request as ready for review September 23, 2025 20:15
@scuciatto scuciatto merged commit 5dc5fee into release-7.9.4 Sep 23, 2025
9 checks passed
@scuciatto scuciatto deleted the chore/update-more-changeset branch September 23, 2025 23:17
@coderabbitai coderabbitai bot mentioned this pull request Oct 6, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 15, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 7, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 14, 2025
@coderabbitai coderabbitai bot mentioned this pull request Dec 8, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants