-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: Remove stories title on meteor app storybook #37030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
WalkthroughThis PR removes the Storybook meta title field from numerous .stories.tsx files across the meteor app. Only story metadata is altered; components, stories, decorators, args, and behavior remain unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (107)
⛔ Files not processed due to max files limit (23)
💤 Files with no reviewable changes (107)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #37030 +/- ##
===========================================
+ Coverage 66.33% 67.31% +0.98%
===========================================
Files 3094 3339 +245
Lines 109415 113178 +3763
Branches 19685 20528 +843
===========================================
+ Hits 72582 76189 +3607
+ Misses 34494 34381 -113
- Partials 2339 2608 +269
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
After some efforts trying to organize our storybooks using the story title param, we decide to go with the implicit method which relies upon the physical location of the stories to position them in the sidebar since we're strict to our files organization
Issue(s)
Steps to test or reproduce
Further comments
CORE-1392
Summary by CodeRabbit