-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: Adds deprecation warning on livechat:saveCustomField with new endpoint replacing it
#36971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: b20bab8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (7)
✨ Finishing touches
🧪 Generate unit tests
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36971 +/- ##
===========================================
- Coverage 67.34% 66.28% -1.06%
===========================================
Files 3339 3393 +54
Lines 113205 115454 +2249
Branches 20532 21183 +651
===========================================
+ Hits 76234 76532 +298
- Misses 34361 36308 +1947
- Partials 2610 2614 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dougfabris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On behalf of frontend, looks good!
Proposed changes (including videos or screenshots)
This PR adds a deprecation warning for
livechat:saveCustomFieldmeteor method, as well as it adds an endpoint (livechat/custom-fields.save) to replace it.Issue(s)
CTZ-64
Steps to test or reproduce
Further comments
Tests will be implemented on this task
Summary by CodeRabbit