Skip to content

Conversation

@lucas-a-pelegrino
Copy link
Contributor

@lucas-a-pelegrino lucas-a-pelegrino commented Sep 17, 2025

Proposed changes (including videos or screenshots)

This PR adds a deprecation warning for livechat:saveCustomField meteor method, as well as it adds an endpoint (livechat/custom-fields.save) to replace it.

Issue(s)

CTZ-64

Steps to test or reproduce

Further comments

Tests will be implemented on this task

Summary by CodeRabbit

  • New Features
    • Added REST endpoints to create/update and delete Livechat custom fields, with input validation and clearer error responses. Returns the created/updated custom field. UI now uses the new save endpoint with a structured payload. Endpoints require authentication and Livechat Manager permission.
  • Deprecations
    • The legacy method livechat:saveCustomField is deprecated. Use livechat/custom-fields.save instead; a deprecation warning is logged when the old method is called.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 17, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2025

🦋 Changeset detected

Latest commit: b20bab8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/http-router Patch
@rocket.chat/models Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/livechat Patch
@rocket.chat/mock-providers Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/media-calls Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/core-typings Patch
@rocket.chat/apps Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 17, 2025

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 75b9402 and b20bab8.

📒 Files selected for processing (7)
  • .changeset/twelve-cougars-suffer.md (1 hunks)
  • apps/meteor/app/livechat/server/api/v1/customField.ts (2 hunks)
  • apps/meteor/app/livechat/server/methods/saveCustomField.ts (2 hunks)
  • apps/meteor/client/views/omnichannel/customFields/EditCustomFields.tsx (2 hunks)
  • apps/meteor/tests/e2e/utils/omnichannel/custom-field.ts (1 hunks)
  • apps/meteor/tests/end-to-end/api/livechat/00-rooms.ts (1 hunks)
  • packages/rest-typings/src/v1/omnichannel.ts (1 hunks)
 _______________________________________________________________________________
< FUZZY BUNNY: Finding Unresolved Zero-day Zingers, Bugs, Nasties, and Yuckies. >
 -------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/v7/CTZ-64

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.28%. Comparing base (72d9474) to head (b20bab8).
⚠️ Report is 17 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36971      +/-   ##
===========================================
- Coverage    67.34%   66.28%   -1.06%     
===========================================
  Files         3339     3393      +54     
  Lines       113205   115454    +2249     
  Branches     20532    21183     +651     
===========================================
+ Hits         76234    76532     +298     
- Misses       34361    36308    +1947     
- Partials      2610     2614       +4     
Flag Coverage Δ
e2e 56.91% <100.00%> (-0.03%) ⬇️
unit 71.26% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucas-a-pelegrino lucas-a-pelegrino added this to the 7.11.0 milestone Sep 17, 2025
@lucas-a-pelegrino lucas-a-pelegrino marked this pull request as ready for review September 22, 2025 19:54
@lucas-a-pelegrino lucas-a-pelegrino requested review from a team as code owners September 22, 2025 19:54
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On behalf of frontend, looks good!

@dougfabris dougfabris modified the milestones: 7.11.0, 7.12.0 Sep 24, 2025
@ggazzo ggazzo modified the milestones: 7.12.0, 7.11.0 Sep 24, 2025
@ggazzo ggazzo merged commit 90a1759 into develop Sep 24, 2025
50 of 52 checks passed
@ggazzo ggazzo deleted the chore/v7/CTZ-64 branch September 24, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants