chore!: removes livechat:removeAllClosedRooms deprecated method

[lucas-a-pelegrino]

Proposed changes (including videos or screenshots)

This PR removes the livechat:removeAllClosedRooms deprecated meteor method.

Issue(s)

CTZ-58

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Breaking Changes
  • Removed the deprecated Realtime API method livechat:removeAllClosedRooms — integrations relying on it will no longer work and must be updated.
• Chores
  • Published a major version to reflect and signal this breaking change.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: b32aa1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages

Name	Type
@rocket.chat/meteor	Major
@rocket.chat/core-typings	Major
@rocket.chat/rest-typings	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/http-router	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-contexts	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/federation-matrix	Patch
@rocket.chat/license	Patch
@rocket.chat/media-calls	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/omni-core-ee	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-video-conf	Major
@rocket.chat/ui-voip	Major
@rocket.chat/instance-status	Patch
@rocket.chat/omni-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

Removes the server-side Meteor method livechat:removeAllClosedRooms (implementation file deleted and import removed) and adds a changeset declaring a major version bump for @rocket.chat/meteor due to the breaking Realtime API removal.

Changes

Cohort / File(s)	Summary
Livechat method removal apps/meteor/app/livechat/server/methods/removeAllClosedRooms.ts, apps/meteor/app/livechat/server/index.ts	Deleted the server implementation and removed its import at startup, removing the livechat:removeAllClosedRooms Meteor method and associated server-side logic (permission checks, logging, room queries, batch removals).
Release metadata .changeset/neat-spoons-cover.md	Added a changeset declaring a major release for @rocket.chat/meteor that documents removal of the deprecated Realtime API method livechat:removeAllClosedRooms.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Client
  participant MeteorServer as Meteor Server
  participant LivechatRooms
  participant Remover as removeOmnichannelRoom

  rect rgb(240,248,255)
  note over Client,MeteorServer: Before change (existing flow)
  Client->>MeteorServer: DDP call: livechat:removeAllClosedRooms(departmentIds?)
  MeteorServer->>MeteorServer: check permission & apply restrictions
  MeteorServer->>LivechatRooms: findClosedRooms(...)
  LivechatRooms-->>MeteorServer: closed room IDs
  loop per room
    MeteorServer->>Remover: removeOmnichannelRoom(roomId)
    Remover-->>MeteorServer: removed
  end
  MeteorServer-->>Client: return countRemoved
  end

  rect rgb(255,245,238)
  note over Client,MeteorServer: After change (method removed)
  Client->>MeteorServer: DDP call: livechat:removeAllClosedRooms(...)
  MeteorServer-->>Client: method not found / no handler
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Review focus:
  • apps/meteor/app/livechat/server/methods/removeAllClosedRooms.ts (deleted logic)
  • apps/meteor/app/livechat/server/index.ts (import removal)
  • Search for any remaining callers or client-side expectations of the removed Meteor method.

Possibly related PRs

• chore: Adds deprecation warning on livechat:removeAllClosedRooms with new endpoint replacing it #36921 — touches the same livechat:removeAllClosedRooms functionality and introduces a replacement REST endpoint.

Suggested labels

stat: ready to merge

Suggested reviewers

• aleksandernsilva
• sampaiodiego

Poem

I hop through branches, whiskers keen,
A method gone, the logs serene.
Closed rooms once swept with one quick run,
Now quiet fields beneath the sun.
The rabbit cheers — a major bump, new fun. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	Linked issue CORE-1453 lacks specific coding requirements; unable to validate whether code changes meet requirements without detailed issue objectives.	Review the detailed requirements in CORE-1453 to verify all coding objectives are met by the changeset.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title clearly and specifically describes the main change: removal of the deprecated livechat:removeAllClosedRooms method.
Out of Scope Changes check	✅ Passed	All changes are directly related to removing the deprecated livechat:removeAllClosedRooms method: deletion of implementation file, removal of import, and addition of changeset declaration.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/v8/CTZ-58

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between aedabcd and b32aa1a.

📒 Files selected for processing (3)

• .changeset/neat-spoons-cover.md (1 hunks)
• apps/meteor/app/livechat/server/index.ts (0 hunks)
• apps/meteor/app/livechat/server/methods/removeAllClosedRooms.ts (0 hunks)

💤 Files with no reviewable changes (2)

• apps/meteor/app/livechat/server/methods/removeAllClosedRooms.ts
• apps/meteor/app/livechat/server/index.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• .changeset/neat-spoons-cover.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: 📦 Build Packages
• GitHub Check: CodeQL-Build
• GitHub Check: CodeQL-Build

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.changeset/neat-spoons-cover.md (1)

1-6: Remove remaining client calls to the removed Realtime method livechat:removeAllClosedRooms.

• Found references in clients:
  • apps/meteor/client/views/omnichannel/directory/chats/ChatsTable/ChatsTableFilter.tsx — line 16: useMethod('livechat:removeAllClosedRooms')
  • apps/meteor/client/views/omnichannel/currentChats/FilterByText.tsx — line 84: useMethod('livechat:removeAllClosedRooms')
• Action: remove or replace these calls and update ServerMethods/types, tests, and docs to match the API removal before merging.

🧹 Nitpick comments (1)

.changeset/neat-spoons-cover.md (1)

5-5: Strengthen the BREAKING note and add migration guidance.

Call it a “Meteor (DDP) method” for clarity, and provide a short migration note and deprecation reference to help integrators.

Apply:

-Removes deprecated Realtime API method: `livechat:removeAllClosedRooms`
+BREAKING: remove deprecated Meteor (DDP) method `livechat:removeAllClosedRooms`.
+
+Migration:
+- Remove any client calls to this method; it no longer exists as of 8.0.0.
+- Replace usage with the supported cleanup workflow (e.g., REST/retention APIs or an admin job), and link to docs/changelog.
+
+Refs: CTZ-58.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5467e46 and a45b692.

📒 Files selected for processing (3)

• .changeset/neat-spoons-cover.md (1 hunks)
• apps/meteor/app/livechat/server/index.ts (0 hunks)
• apps/meteor/app/livechat/server/methods/removeAllClosedRooms.ts (0 hunks)

💤 Files with no reviewable changes (2)

• apps/meteor/app/livechat/server/index.ts
• apps/meteor/app/livechat/server/methods/removeAllClosedRooms.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: 📦 Build Packages
• GitHub Check: CodeQL-Build
• GitHub Check: CodeQL-Build

🔇 Additional comments (1)

.changeset/neat-spoons-cover.md (1)

2-2: Verify '@rocket.chat/meteor' is the intended package in .changeset/neat-spoons-cover.md

No output from the prior script — run these from the repo root and paste outputs so I can confirm the changeset target matches an actual package name:

# show the changeset and config
sed -n '1,160p' .changeset/neat-spoons-cover.md || true
cat .changeset/config.json || true
jq -r '.packages[]?' .changeset/config.json 2>/dev/null || true

# list package names tracked in the repo (git) or fallback to find
git ls-files -- '**/package.json' -z | xargs -0 -n1 jq -r '.name // empty' | sort -u || true
find . -name package.json -not -path '*/node_modules/*' -print0 | xargs -0 -n1 jq -r '.name // empty' | sort -u || true

# search repo for the exact package string
rg -n --hidden --glob '!node_modules/**' '@rocket\.chat/meteor' || git grep -n '@rocket.chat/meteor' || true

If the package name is not present in the package.json list or differs from the monorepo's published package, update the changeset to the correct package name used by your publishing workflow.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.93%. Comparing base (8825a39) to head (b32aa1a).
⚠️ Report is 1 commits behind head on release-8.0.0.

Additional details and impacted files

@@              Coverage Diff               @@
##           release-8.0.0   #36931   +/-   ##
==============================================
  Coverage          70.92%   70.93%           
==============================================
  Files               3031     3031           
  Lines             104339   104339           
  Branches           18373    18372    -1     
==============================================
+ Hits               74003    74013   +10     
+ Misses             28398    28391    -7     
+ Partials            1938     1935    -3     

Flag	Coverage Δ
e2e	58.06% <ø> (+0.03%)	⬆️
unit	72.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The merge-base changed after approval.