-
Notifications
You must be signed in to change notification settings - Fork 13k
chore!: remove the ability to use role names as parameters on /api/v1/roles.* endpoints
#36896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 06dee7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.0.0 #36896 +/- ##
==============================================
Coverage 66.37% 66.38%
==============================================
Files 3312 3312
Lines 111671 111671
Branches 20940 20944 +4
==============================================
+ Hits 74121 74130 +9
+ Misses 34872 34864 -8
+ Partials 2678 2677 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (#36896)
…1/roles.*` endpoints (RocketChat#36896)
Proposed changes (including videos or screenshots)
Removes the deprecated
roleNameparameter from/api/v1/roles.addUserToRoleand/api/v1/roles.removeUserFromRoleRemoves the ability to pass a role name to the
roleparameter type from/api/v1/roles.getUsersInRoleIssue(s)
ARCH-1743
Steps to test or reproduce
Further comments