Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Sep 9, 2025

Proposed changes (including videos or screenshots)

Removes the deprecated roleName parameter from /api/v1/roles.addUserToRole and /api/v1/roles.removeUserFromRole

Removes the ability to pass a role name to the role parameter type from /api/v1/roles.getUsersInRole

Issue(s)

ARCH-1743

Steps to test or reproduce

Further comments

@MartinSchoeler MartinSchoeler added this to the 8.0.0 milestone Sep 9, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 9, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2025

🦋 Changeset detected

Latest commit: 06dee7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/rest-typings Major
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/http-router Patch
@rocket.chat/models Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/livechat Patch
@rocket.chat/mock-providers Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/core-typings Major
@rocket.chat/apps Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.38%. Comparing base (712e2f3) to head (06dee7c).
⚠️ Report is 5 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-8.0.0   #36896   +/-   ##
==============================================
  Coverage          66.37%   66.38%           
==============================================
  Files               3312     3312           
  Lines             111671   111671           
  Branches           20940    20944    +4     
==============================================
+ Hits               74121    74130    +9     
+ Misses             34872    34864    -8     
+ Partials            2678     2677    -1     
Flag Coverage Δ
e2e 58.24% <100.00%> (+<0.01%) ⬆️
unit 70.88% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review September 9, 2025 21:20
@MartinSchoeler MartinSchoeler requested review from a team as code owners September 9, 2025 21:20
@ggazzo ggazzo merged commit 4450305 into release-8.0.0 Sep 13, 2025
58 of 60 checks passed
@ggazzo ggazzo deleted the remove/roles-params branch September 13, 2025 02:23
ggazzo pushed a commit that referenced this pull request Sep 30, 2025
ggazzo pushed a commit that referenced this pull request Oct 3, 2025
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
ggazzo pushed a commit that referenced this pull request Nov 4, 2025
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
ggazzo pushed a commit that referenced this pull request Nov 6, 2025
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
ggazzo pushed a commit that referenced this pull request Nov 13, 2025
ggazzo pushed a commit that referenced this pull request Nov 18, 2025
ggazzo pushed a commit that referenced this pull request Dec 2, 2025
ggazzo pushed a commit that referenced this pull request Dec 9, 2025
ggazzo pushed a commit that referenced this pull request Dec 10, 2025
ggazzo pushed a commit that referenced this pull request Dec 15, 2025
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
dougfabris pushed a commit that referenced this pull request Dec 20, 2025
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants