-
Notifications
You must be signed in to change notification settings - Fork 13k
chore!: Remove deprecated rooms.upload endpoint
#36857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: cf2babe The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.0.0 #36857 +/- ##
=================================================
+ Coverage 66.37% 66.38% +0.01%
=================================================
Files 3312 3312
Lines 111671 111671
Branches 20940 20922 -18
=================================================
+ Hits 74121 74134 +13
+ Misses 34872 34861 -11
+ Partials 2678 2676 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
rooms.media endpointrooms.upload endpoint
e19fae0 to
0d1c2a5
Compare
14d0c4c to
90546ad
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Comment |
juliajforesti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is CustomFields being contemplated on the rooms.media endpoint?
check the api test failing
juliajforesti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Proposed changes (including videos or screenshots)
Removes the deprecated
/api/v1/rooms.uploadendpointIssue(s)
ARCH-1744
Steps to test or reproduce
Further comments