Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Sep 2, 2025

Proposed changes (including videos or screenshots)

Removes the deprecated /api/v1/rooms.upload endpoint

Issue(s)

ARCH-1744

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 2, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2025

🦋 Changeset detected

Latest commit: cf2babe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/rest-typings Major
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/http-router Patch
@rocket.chat/models Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/livechat Patch
@rocket.chat/mock-providers Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/core-typings Major
@rocket.chat/apps Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MartinSchoeler MartinSchoeler added this to the 8.0.0 milestone Sep 2, 2025
@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.38%. Comparing base (712e2f3) to head (cf2babe).
⚠️ Report is 4 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #36857      +/-   ##
=================================================
+ Coverage          66.37%   66.38%   +0.01%     
=================================================
  Files               3312     3312              
  Lines             111671   111671              
  Branches           20940    20922      -18     
=================================================
+ Hits               74121    74134      +13     
+ Misses             34872    34861      -11     
+ Partials            2678     2676       -2     
Flag Coverage Δ
e2e 58.28% <ø> (+0.04%) ⬆️
unit 70.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler changed the title chore!: Remove deprecated rooms.media endpoint chore!: Remove deprecated rooms.upload endpoint Sep 4, 2025
@ggazzo ggazzo force-pushed the release-8.0.0 branch 4 times, most recently from e19fae0 to 0d1c2a5 Compare September 4, 2025 19:18
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove/rooms.upload

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@juliajforesti juliajforesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is CustomFields being contemplated on the rooms.media endpoint?
check the api test failing

@MartinSchoeler MartinSchoeler marked this pull request as ready for review September 11, 2025 14:57
@MartinSchoeler MartinSchoeler requested review from a team as code owners September 11, 2025 14:57
Copy link
Contributor

@juliajforesti juliajforesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Sep 11, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2025
@ggazzo ggazzo merged commit 1b782a9 into release-8.0.0 Sep 13, 2025
41 checks passed
@ggazzo ggazzo deleted the remove/rooms.upload branch September 13, 2025 02:22
ggazzo pushed a commit that referenced this pull request Sep 30, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Oct 3, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Nov 4, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Nov 6, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Nov 13, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Nov 18, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 2, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 9, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 10, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 15, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
dougfabris pushed a commit that referenced this pull request Dec 20, 2025
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants