fix: less strict slash command registration condition #36855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f4dfac1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like this PR is ready to merge! 🎉 |
d-gubert
force-pushed
the
fix/apps-slashcommand-registration
branch
from
c1a1ddc to
168aa7b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36855 +/- ##
===========================================
+ Coverage 66.17% 66.24% +0.06%
===========================================
Files 3339 3340 +1
Lines 113419 113575 +156
Branches 21146 21157 +11
===========================================
+ Hits 75059 75240 +181
+ Misses 35676 35650 -26
- Partials 2684 2685 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
d-gubert
force-pushed
the
fix/apps-slashcommand-registration
branch
3 times, most recently
from
761f228 to
a3d96c0
Compare
d-gubert
force-pushed
the
fix/apps-slashcommand-registration
branch
from
152a02e to
7f1e1f4
Compare
tassoevan
requested changes
Sep 3, 2025
d-gubert
force-pushed
the
fix/apps-slashcommand-registration
branch
from
7f1e1f4 to
6004f51
Compare
d-gubert
force-pushed
the
fix/apps-slashcommand-registration
branch
from
6004f51 to
f4dfac1
Compare
ggazzo
approved these changes
Sep 5, 2025
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Member
|
/patch |
Contributor
|
Pull request #37028 added to Project: "Patch 7.10.1" |
d-gubert
added a commit
that referenced
this pull request
Sep 22, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR modifies the app slash command registration method to improve the lifecycle management of slash commands during app initialization, disabling, and purging operations.
Changes Overview
useAppSlashCommands.ts)• Removed command/disabled from the event listener array - this prevents unnecessary command cleanup when apps are disabled, allowing commands to remain available during temporary app states
AppManager.ts)• Moved command registration from app enabling to app initialization phase
• Modified app disabling process to preserve slash commands (keepSlashcommands: true)
• Only remove commands upon uninstalling
Issue(s)
Steps to test or reproduce
Further comments
ARCH-1787