Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Sep 1, 2025

Proposed changes (including videos or screenshots)

It moves the client version of the settings API to the client/ directory.

Issue(s)

ARCH-1794

Steps to test or reproduce

Further comments

This is part of the effort of isolating client code, since modules under app/*/ tend to be isomorphic by relying over Meteor APIs.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 1, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2025

⚠️ No Changeset found

Latest commit: d035509

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 50.54945% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.33%. Comparing base (5010b36) to head (d035509).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36844      +/-   ##
===========================================
+ Coverage    66.32%   66.33%   +0.01%     
===========================================
  Files         3322     3322              
  Lines       111287   111249      -38     
  Branches     21083    21076       -7     
===========================================
- Hits         73813    73799      -14     
+ Misses       34788    34758      -30     
- Partials      2686     2692       +6     
Flag Coverage Δ
e2e 57.66% <50.54%> (+0.01%) ⬆️
unit 71.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan force-pushed the chore/settings branch 2 times, most recently from ce9be37 to 00ab2fd Compare September 1, 2025 17:25
@tassoevan tassoevan added this to the 7.11.0 milestone Sep 1, 2025
@tassoevan tassoevan marked this pull request as ready for review September 1, 2025 19:01
@tassoevan tassoevan requested review from a team as code owners September 1, 2025 19:01
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Sep 2, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 2, 2025
@ggazzo ggazzo merged commit 078362e into develop Sep 2, 2025
87 of 89 checks passed
@ggazzo ggazzo deleted the chore/settings branch September 2, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants