-
Notifications
You must be signed in to change notification settings - Fork 13.1k
chore(settings): Move settings client API
#36844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
0708d5d to
74d9958
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36844 +/- ##
===========================================
+ Coverage 66.32% 66.33% +0.01%
===========================================
Files 3322 3322
Lines 111287 111249 -38
Branches 21083 21076 -7
===========================================
- Hits 73813 73799 -14
+ Misses 34788 34758 -30
- Partials 2686 2692 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ce9be37 to
00ab2fd
Compare
96959c8 to
d035509
Compare
Proposed changes (including videos or screenshots)
It moves the client version of the
settingsAPI to theclient/directory.Issue(s)
ARCH-1794
Steps to test or reproduce
Further comments
This is part of the effort of isolating client code, since modules under
app/*/tend to be isomorphic by relying over Meteor APIs.