Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 26, 2025

Proposed changes (including videos or screenshots)

Relates to: #36776

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 26, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2025

⚠️ No Changeset found

Latest commit: 8574bd7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: Martin <martin.schoeler@rocket.chat>
@dougfabris dougfabris added this to the 7.11.0 milestone Aug 26, 2025
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.14%. Comparing base (e497d94) to head (8574bd7).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36804      +/-   ##
===========================================
+ Coverage    66.12%   66.14%   +0.01%     
===========================================
  Files         3302     3303       +1     
  Lines       110951   110994      +43     
  Branches     21044    21047       +3     
===========================================
+ Hits         73369    73412      +43     
+ Misses       34915    34907       -8     
- Partials      2667     2675       +8     
Flag Coverage Δ
e2e 57.30% <100.00%> (+0.05%) ⬆️
unit 71.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review August 27, 2025 02:36
@dougfabris dougfabris requested a review from a team as a code owner August 27, 2025 02:36
@MartinSchoeler MartinSchoeler self-requested a review August 27, 2025 12:44
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Aug 27, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 27, 2025
@kodiakhq kodiakhq bot merged commit 4f1e315 into develop Aug 27, 2025
85 of 87 checks passed
@kodiakhq kodiakhq bot deleted the test/priorities-row-translation branch August 27, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants