Skip to content

Conversation

@abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Aug 25, 2025

Proposed changes (including videos or screenshots)

Updates the E2EE hint shown when creating a broadcast channel. The previous hint stated “Not available for broadcast channels,” which is incorrect. The hint is removed/updated so the E2EE toggle remains available and the message no longer contradicts the actual capability.

Issue(s)

Steps to test or reproduce

  1. Open the Create new channel modal.
  2. Enable Broadcast.
  3. Verify the E2EE toggle remains available.
  4. Confirm the hint no longer states “Not available for broadcast channels” (standard E2EE description or no hint is shown).

Further comments

CORE-1325

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Copilot AI review requested due to automatic review settings August 25, 2025 20:17
@abhinavkrin abhinavkrin requested a review from a team as a code owner August 25, 2025 20:17
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 25, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2025

⚠️ No Changeset found

Latest commit: e729b40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses a regression where the E2EE (End-to-End Encryption) availability hint incorrectly stated "Not available for broadcast channels" when creating broadcast channels. The changes ensure that E2EE remains available for broadcast channels by updating the hint logic and removing the incorrect restriction message.

  • Updated useEncryptedRoomDescription hook to make broadcast parameter optional and only show restriction for teams
  • Removed broadcast parameter from calls to getEncryptedHint in channel creation modals
  • Added comprehensive test coverage for the updated hook behavior

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
useEncryptedRoomDescription.tsx (sidebar) Makes broadcast optional and adds TODO comment for teams restriction
useEncryptedRoomDescription.tsx (NavBarV2) Same changes as sidebar version for consistency
CreateChannelModal.tsx (sidebar) Removes broadcast parameter from hint generation
CreateChannelModal.tsx (NavBarV2) Same change as sidebar version for consistency
useEncryptedRoomDescription.spec.tsx Adds comprehensive test suite for both hook versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.99%. Comparing base (4fc1b60) to head (e729b40).
⚠️ Report is 1 commits behind head on release-7.10.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-7.10.0   #36792      +/-   ##
==================================================
+ Coverage           65.97%   65.99%   +0.01%     
==================================================
  Files                3285     3285              
  Lines              110045   110055      +10     
  Branches            20837    20845       +8     
==================================================
+ Hits                72607    72630      +23     
+ Misses              34765    34750      -15     
- Partials             2673     2675       +2     
Flag Coverage Δ
e2e 57.16% <33.33%> (+<0.01%) ⬆️
unit 71.41% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added this to the 7.10.0 milestone Aug 26, 2025
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Aug 26, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 26, 2025
@MartinSchoeler MartinSchoeler added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Aug 26, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 26, 2025
@kodiakhq kodiakhq bot merged commit 4171d3b into release-7.10.0 Aug 26, 2025
57 checks passed
@kodiakhq kodiakhq bot deleted the regression/correct-e2ee-hint-for-broadcast-channels branch August 26, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants