-
Notifications
You must be signed in to change notification settings - Fork 13k
regression: correct E2EE availability hint for broadcast channels #36792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: correct E2EE availability hint for broadcast channels #36792
Conversation
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
|
Looks like this PR is ready to merge! 🎉 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request addresses a regression where the E2EE (End-to-End Encryption) availability hint incorrectly stated "Not available for broadcast channels" when creating broadcast channels. The changes ensure that E2EE remains available for broadcast channels by updating the hint logic and removing the incorrect restriction message.
- Updated
useEncryptedRoomDescriptionhook to make broadcast parameter optional and only show restriction for teams - Removed broadcast parameter from calls to
getEncryptedHintin channel creation modals - Added comprehensive test coverage for the updated hook behavior
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| useEncryptedRoomDescription.tsx (sidebar) | Makes broadcast optional and adds TODO comment for teams restriction |
| useEncryptedRoomDescription.tsx (NavBarV2) | Same changes as sidebar version for consistency |
| CreateChannelModal.tsx (sidebar) | Removes broadcast parameter from hint generation |
| CreateChannelModal.tsx (NavBarV2) | Same change as sidebar version for consistency |
| useEncryptedRoomDescription.spec.tsx | Adds comprehensive test suite for both hook versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-7.10.0 #36792 +/- ##
==================================================
+ Coverage 65.97% 65.99% +0.01%
==================================================
Files 3285 3285
Lines 110045 110055 +10
Branches 20837 20845 +8
==================================================
+ Hits 72607 72630 +23
+ Misses 34765 34750 -15
- Partials 2673 2675 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Updates the E2EE hint shown when creating a broadcast channel. The previous hint stated “Not available for broadcast channels,” which is incorrect. The hint is removed/updated so the E2EE toggle remains available and the message no longer contradicts the actual capability.
Issue(s)
Steps to test or reproduce
Further comments
CORE-1325