-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: adds kebab menu to contact center and delete contact item #36791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36791 +/- ##
===========================================
+ Coverage 66.27% 66.29% +0.01%
===========================================
Files 3326 3328 +2
Lines 111579 111614 +35
Branches 21160 21164 +4
===========================================
+ Hits 73953 73996 +43
+ Misses 34926 34919 -7
+ Partials 2700 2699 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
apps/meteor/client/views/omnichannel/directory/contacts/ContactTableRow.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/omnichannel/directory/contacts/RemoveContactModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/omnichannel/directory/contacts/RemoveContactModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/omnichannel/directory/contacts/RemoveContactModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/omnichannel/omnichannel-contact-center.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/omnichannel/omnichannel-contact-center.spec.ts
Outdated
Show resolved
Hide resolved
13e85ba to
e1be10d
Compare
e1be10d to
c48a175
Compare
…g removal confirmation
apps/meteor/client/views/omnichannel/directory/contacts/RemoveContactModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/omnichannel/omnichannel-contact-center.spec.ts
Outdated
Show resolved
Hide resolved
aleksandernsilva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the following error when trying to delete one of my contacts:
{"success":false,"error":"error-contact-has-open-rooms"}
Why does not having open rooms prevent me from deleting the contact?
Proposed changes (including videos or screenshots)
This PR adds a menu in the contact center for each contact in the table, allowing users to delete them one by one.
Issue(s)
CTZ-173
Steps to test or reproduce
Further comments
This PR pairs with #36589 which covers the BE part of the task.