Skip to content

Conversation

@lucas-a-pelegrino
Copy link
Contributor

@lucas-a-pelegrino lucas-a-pelegrino commented Aug 25, 2025

Proposed changes (including videos or screenshots)

This PR adds a menu in the contact center for each contact in the table, allowing users to delete them one by one.

Issue(s)

CTZ-173

Steps to test or reproduce

  1. Navigate to Contact Center;
  2. Find the contact you want to delete;
  3. Open the menu in the end of the row., click it;
  4. A modal should show, with a message and a input to confirm the contact removal;
  5. Follow the instructions in the modal;
  6. Delete contact.

Further comments

This PR pairs with #36589 which covers the BE part of the task.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 25, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2025

⚠️ No Changeset found

Latest commit: 5e60e26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.29%. Comparing base (9825c8d) to head (5e60e26).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36791      +/-   ##
===========================================
+ Coverage    66.27%   66.29%   +0.01%     
===========================================
  Files         3326     3328       +2     
  Lines       111579   111614      +35     
  Branches     21160    21164       +4     
===========================================
+ Hits         73953    73996      +43     
+ Misses       34926    34919       -7     
+ Partials      2700     2699       -1     
Flag Coverage Δ
e2e 57.63% <88.57%> (+0.03%) ⬆️
unit 71.58% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucas-a-pelegrino lucas-a-pelegrino marked this pull request as ready for review August 26, 2025 18:59
@lucas-a-pelegrino lucas-a-pelegrino requested a review from a team as a code owner August 26, 2025 18:59
Copy link
Contributor

@aleksandernsilva aleksandernsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the following error when trying to delete one of my contacts:
{"success":false,"error":"error-contact-has-open-rooms"}

Why does not having open rooms prevent me from deleting the contact?

@lucas-a-pelegrino lucas-a-pelegrino added this to the 7.11.0 milestone Aug 29, 2025
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Sep 1, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 1, 2025
@kodiakhq kodiakhq bot merged commit d999d45 into develop Sep 1, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the feat/CTZ-173-FE branch September 1, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants