fix: Resend welcome email without placeholders #36772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 2091885 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36772 +/- ##
========================================
Coverage 66.13% 66.14%
========================================
Files 3303 3303
Lines 110994 110994
Branches 21047 21050 +3
========================================
+ Hits 73410 73417 +7
+ Misses 34911 34904 -7
Partials 2673 2673
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
abhinavkrin
requested changes
Aug 22, 2025
…t/Rocket.Chat into fix/welcome-email-placeholders
dougfabris
requested changes
Aug 27, 2025
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
What do you think about adding tests for these errors you introduced for the users.sendWelcomeEmail route
Contributor
Author
We already had an API test for it |
abhinavkrin
requested changes
Aug 27, 2025
tiagoevanp
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes an issue with the welcome email resend functionality, ensuring that no unresolved placeholders (e.g., [name], [email]) are left in the email content. When a welcome email is resent, all placeholders are now properly replaced or removed.
Previously, resending the welcome email could result in messages containing raw placeholders, leading to confusing or unprofessional communication with users.
Issue(s)
Steps to test or reproduce
Trigger the welcome email flow by creating a new user.
Resend the welcome email from the admin panel.
Verify that the email contains no literal placeholders (all variables should be correctly filled in or omitted).
Further comments
SUP-838