-
Notifications
You must be signed in to change notification settings - Fork 13k
feat(desktop-api): @rocket.chat/desktop-api package
#36770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 2e2cd8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-7.10.0 #36770 +/- ##
==================================================
+ Coverage 65.94% 65.95% +0.01%
==================================================
Files 3285 3285
Lines 110051 110051
Branches 20838 20841 +3
==================================================
+ Hits 72576 72588 +12
+ Misses 34795 34786 -9
+ Partials 2680 2677 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
85cb821 to
2e2cd8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new package @rocket.chat/desktop-api that provides TypeScript interfaces and types for interfacing with the desktop app's injected context. The package exposes type definitions for server information, badge states, theme appearance, video chat windows, and Outlook events integration.
- Creates a new npm package with proper TypeScript configuration and build setup
- Exports type definitions for desktop app integration including
IRocketChatDesktopinterface - Fixes a naming inconsistency in the video chat window options type
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/desktop-api/package.json | Package configuration with build scripts and dependencies |
| packages/desktop-api/tsconfig.json | TypeScript compilation configuration targeting ES2024 |
| packages/desktop-api/src/index.ts | Type definitions and interface for desktop app integration |
| packages/desktop-api/.eslintrc.json | ESLint configuration extending project standards |
| apps/meteor/package.json | Adds workspace dependency on the new desktop-api package |
| .changeset/tough-students-remain.md | Changeset documentation for the new package |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Proposed changes (including videos or screenshots)
It adds a new package (
@rocket.chat/desktop-api) to interface the desktop app's injected context.Issue(s)
ARCH-1782
Steps to test or reproduce
Further comments
It should be published on npm registry, being available for the desktop app source code.