Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Aug 21, 2025

Proposed changes (including videos or screenshots)

It adds a new package (@rocket.chat/desktop-api) to interface the desktop app's injected context.

Issue(s)

ARCH-1782

Steps to test or reproduce

Further comments

It should be published on npm registry, being available for the desktop app source code.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2025

🦋 Changeset detected

Latest commit: 2e2cd8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/desktop-api Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tassoevan tassoevan added this to the 7.11.0 milestone Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.95%. Comparing base (3444158) to head (2e2cd8b).
⚠️ Report is 2 commits behind head on release-7.10.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-7.10.0   #36770      +/-   ##
==================================================
+ Coverage           65.94%   65.95%   +0.01%     
==================================================
  Files                3285     3285              
  Lines              110051   110051              
  Branches            20838    20841       +3     
==================================================
+ Hits                72576    72588      +12     
+ Misses              34795    34786       -9     
+ Partials             2680     2677       -3     
Flag Coverage Δ
e2e 57.15% <ø> (+0.01%) ⬆️
unit 71.36% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan marked this pull request as ready for review August 22, 2025 01:25
@tassoevan tassoevan requested a review from a team as a code owner August 22, 2025 01:25
@ggazzo ggazzo changed the base branch from develop to release-7.10.0 August 22, 2025 17:40
@ggazzo ggazzo requested review from a team as code owners August 22, 2025 17:40
@ggazzo ggazzo modified the milestones: 7.11.0, 7.10.0 Aug 22, 2025
Copilot AI review requested due to automatic review settings August 22, 2025 17:41
@ggazzo ggazzo force-pushed the feat/rocketchat-desktop-api branch from 85cb821 to 2e2cd8b Compare August 22, 2025 17:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new package @rocket.chat/desktop-api that provides TypeScript interfaces and types for interfacing with the desktop app's injected context. The package exposes type definitions for server information, badge states, theme appearance, video chat windows, and Outlook events integration.

  • Creates a new npm package with proper TypeScript configuration and build setup
  • Exports type definitions for desktop app integration including IRocketChatDesktop interface
  • Fixes a naming inconsistency in the video chat window options type

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/desktop-api/package.json Package configuration with build scripts and dependencies
packages/desktop-api/tsconfig.json TypeScript compilation configuration targeting ES2024
packages/desktop-api/src/index.ts Type definitions and interface for desktop app integration
packages/desktop-api/.eslintrc.json ESLint configuration extending project standards
apps/meteor/package.json Adds workspace dependency on the new desktop-api package
.changeset/tough-students-remain.md Changeset documentation for the new package

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 22, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 22, 2025
@ggazzo ggazzo merged commit ad2d47e into release-7.10.0 Aug 22, 2025
42 of 43 checks passed
@ggazzo ggazzo deleted the feat/rocketchat-desktop-api branch August 22, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants