Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Aug 21, 2025

Proposed changes (including videos or screenshots)

It correctly fails initialization of CachedStore instances i.e. mark them as ready despite errors. It prevents suspend-and-remount loops over SettingsProvider.

Issue(s)

ARCH-1781

Steps to test or reproduce

Further comments

This is critical for older versions of the desktop app, since they miss modern JavaScript features like Set.prototype.difference.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@tassoevan tassoevan force-pushed the regression/older-desktop-apps branch from e3da1e9 to 7ed8d41 Compare August 21, 2025 03:00
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2025

⚠️ No Changeset found

Latest commit: 7ed8d41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.10%. Comparing base (6e009b1) to head (7ed8d41).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36764      +/-   ##
===========================================
+ Coverage    66.08%   66.10%   +0.02%     
===========================================
  Files         3293     3293              
  Lines       110664   110661       -3     
  Branches     20994    21002       +8     
===========================================
+ Hits         73129    73156      +27     
+ Misses       34865    34836      -29     
+ Partials      2670     2669       -1     
Flag Coverage Δ
e2e 57.26% <100.00%> (-0.05%) ⬇️
unit 71.45% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan added this to the 7.10.0 milestone Aug 21, 2025
@tassoevan tassoevan marked this pull request as ready for review August 21, 2025 14:09
@tassoevan tassoevan requested a review from a team as a code owner August 21, 2025 14:09
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2025
@ggazzo ggazzo merged commit ae48139 into develop Aug 21, 2025
52 checks passed
@ggazzo ggazzo deleted the regression/older-desktop-apps branch August 21, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants