fix(desktop-app): Handle failure in CachedStore initialization
#36764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
It correctly fails initialization of
CachedStoreinstances i.e. mark them as ready despite errors. It prevents suspend-and-remount loops overSettingsProvider.Issue(s)
ARCH-1781
Steps to test or reproduce
Further comments
This is critical for older versions of the desktop app, since they miss modern JavaScript features like
Set.prototype.difference.