-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Intermittent error "Cannot read properties of undefined" when editing messages #36745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 17eb9cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36745 +/- ##
===========================================
+ Coverage 66.13% 66.15% +0.01%
===========================================
Files 3303 3304 +1
Lines 110998 111027 +29
Branches 21051 21047 -4
===========================================
+ Hits 73411 73446 +35
+ Misses 34912 34909 -3
+ Partials 2675 2672 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…update-message-weird-error
…t/Rocket.Chat into fix/update-message-weird-error
…update-message-weird-error
441b7dd to
8045164
Compare
8045164 to
fc81cbb
Compare
Proposed changes (including videos or screenshots)
This PR addresses a rare but disruptive issue where users encounter an error when attempting to edit their own messages. Specifically, the code attempts to read value from a race condition, resulting in an uncaught exception that dispatch a toast message with an error.
The solution provided is to apply "mutex" technique that is a synchronization primitive to protect shared resources from simultaneous access by multiple processes.
Issue(s)
Steps to test or reproduce
Further comments
CORE-895