Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Aug 19, 2025

Proposed changes (including videos or screenshots)

This PR addresses a rare but disruptive issue where users encounter an error when attempting to edit their own messages. Specifically, the code attempts to read value from a race condition, resulting in an uncaught exception that dispatch a toast message with an error.

The solution provided is to apply "mutex" technique that is a synchronization primitive to protect shared resources from simultaneous access by multiple processes.

Issue(s)

Steps to test or reproduce

Further comments

CORE-895

@tiagoevanp tiagoevanp added this to the 7.10.0 milestone Aug 19, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 19, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2025

🦋 Changeset detected

Latest commit: 17eb9cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 72.63158% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.15%. Comparing base (3825afa) to head (17eb9cb).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36745      +/-   ##
===========================================
+ Coverage    66.13%   66.15%   +0.01%     
===========================================
  Files         3303     3304       +1     
  Lines       110998   111027      +29     
  Branches     21051    21047       -4     
===========================================
+ Hits         73411    73446      +35     
+ Misses       34912    34909       -3     
+ Partials      2675     2672       -3     
Flag Coverage Δ
e2e 57.32% <72.63%> (+0.05%) ⬆️
unit 71.48% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tiagoevanp tiagoevanp marked this pull request as ready for review August 19, 2025 11:57
@tiagoevanp tiagoevanp requested a review from a team as a code owner August 19, 2025 11:57
abhinavkrin
abhinavkrin previously approved these changes Aug 19, 2025
@tiagoevanp tiagoevanp marked this pull request as draft August 19, 2025 16:16
@scuciatto scuciatto removed this from the 7.10.0 milestone Aug 19, 2025
@tiagoevanp tiagoevanp marked this pull request as ready for review August 21, 2025 18:23
@tiagoevanp tiagoevanp added this to the 7.11.0 milestone Aug 21, 2025
tassoevan
tassoevan previously approved these changes Aug 27, 2025
@tiagoevanp tiagoevanp force-pushed the fix/update-message-weird-error branch from 441b7dd to 8045164 Compare August 28, 2025 13:55
@tiagoevanp tiagoevanp force-pushed the fix/update-message-weird-error branch from 8045164 to fc81cbb Compare August 28, 2025 14:59
@tiagoevanp tiagoevanp added the stat: QA assured Means it has been tested and approved by a company insider label Aug 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 28, 2025
@kodiakhq kodiakhq bot merged commit be2d630 into develop Aug 28, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/update-message-weird-error branch August 28, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants