Skip to content

Conversation

@sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 15, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2025

⚠️ No Changeset found

Latest commit: 1de36b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sampaiodiego sampaiodiego force-pushed the chore-move-register-guest-omni-core branch from 0d95699 to 8e4d85e Compare August 18, 2025 12:54
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.10%. Comparing base (d76a557) to head (1de36b4).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36724      +/-   ##
===========================================
+ Coverage    66.01%   66.10%   +0.09%     
===========================================
  Files         3268     3293      +25     
  Lines       109853   110658     +805     
  Branches     20791    20999     +208     
===========================================
+ Hits         72515    73146     +631     
- Misses       34671    34845     +174     
  Partials      2667     2667              
Flag Coverage Δ
e2e 57.30% <ø> (+<0.01%) ⬆️
unit 71.42% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sampaiodiego sampaiodiego force-pushed the chore-move-register-guest-omni-core branch 2 times, most recently from 595e437 to e7ad35e Compare August 19, 2025 14:08
KevLehman
KevLehman previously approved these changes Aug 19, 2025
@sampaiodiego sampaiodiego force-pushed the chore-move-register-guest-omni-core branch from e7ad35e to ef68b07 Compare August 20, 2025 14:31
@sampaiodiego sampaiodiego marked this pull request as ready for review August 20, 2025 14:32
@sampaiodiego sampaiodiego requested review from a team as code owners August 20, 2025 14:32
@sampaiodiego sampaiodiego force-pushed the chore-move-register-guest-omni-core branch 3 times, most recently from ca06cd3 to e6c3d91 Compare August 20, 2025 19:54
KevLehman
KevLehman previously approved these changes Aug 20, 2025
d-gubert
d-gubert previously approved these changes Aug 20, 2025
@sampaiodiego sampaiodiego dismissed stale reviews from d-gubert and KevLehman via 8f79f6e August 20, 2025 22:33
@sampaiodiego sampaiodiego force-pushed the chore-move-register-guest-omni-core branch from 8f79f6e to 4a39b1e Compare August 20, 2025 22:33
d-gubert
d-gubert previously approved these changes Aug 20, 2025
KevLehman
KevLehman previously approved these changes Aug 20, 2025
@sampaiodiego sampaiodiego dismissed stale reviews from KevLehman and d-gubert via 1de36b4 August 20, 2025 23:03
@sampaiodiego sampaiodiego force-pushed the chore-move-register-guest-omni-core branch from 4a39b1e to 1de36b4 Compare August 20, 2025 23:03
@sampaiodiego sampaiodiego modified the milestone: 7.10.0 Aug 21, 2025
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Aug 21, 2025
@sampaiodiego sampaiodiego merged commit 34db122 into develop Aug 21, 2025
70 of 72 checks passed
@sampaiodiego sampaiodiego deleted the chore-move-register-guest-omni-core branch August 21, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants