Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Aug 13, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-221

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 13, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2025

⚠️ No Changeset found

Latest commit: ff5de95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.28%. Comparing base (1575089) to head (ff5de95).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36709   +/-   ##
========================================
  Coverage    66.27%   66.28%           
========================================
  Files         3325     3326    +1     
  Lines       111544   111579   +35     
  Branches     21160    21163    +3     
========================================
+ Hits         73929    73960   +31     
- Misses       34913    34921    +8     
+ Partials      2702     2698    -4     
Flag Coverage Δ
e2e 57.60% <ø> (+0.02%) ⬆️
unit 71.57% <96.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36709/

Built to branch gh-pages at 2025-08-14 19:23 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@KevLehman KevLehman force-pushed the chore/permissions-and-validations branch from 0e7abb6 to 3595401 Compare August 18, 2025 20:06
@KevLehman KevLehman added this to the 7.11.0 milestone Aug 25, 2025
@KevLehman KevLehman marked this pull request as ready for review August 28, 2025 21:56
@KevLehman KevLehman requested review from a team as code owners August 28, 2025 21:56
@KevLehman KevLehman requested a review from Copilot August 29, 2025 01:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements permissions and validations for outbound messaging endpoints. It introduces permission-based access controls for sending outbound messages and validates agent/department assignments based on user permissions.

  • Adds four new permission types for outbound messaging capabilities with granular control over agent assignment
  • Implements validation logic to ensure users can only assign agents/departments according to their permission level
  • Extends outbound message interfaces to include optional agent and department assignment fields

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/i18n/src/locales/en.i18n.json Adds translation keys for the new outbound messaging permissions
packages/core-typings/src/omnichannel/outbound.ts Extends IOutboundMessage interface with optional departmentId and agentId fields
packages/apps-engine/src/definition/outboundComunication/IOutboundMessage.ts Extends IOutboundMessage interface with optional agentId and departmentId fields
ee/packages/omni-core-ee/src/outbound-communication/validators/canSendMessage.ts Implements validation logic for outbound message permissions and agent/department assignments
ee/packages/omni-core-ee/src/outbound-communication/validators/canSendMessage.spec.ts Comprehensive test suite for the validation functions
ee/packages/omni-core-ee/src/outbound-communication/index.ts Exports validation functions from the outbound communication module
ee/packages/omni-core-ee/src/index.ts Exports outbound communication functionality
apps/meteor/ee/app/livechat-enterprise/server/permissions.ts Defines the new outbound messaging permissions and their role assignments
apps/meteor/ee/app/livechat-enterprise/server/outboundcomms/rest.ts Updates REST schema to include agentId and departmentId parameters
apps/meteor/ee/app/livechat-enterprise/server/api/outbound.ts Integrates permission checks and validation into the outbound messaging API endpoints

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Aug 29, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 29, 2025
@kodiakhq kodiakhq bot merged commit 9825c8d into develop Sep 1, 2025
85 of 87 checks passed
@kodiakhq kodiakhq bot deleted the chore/permissions-and-validations branch September 1, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants