fix: wrong scroll position when switching DMs #36662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 091f1a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36662 +/- ##
========================================
Coverage 65.70% 65.71%
========================================
Files 3199 3199
Lines 106892 106896 +4
Branches 20343 20341 -2
========================================
+ Hits 70232 70244 +12
+ Misses 34015 34008 -7
+ Partials 2645 2644 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ggazzo
approved these changes
Aug 8, 2025
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue that caused the
useRestoreScrollPositionhook to not be at bottom whenatBottom = true. My guess is that the scrolling operation for on bottom was being done someplace else, but it was removed on a refactor.Proposed changes (including videos or screenshots)
Issue(s)
CORE-1187
Steps to test or reproduce
Open a direct message (DM A) with any user, that have enough messages to scroll. Keep the scroll at the bottom of the page
Navigate to another direct message (DM B) with a different user.
In DM B, manually scroll up to locate an older message.
return to DM A by clicking on it in the sidebar.
Observe the scroll position in DM A.
Further comments