Skip to content

refactor: fix ConvertToRoute for POST requests missing body and test to prove it#36660

Closed
ahmed-n-abdeltwab wants to merge 5 commits into
RocketChat:developfrom
ahmed-n-abdeltwab:fix/convert-to-empty-post-route
Closed

refactor: fix ConvertToRoute for POST requests missing body and test to prove it#36660
ahmed-n-abdeltwab wants to merge 5 commits into
RocketChat:developfrom
ahmed-n-abdeltwab:fix/convert-to-empty-post-route

fix add a good test response

b606353
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 9, 2025 in 0s

62.90% (-2.88%) compared to ab5bf99

View this Pull Request on Codecov

62.90% (-2.88%) compared to ab5bf99

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.90%. Comparing base (ab5bf99) to head (b606353).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36660      +/-   ##
===========================================
- Coverage    65.77%   62.90%   -2.88%     
===========================================
  Files         3232     2902     -330     
  Lines       108119   102654    -5465     
  Branches     20582    19286    -1296     
===========================================
- Hits         71116    64571    -6545     
- Misses       34342    35958    +1616     
+ Partials      2661     2125     -536     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.