Skip to content

fix: messages redaction echo #36633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ricardogarim merged 1 commit into from
Aug 6, 2025
Merged

fix: messages redaction echo #36633

ricardogarim merged 1 commit into from
Aug 6, 2025

Conversation

@ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Aug 5, 2025

this PR fixes a bug in the redaction flow from Rocket.Chat to Matrix, where isEchoMessage was mistakenly dropping redaction events before they were processed.

with this fix, redactions now work correctly in both directions (Rocket.Chat ↔ Matrix), including for thread messages.

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2025

⚠️ No Changeset found

Latest commit: 457ebaf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ricardogarim ricardogarim marked this pull request as ready for review August 5, 2025 23:56
@ricardogarim
Copy link
Contributor Author

ricardogarim commented Aug 6, 2025

lgtm! tested and merged into the feature branch :)

@ricardogarim ricardogarim merged commit 1ff6cd1 into feat/federation Aug 6, 2025
27 of 29 checks passed
@ricardogarim ricardogarim deleted the fix/messages-redaction-echo branch August 6, 2025 00:08
@debdutdeb
Copy link
Member

debdutdeb commented Aug 6, 2025

I've been just passing a skipMatrix optional arg to each function to avoid echo. But should have a better way to both reuse internal functions and evade the echo trap.

debdutdeb pushed a commit that referenced this pull request Aug 18, 2025
@ricardogarim @debdutdeb
fix: messages redaction echo (#36633)
6301344
sampaiodiego pushed a commit that referenced this pull request Aug 21, 2025
@ricardogarim @sampaiodiego
fix: messages redaction echo (#36633)
958e9cd
sampaiodiego pushed a commit that referenced this pull request Sep 2, 2025
@ricardogarim @sampaiodiego
fix: messages redaction echo (#36633)
86f4486
ggazzo pushed a commit that referenced this pull request Sep 16, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
d2dbad1
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
b0e4e62
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
d9c8d34
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
60214b1
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
e174886
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
b82d3b2
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
e119fc9
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
799c0ad
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
1ed2d62
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
5049a2a
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
5eef6ce
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
2b3946c
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
383de57
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
06310e2
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
2eebbf2
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
bab466c
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
ccaa236
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
3cd0d93
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
eab8089
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
cb0c183
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
4cda729
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
b3afe60
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
e6abf08
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
acfa7ca
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
0c7849e
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
0ac29ec
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
9decb8c
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
8950456
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
c86a545
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
a0195f3
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
1a1758f
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
4f9b805
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
728b590
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
fd42b9d
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
2cf8e15
ggazzo pushed a commit that referenced this pull request Sep 19, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
492dba6
ggazzo pushed a commit that referenced this pull request Sep 19, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
129e9cb
ggazzo pushed a commit that referenced this pull request Sep 23, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
d7589b9
ggazzo pushed a commit that referenced this pull request Sep 25, 2025
@ricardogarim @ggazzo
fix: messages redaction echo (#36633)
535a4a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ricardogarim @debdutdeb