-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: Display scrollbars while pointer moves or user scrolls #36623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: bcc264f The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36623 +/- ##
===========================================
- Coverage 65.68% 65.66% -0.02%
===========================================
Files 3197 3197
Lines 106812 106799 -13
Branches 20337 20328 -9
===========================================
- Hits 70155 70127 -28
- Misses 34014 34027 +13
- Partials 2643 2645 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
https://github.com/RocketChat/Rocket.Chat/pull/36623/files In 7.5.0, they re-implemented how they manage scrollbars. A negative side-effect was that scrollbars auto-hide even on platforms that have no elevator-less scrolling ability. This PR causes the scrollbar to reappear on any mouse movement. Issue-Url: https://seekingalpha.atlassian.net/browse/AR-3667
https://github.com/RocketChat/Rocket.Chat/pull/36623/files In 7.5.0, they re-implemented how they manage scrollbars. A negative side-effect was that scrollbars auto-hide even on platforms that have no elevator-less scrolling ability. This PR causes the scrollbar to reappear on any mouse movement. Issue-Url: https://seekingalpha.atlassian.net/browse/AR-3667
Proposed changes (including videos or screenshots)
Our current "on scroll" only auto hide strategy for scrollbars, have been tricky for users, specially for those without touchpads or those that rely on mouse. After a discussion with the design team, we decided to change the approach to make the scroll's affordance more visible when moving the pointer in a scrollable area.
So, this PR aims to adopt the approach of hide scrollbars unless the pointer moves in the element or the user scrolls.
Issue(s)
Closes #31717
Closes #22331
Steps to test or reproduce
Further comments
CORE-1151